You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/11 03:29:16 UTC

[GitHub] [spark] gatorsmile commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

gatorsmile commented on pull request #31517:
URL: https://github.com/apache/spark/pull/31517#issuecomment-896472030


   Sorry for my late review. 
   
   @LuciferYang Since it adds the new dependences, could you show us the benefits besides the one in the micro-benchmark? Yes, Caffeine is faster than Guava Cache from benchmarks, but does it affect our performance if it is not being used in any hot path? Maybe I am wrong, could you show me an example?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org