You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/02/26 06:04:42 UTC
[PR] feature(c/driver): add support for CMake packages of Go based drivers [arrow-adbc]
kou opened a new pull request, #2561:
URL: https://github.com/apache/arrow-adbc/pull/2561
Fixes #2506.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(c/driver): add support for CMake packages of Go based drivers [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #2561:
URL: https://github.com/apache/arrow-adbc/pull/2561#issuecomment-2684050419
I'm wondering if clang for Windows can get around this but Microsoft stopped offering developer VMs and so I have no way of trying it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(c/driver): add support for CMake packages of Go based drivers [arrow-adbc]
Posted by "m-kuhn (via GitHub)" <gi...@apache.org>.
m-kuhn commented on PR #2561:
URL: https://github.com/apache/arrow-adbc/pull/2561#issuecomment-2684134613
Ideally the build system would be passed from the cmake environment to the go build so we would reuse same compiler (and flags etc).
@lidavidm hint: if you want a (cli only) windows, you could use a windows github action runner and connect via ssh with https://github.com/mxschmitt/action-tmate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(c/driver): add support for CMake packages of Go based drivers [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #2561:
URL: https://github.com/apache/arrow-adbc/pull/2561#issuecomment-2684039379
The CGo builds require GCC, basically. They won't work with MSVC. https://github.com/apache/arrow-adbc/issues/634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(c/driver): add support for CMake packages of Go based drivers [arrow-adbc]
Posted by "m-kuhn (via GitHub)" <gi...@apache.org>.
m-kuhn commented on PR #2561:
URL: https://github.com/apache/arrow-adbc/pull/2561#issuecomment-2684028063
This looks good @lidavidm, I guess it will be picked up
I had troubles with the Go based drivers actually, as they would trigger a build process with another compiler which was not available (more precisely: when building with MSVC it would try to build things with gcc). I didn't follow up with this yet and postponed this to later, as I don't have an urgent need for this.
https://github.com/microsoft/vcpkg/pull/43721/files#diff-af89ca8a4f63f503c397ba7497f33cab6fa0bc8b3795d215bb027218480f7195R26-R32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(c/driver): add support for CMake packages of Go based drivers [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #2561:
URL: https://github.com/apache/arrow-adbc/pull/2561#issuecomment-2684142767
That is the problem here: CGo is being told to invoke MSVC, and it is dutifully doing that, but CGo only supports GCC and so it breaks down. (https://github.com/golang/go/issues/20982)
Apparently clang for Windows also doesn't work: https://github.com/golang/go/issues/17014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(c/driver): add support for CMake packages of Go based drivers [arrow-adbc]
Posted by "m-kuhn (via GitHub)" <gi...@apache.org>.
m-kuhn commented on PR #2561:
URL: https://github.com/apache/arrow-adbc/pull/2561#issuecomment-2684226183
Oh, I see.
We could expose these features available on !windows only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(c/driver): add support for CMake packages of Go based drivers [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #2561:
URL: https://github.com/apache/arrow-adbc/pull/2561#issuecomment-2684143344
So I think these targets can't be exposed on Windows unless/until Google fixes this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(c/driver): add support for CMake packages of Go based drivers [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #2561:
URL: https://github.com/apache/arrow-adbc/pull/2561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org