You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/11/06 16:38:49 UTC

[GitHub] andrzej-kaczmarek commented on a change in pull request #1505: hw/drivers: Add display driver SSD1673

andrzej-kaczmarek commented on a change in pull request #1505: hw/drivers: Add display driver SSD1673
URL: https://github.com/apache/mynewt-core/pull/1505#discussion_r231197336
 
 

 ##########
 File path: hw/drivers/display/ssd1673/src/ssd1673.c
 ##########
 @@ -4,19 +4,18 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-#define LOG_LEVEL CONFIG_DISPLAY_LOG_LEVEL
-#include <logging/log.h>
-LOG_MODULE_REGISTER(ssd1673);
+#include <stdint.h>
 
-#include <string.h>
-#include <device.h>
-#include <display.h>
-#include <init.h>
-#include <gpio.h>
-#include <spi.h>
+#include "os/mynewt.h"
+#include "hal/hal_gpio.h"
+#include "hal/hal_spi.h"
+#include "mcu/nrf52_hal.h"
 
 Review comment:
   this is available only for nrf52xxx so should not be here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services