You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/11/21 05:15:38 UTC

[GitHub] [hadoop] riyakhdl commented on pull request #5113: YARN-6971 Clean up different ways to create resources

riyakhdl commented on PR #5113:
URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1321479727

   @ashutoshcipher Thanks for the review, 
   1. I have done a small performance test to prove it, hence attaching the logs.
   [code_Benchmarking.txt](https://github.com/apache/hadoop/files/10053607/code_Benchmarking.txt)
   [log_Benchmarking.txt](https://github.com/apache/hadoop/files/10053608/log_Benchmarking.txt)
   
   2. Yes, I have done the changes. 
   
   
   
   > Thanks @riyakhdl for your contribution. I have a couple of comments.
   > 
   > 1. Possible to add any performance stats due to this?
   > 2. I can see you haven't replaced `BuilderUtils.newResource` in all the places in YARN module. Can you do that?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org