You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HappenLee (via GitHub)" <gi...@apache.org> on 2026/04/15 05:21:28 UTC
[PR] [Exec](status) materialization_opertor return the error status by row_id_fetcher [doris]
HappenLee opened a new pull request, #62513:
URL: https://github.com/apache/doris/pull/62513
### What problem does this PR solve?
Problem Summary:
- MaterializationOperator did not check rpc_struct.response.status().status_code after row_id_fetcher RPCs, so backend-side errors were not propagated to the caller.
- This change verifies the RPC response status; if status_code != 0, it constructs an error message containing backend id, status_code, error_msg and the Materialization Sink node id, and returns Status::InternalError so the error is reported upstream.
### Release note
None
### Check List (For Author)
- Test
- [ ] Regression test
- [ ] Unit Test
- [x] Manual test
- Simulate row_id_fetcher returning a non-zero status; verify push returns InternalError and the error message includes backend id, status_code, error_msg, and Materialization Sink node id.
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
- Behavior changed:
- [x] Yes. MaterializationOperator now returns InternalError when row_id_fetcher reports an error (improved error reporting).
- [ ] No.
- Does this need documentation?
- [ ] No.
- [x] Yes (optional) — document that MaterializationOperator will surface row_id_fetcher RPC errors as InternalError.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [x] Confirm test cases (manual test)
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Exec](status) materialization_opertor return the error status by row_id_fetcher [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #62513:
URL: https://github.com/apache/doris/pull/62513#issuecomment-4251812832
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Exec](status) materialization_opertor return the error status by row_id_fetcher [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #62513:
URL: https://github.com/apache/doris/pull/62513#issuecomment-4249445746
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Exec](status) materialization_opertor return the error status by row_id_fetcher [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62513:
URL: https://github.com/apache/doris/pull/62513#issuecomment-4252800291
# BE Regression && UT Coverage Report
Increment line coverage `16.67% (1/6)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62513_508eb427368de5fa3819bc3c0892b2f2bd237292_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62513_508eb427368de5fa3819bc3c0892b2f2bd237292_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.65% (27400/37204) |
| Line Coverage | 57.33% (296186/516621) |
| Region Coverage | 54.49% (246443/452279) |
| Branch Coverage | 56.17% (106870/190250) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Exec](status) materialization_opertor return the error status by row_id_fetcher [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #62513:
URL: https://github.com/apache/doris/pull/62513#issuecomment-4249446300
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Exec](status) materialization_opertor return the error status by row_id_fetcher [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62513:
URL: https://github.com/apache/doris/pull/62513#issuecomment-4260377248
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Exec](status) materialization_opertor return the error status by row_id_fetcher [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #62513:
URL: https://github.com/apache/doris/pull/62513#issuecomment-4251605358
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Exec](status) materialization_opertor return the error status by row_id_fetcher [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62513:
URL: https://github.com/apache/doris/pull/62513#issuecomment-4250101146
# BE Regression && UT Coverage Report
Increment line coverage `12.50% (1/8)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62513_9d6e8fd640968944a45919e5b2ddcbc71a979e63_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62513_9d6e8fd640968944a45919e5b2ddcbc71a979e63_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.92% (26760/37210) |
| Line Coverage | 54.93% (283739/516519) |
| Region Coverage | 51.94% (234907/452226) |
| Branch Coverage | 53.37% (101511/190206) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Exec](status) materialization_opertor return the error status by row_id_fetcher [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62513:
URL: https://github.com/apache/doris/pull/62513#discussion_r3086131154
##########
be/src/exec/operator/materialization_opertor.cpp:
##########
@@ -416,6 +416,14 @@ Status MaterializationOperator::push(RuntimeState* state, Block* in_block, bool
" target_backend_id:" + std::to_string(backend_id);
return Status::InternalError(error_text);
}
+ if (rpc_struct.response.status().status_code() != 0) {
Review Comment:
This does catch the backend-side row_id_fetcher failure, but it rewrites every remote `PStatus` into `Status::InternalError(...)`.
`RowIdStorageReader::read_by_rowids()` can return non-`INTERNAL_ERROR` codes (`CANCELLED`, `Error<false>(e.code(), ...)`, etc.), and nearby RPC callers preserve them with `Status::create(response.status())` (for example `be/src/service/internal_service.cpp:1250` and `be/src/storage/rowset_version_mgr.cpp:272`). Converting them all to `INTERNAL_ERROR` changes the status seen upstream and can affect cancellation / retry handling.
Please build the extra backend/node context around `Status::create(rpc_struct.response.status())` instead of replacing the remote status code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Exec](status) materialization_opertor return the error status by row_id_fetcher [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62513:
URL: https://github.com/apache/doris/pull/62513#discussion_r3086274491
##########
be/src/exec/operator/materialization_opertor.cpp:
##########
@@ -416,6 +416,12 @@ Status MaterializationOperator::push(RuntimeState* state, Block* in_block, bool
" target_backend_id:" + std::to_string(backend_id);
return Status::InternalError(error_text);
}
+ if (rpc_struct.response.status().status_code() != 0) {
Review Comment:
This is the right place to propagate the backend-side RPC status, but the patch still needs automated coverage. `MaterializationOperator::push()` is a core execution path, and the repo review rules require tests for behavior changes like this one. There is already `be/test/exec/operator/materialization_shared_state_test.cpp`; please add a negative test that injects a non-zero `PMultiGetResponseV2.status()` and verifies the returned `Status` includes the backend id / node context instead of relying only on manual validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Exec](status) materialization_opertor return the error status by row_id_fetcher [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb merged PR #62513:
URL: https://github.com/apache/doris/pull/62513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Exec](status) materialization_opertor return the error status by row_id_fetcher [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #62513:
URL: https://github.com/apache/doris/pull/62513#issuecomment-4251764566
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Exec](status) materialization_opertor return the error status by row_id_fetcher [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #62513:
URL: https://github.com/apache/doris/pull/62513#issuecomment-4251762430
/reveiw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org