You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/10 07:08:33 UTC

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10287: Move the user configuration to authority rule

tristaZero commented on a change in pull request #10287:
URL: https://github.com/apache/shardingsphere/pull/10287#discussion_r629096519



##########
File path: shardingsphere-infra/shardingsphere-infra-context/src/main/java/org/apache/shardingsphere/infra/context/metadata/MetaDataContextsBuilder.java
##########
@@ -94,7 +93,7 @@ public StandardMetaDataContexts build() throws SQLException {
         for (String each : schemaRuleConfigs.keySet()) {
             mataDataMap.put(each, buildMetaData(each));
         }
-        return new StandardMetaDataContexts(mataDataMap, buildGlobalSchemaMetaData(mataDataMap), executorEngine, new ShardingSphereUsers(users), props);
+        return new StandardMetaDataContexts(mataDataMap, buildGlobalSchemaMetaData(mataDataMap), executorEngine, new ShardingSphereUsers(getUsersFromAuthorityRule()), props);

Review comment:
       `ShardingSphereUsers(users)` is expected to be removed from `StandardMetaDataContexts`. That way, `getUsersFromAuthorityRule ()` and `shardingsphere-infra-authority-api` of `shardingsphere-infra/shardingsphere-infra-context/pom.xml` can be deleted together. 
   
   Finally, all the content concerning `authority` and `users` will be restricted in the `Authority` global rule. That's our ideal result.
   
   
   @zhujunxxxxx This PR looks great really. I did not imagine we can merge it one! Thanks for your prompt nice work.
   @huanghao495430759 Please give a glance at this comment. Your issue has no block, go ahead pacing yourself.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org