[GitHub] [sling-org-apache-sling-event] kwin commented on a diff in pull request #26: SLING-11831 - Allow setting job properties for custom job state

["kwin (via GitHub)" <gi...@apache.org>]

kwin commented on code in PR #26:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1181019895


##########
src/main/java/org/apache/sling/event/impl/jobs/queues/JobExecutionContextImpl.java:
##########
@@ -84,6 +84,22 @@ public void updateProgress(final long eta) {
         }
     }
 
+    @Override
+    public void setProperty(final String name, final Object value) {
+        if ( name == null ) {
+            throw new IllegalArgumentException("Name must not be null");

Review Comment:
   we use other null annotations in Sling: https://sling.apache.org/documentation/development/null-analysis.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org