You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2023/03/17 21:05:24 UTC

[GitHub] [arrow] mapleFU commented on a diff in pull request #34616: GH-29238 [C++][Dataset][Parquet] Support parquet modular encryption in the new Dataset API

mapleFU commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1140705190


##########
cpp/src/parquet/properties.h:
##########
@@ -209,6 +209,22 @@ class PARQUET_EXPORT WriterProperties {
           created_by_(DEFAULT_CREATED_BY),
           store_decimal_as_integer_(false),
           page_checksum_enabled_(false) {}
+    
+    Builder(const WriterProperties& properties)

Review Comment:
   would you mind assign them in ctor list?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org