[GitHub] [superset] ktmud commented on a change in pull request #12468: fix: Added message flash when chart with missing dataset is accessed.

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #12468:
URL: https://github.com/apache/superset/pull/12468#discussion_r556072568



##########
File path: superset/views/core.py
##########
@@ -703,6 +703,7 @@ def explore(  # pylint: disable=too-many-locals,too-many-return-statements
                 datasource_id, datasource_type, form_data
             )
         except SupersetException:
+            flash("The dataset associated with this chart no longer exists", "danger")

Review comment:
       And don't forget to add i18n: 
   
   ```python
   _("Error occurred when trying to open the chart: %(error), error=utils.error_msg_from_exception(ex))
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org