You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@doris.apache.org by GitBox <gi...@apache.org> on 2019/08/07 04:35:28 UTC

[GitHub] [incubator-doris] imay commented on a change in pull request #1593: Fix parquet directory have empty file

imay commented on a change in pull request #1593: Fix parquet directory have empty file
URL: https://github.com/apache/incubator-doris/pull/1593#discussion_r311365030
 
 

 ##########
 File path: be/src/exec/parquet_scanner.cpp
 ##########
 @@ -142,7 +142,12 @@ Status ParquetScanner::open_next_reader() {
             continue;
         }
         _cur_file_reader = new ParquetReaderWrap(file_reader.release());
-        return _cur_file_reader->init_parquet_reader(_src_slot_descs);
+        Status status = _cur_file_reader->init_parquet_reader(_src_slot_descs);
+        if(status.is_end_of_file()) {
 
 Review comment:
   ```suggestion
           if (status.is_end_of_file()) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org