You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2015/02/04 00:20:11 UTC

Review Request 30586: Fix exception when opening cron urls.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen and Bill Farner.


Bugs: AURORA-1094
    https://issues.apache.org/jira/browse/AURORA-1094


Repository: aurora


Description
-------

Fix exception when opening cron urls.


Diffs
-----

  src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 
  src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a 

Diff: https://reviews.apache.org/r/30586/diff/


Testing
-------

./pants goal test src/test/python/apache/aurora/client/cli:cron


Thanks,

Zameer Manji


Re: Review Request 30586: Fix exception when opening cron urls.

Posted by Joshua Cohen <jc...@twopensource.com>.

> On Feb. 3, 2015, 11:34 p.m., Joshua Cohen wrote:
> > Is this indicative of a more wide spread problem?
> > 
> >     $ find src/main -name *.py |xargs grep "context.options.jobspec" |wc -l
> >       43

Nevermind, read the fix backwards ;).


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review70856
-----------------------------------------------------------


On Feb. 3, 2015, 11:20 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30586/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 11:20 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1094
>     https://issues.apache.org/jira/browse/AURORA-1094
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix exception when opening cron urls.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 
>   src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a 
> 
> Diff: https://reviews.apache.org/r/30586/diff/
> 
> 
> Testing
> -------
> 
> ./pants goal test src/test/python/apache/aurora/client/cli:cron
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 30586: Fix exception when opening cron urls.

Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review70856
-----------------------------------------------------------


Is this indicative of a more wide spread problem?

    $ find src/main -name *.py |xargs grep "context.options.jobspec" |wc -l
      43

- Joshua Cohen


On Feb. 3, 2015, 11:20 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30586/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 11:20 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1094
>     https://issues.apache.org/jira/browse/AURORA-1094
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix exception when opening cron urls.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 
>   src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a 
> 
> Diff: https://reviews.apache.org/r/30586/diff/
> 
> 
> Testing
> -------
> 
> ./pants goal test src/test/python/apache/aurora/client/cli:cron
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 30586: Fix exception when opening cron urls.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review70851
-----------------------------------------------------------



src/test/python/apache/aurora/client/cli/test_cron.py
<https://reviews.apache.org/r/30586/#comment116298>

    This seems like a copy/paste and should be redundant here and in other relevant test cases.



src/test/python/apache/aurora/client/cli/test_cron.py
<https://reviews.apache.org/r/30586/#comment116301>

    How about validating the option was actually used? There is another test `test_simple_successful_create_job_open_page` that you can model after.


- Maxim Khutornenko


On Feb. 3, 2015, 11:20 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30586/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 11:20 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1094
>     https://issues.apache.org/jira/browse/AURORA-1094
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix exception when opening cron urls.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 
>   src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a 
> 
> Diff: https://reviews.apache.org/r/30586/diff/
> 
> 
> Testing
> -------
> 
> ./pants goal test src/test/python/apache/aurora/client/cli:cron
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 30586: Fix exception when opening cron urls.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review70860
-----------------------------------------------------------

Ship it!


Master (2742120) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 3, 2015, 11:20 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30586/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 11:20 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1094
>     https://issues.apache.org/jira/browse/AURORA-1094
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix exception when opening cron urls.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 
>   src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a 
> 
> Diff: https://reviews.apache.org/r/30586/diff/
> 
> 
> Testing
> -------
> 
> ./pants goal test src/test/python/apache/aurora/client/cli:cron
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 30586: Fix exception when opening cron urls.

Posted by Zameer Manji <zm...@apache.org>.

> On Feb. 3, 2015, 5:47 p.m., Maxim Khutornenko wrote:
> > src/test/python/apache/aurora/client/cli/test_cron.py, line 138
> > <https://reviews.apache.org/r/30586/diff/2/?file=846914#file846914line138>
> >
> >     You may want to drop unused CLUSTER patching in other tests as well.

The other tests require the CLUSTER patching.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review70895
-----------------------------------------------------------


On Feb. 3, 2015, 5:14 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30586/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 5:14 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1094
>     https://issues.apache.org/jira/browse/AURORA-1094
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix exception when opening cron urls.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 
>   src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a 
> 
> Diff: https://reviews.apache.org/r/30586/diff/
> 
> 
> Testing
> -------
> 
> ./pants goal test src/test/python/apache/aurora/client/cli:cron
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 30586: Fix exception when opening cron urls.

Posted by Maxim Khutornenko <ma...@apache.org>.

> On Feb. 4, 2015, 1:47 a.m., Maxim Khutornenko wrote:
> > src/test/python/apache/aurora/client/cli/test_cron.py, line 138
> > <https://reviews.apache.org/r/30586/diff/2/?file=846914#file846914line138>
> >
> >     You may want to drop unused CLUSTER patching in other tests as well.
> 
> Zameer Manji wrote:
>     The other tests require the CLUSTER patching.

In their current shape of intergration tests punching through the API - they do. However, you can convert them to use fake api (similar to the test you added) and make them true unit tests.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review70895
-----------------------------------------------------------


On Feb. 4, 2015, 1:14 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30586/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 1:14 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1094
>     https://issues.apache.org/jira/browse/AURORA-1094
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix exception when opening cron urls.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 
>   src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a 
> 
> Diff: https://reviews.apache.org/r/30586/diff/
> 
> 
> Testing
> -------
> 
> ./pants goal test src/test/python/apache/aurora/client/cli:cron
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 30586: Fix exception when opening cron urls.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review70895
-----------------------------------------------------------

Ship it!



src/test/python/apache/aurora/client/cli/test_cron.py
<https://reviews.apache.org/r/30586/#comment116361>

    You may want to drop unused CLUSTER patching in other tests as well.


- Maxim Khutornenko


On Feb. 4, 2015, 1:14 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30586/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 1:14 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1094
>     https://issues.apache.org/jira/browse/AURORA-1094
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix exception when opening cron urls.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 
>   src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a 
> 
> Diff: https://reviews.apache.org/r/30586/diff/
> 
> 
> Testing
> -------
> 
> ./pants goal test src/test/python/apache/aurora/client/cli:cron
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 30586: Fix exception when opening cron urls.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review70896
-----------------------------------------------------------


Master (2742120) is red with this patch.
  ./build-support/jenkins/build.sh

  File "<stdin>", line 6, in <module>
  File "setup.py", line 212, in <module>
    "Protocol Buffers are Google's data interchange format.",
  File "/usr/lib/python2.7/distutils/core.py", line 111, in setup
    _setup_distribution = dist = klass(attrs)
  File "build/bdist.linux-x86_64/egg/setuptools/dist.py", line 239, in __init__
  File "build/bdist.linux-x86_64/egg/setuptools/dist.py", line 264, in fetch_build_eggs
  File "build/bdist.linux-x86_64/egg/pkg_resources.py", line 580, in resolve
    keys2.append(dist.key)
  File "build/bdist.linux-x86_64/egg/pkg_resources.py", line 818, in best_match
    
  File "build/bdist.linux-x86_64/egg/pkg_resources.py", line 830, in obtain
    for item in search_path:
  File "build/bdist.linux-x86_64/egg/setuptools/dist.py", line 314, in fetch_build_egg
  File "build/bdist.linux-x86_64/egg/setuptools/command/easy_install.py", line 581, in easy_install
    
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 591, in fetch_distribution
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 428, in find_packages
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 769, in scan_url
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 326, in process_url
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 405, in process_index
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 769, in scan_url
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 313, in process_url
  File "/usr/lib/python2.7/socket.py", line 351, in read
    data = self._sock.recv(rbufsize)
  File "/usr/lib/python2.7/httplib.py", line 543, in read
    return self._read_chunked(amt)
  File "/usr/lib/python2.7/httplib.py", line 603, in _read_chunked
    value.append(self._safe_read(amt))
  File "/usr/lib/python2.7/httplib.py", line 658, in _safe_read
    chunk = self.fp.read(min(amt, MAXAMOUNT))
  File "/usr/lib/python2.7/socket.py", line 380, in read
    data = self._sock.recv(left)
socket.timeout: timed out


               FAILURE
Exception message: Package SourcePackage(u'https://pypi.python.org/packages/source/p/protobuf/protobuf-3.0.0-alpha-1.tar.gz#md5=7318fdb3dc43390b305dbc4f0df2aefa') is not translateable.




I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 4, 2015, 1:14 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30586/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 1:14 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1094
>     https://issues.apache.org/jira/browse/AURORA-1094
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix exception when opening cron urls.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 
>   src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a 
> 
> Diff: https://reviews.apache.org/r/30586/diff/
> 
> 
> Testing
> -------
> 
> ./pants goal test src/test/python/apache/aurora/client/cli:cron
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 30586: Fix exception when opening cron urls.

Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review70918
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Cohen


On Feb. 4, 2015, 1:14 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30586/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 1:14 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1094
>     https://issues.apache.org/jira/browse/AURORA-1094
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix exception when opening cron urls.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 
>   src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a 
> 
> Diff: https://reviews.apache.org/r/30586/diff/
> 
> 
> Testing
> -------
> 
> ./pants goal test src/test/python/apache/aurora/client/cli:cron
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 30586: Fix exception when opening cron urls.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review70912
-----------------------------------------------------------

Ship it!


Master (9fe6d54) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 4, 2015, 1:14 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30586/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 1:14 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1094
>     https://issues.apache.org/jira/browse/AURORA-1094
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix exception when opening cron urls.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 
>   src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a 
> 
> Diff: https://reviews.apache.org/r/30586/diff/
> 
> 
> Testing
> -------
> 
> ./pants goal test src/test/python/apache/aurora/client/cli:cron
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 30586: Fix exception when opening cron urls.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review71109
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On Feb. 4, 2015, 1:14 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30586/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 1:14 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1094
>     https://issues.apache.org/jira/browse/AURORA-1094
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix exception when opening cron urls.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 
>   src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a 
> 
> Diff: https://reviews.apache.org/r/30586/diff/
> 
> 
> Testing
> -------
> 
> ./pants goal test src/test/python/apache/aurora/client/cli:cron
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 30586: Fix exception when opening cron urls.

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review70900
-----------------------------------------------------------


@ReviewBot retry

- Zameer Manji


On Feb. 3, 2015, 5:14 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30586/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 5:14 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1094
>     https://issues.apache.org/jira/browse/AURORA-1094
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix exception when opening cron urls.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 
>   src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a 
> 
> Diff: https://reviews.apache.org/r/30586/diff/
> 
> 
> Testing
> -------
> 
> ./pants goal test src/test/python/apache/aurora/client/cli:cron
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 30586: Fix exception when opening cron urls.

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/
-----------------------------------------------------------

(Updated Feb. 4, 2015, 6:08 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
-------

Maxim's feedback.


Bugs: AURORA-1094
    https://issues.apache.org/jira/browse/AURORA-1094


Repository: aurora


Description
-------

Fix exception when opening cron urls.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 
  src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a 

Diff: https://reviews.apache.org/r/30586/diff/


Testing
-------

./pants goal test src/test/python/apache/aurora/client/cli:cron


Thanks,

Zameer Manji


Re: Review Request 30586: Fix exception when opening cron urls.

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/
-----------------------------------------------------------

(Updated Feb. 3, 2015, 5:14 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
-------

Maxim's feedback.


Bugs: AURORA-1094
    https://issues.apache.org/jira/browse/AURORA-1094


Repository: aurora


Description
-------

Fix exception when opening cron urls.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 
  src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a 

Diff: https://reviews.apache.org/r/30586/diff/


Testing
-------

./pants goal test src/test/python/apache/aurora/client/cli:cron


Thanks,

Zameer Manji