[GitHub] [solr] janhoy edited a comment on pull request #399: SOLR-15776 Make Admin UI play well with Authorization

[GitBox <gi...@apache.org>]

janhoy edited a comment on pull request #399:
URL: https://github.com/apache/solr/pull/399#issuecomment-1013863128


   I added two more improvements:
   * Determine if shcemeDesignerEnabled by isPermitted() checks instead of HTTP call
   * Disable clickable log-levels page if you don't have CONFIG_EDIT permission. This is just a partial fix, as the mouse pointer still changes to hand and the edit symbol comes up. But nothing happens when clicking.
   
   TODO
   * I user has a custom Authorization plugin that don't use RBAP, the UI should fall back to always return true for `isPermitted()`, as checking for the predefined permissions won't make much sense
   * ~Open a JIRA for remaining UI work (hiding/dimming menu choices and buttons everywhere in UI based on [mappings](https://docs.google.com/spreadsheets/d/1s2xokDxw9IkXr7ZA5n06RPDj6EwvpbsZ7zUeKpvRC3Q/edit?usp=sharing))~ See https://issues.apache.org/jira/browse/SOLR-15928


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org