[GitHub] flink pull request #5376: [FLINK-6214] WindowAssigners do not allow negative...

[jelmerk <gi...@git.apache.org>]

GitHub user jelmerk opened a pull request:

    https://github.com/apache/flink/pull/5376

    [FLINK-6214] WindowAssigners do not allow negative offsets

    ## What is the purpose of the change
    
    The javadoc of TumblingEventTimeWindows and TumblingProcessingTimeWindows suggest that it is possible to use negative offsets but in practice this is not supported. This patch remedies this situation
    
    ## Brief change log
    
    - updated behavior of TumblingEventTimeWindows & TumblingProcessingTimeWindows
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
    - Added testWindowAssignmentWithNegativeOffset method in TumblingEventTimeWindowsTest & TumblingProcessingTimeWindowsTest
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jelmerk/flink negative_offsets

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5376.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5376
    
----
commit 07f5577d67155c86af72dac85f7c96b4fea06456
Author: Jelmer Kuperus <jk...@...>
Date:   2018-01-28T22:22:10Z

    FLINK-6214: allow negative offsets

----


---

[GitHub] flink issue #5376: [FLINK-6214] WindowAssigners do not allow negative offset...

[StephanEwen <gi...@git.apache.org>]

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5376
  
    Ah, one problem: What happens if the offset is larger (by absolute value) than the window length? Then the offset would still be negative with this change.


---

[GitHub] flink issue #5376: [FLINK-6214] WindowAssigners do not allow negative offset...

[StephanEwen <gi...@git.apache.org>]

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5376
  
    If we decide that we want to support negative offsets, this looks like a good implementation.
    
    @aljoscha what is your take, should we support negative offsets?


---