You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/18 12:56:16 UTC
[GitHub] [airflow] BasPH opened a new pull request #19679: Fix the link to the Graph view in the Tree view DAGRun modal
BasPH opened a new pull request #19679:
URL: https://github.com/apache/airflow/pull/19679
The Graph link in the DAG run modal in the new Tree view is broken because the DAG id is passed in a parameter named `dagId` and the URL is built assuming a parameter named `dag_id` ([link](https://github.com/apache/airflow/blob/main/airflow/www/static/js/dag.js#L227)). As a result, the user is forwarded to the main page and gets an error:
This PR fixes the URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19679: Fix the link to the Graph view in the Tree view DAGRun modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19679:
URL: https://github.com/apache/airflow/pull/19679#issuecomment-972853140
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #19679: Fix the link to the Graph view in the Tree view DAGRun modal
Posted by GitBox <gi...@apache.org>.
bbovenzi merged pull request #19679:
URL: https://github.com/apache/airflow/pull/19679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org