[jira] Commented: (GERONIMO-2293) Can't deploy exploded WAR with plan with no environment

["Vamsavardhana Reddy (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/GERONIMO-2293?page=comments#action_12450096 ] 
            
Vamsavardhana Reddy commented on GERONIMO-2293:
-----------------------------------------------

The exception is because File.getName() for the directory file is returning "." and is being stripped-off to get an artifactId which is an empty string.  The situation can be improved by using File.getCanonicalFile().getName() as the artifactId.  This will result in a failure only in the extreme case of deploying the root directory in Unix and drive root on windows.

This needs to be taken care of in all module builders generating an artifactId from the filename.

> Can't deploy exploded WAR with plan with no environment
> -------------------------------------------------------
>
>                 Key: GERONIMO-2293
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2293
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 1.1
>            Reporter: Aaron Mulder
>             Fix For: 1.1.2
>
>         Attachments: web-app-no-environment.war
>
>
> Tried:
> {noformat}
> java -jar /server/geronimo-jetty-1.1/bin/deployer.jar deploy .
> {noformat}
> and got:
> {noformat}
>     Error: Unable to distribute .: java.lang.IllegalArgumentException:
>     Incoming Artifact must have an ArtifactID (not ///war)
>         Incoming Artifact must have an ArtifactID (not ///war)
> {noformat}
> with stack trace:
> {noformat}
> 19:52:41,171 ERROR [Deployer] Deployment failed due to
> java.lang.IllegalArgumentException: Incoming Artifact must have an ArtifactID (not ///war)
>         at org.apache.geronimo.deployment.ModuleIDBuilder.resolve(ModuleIDBuilder.java:77)
>         at org.apache.geronimo.deployment.ModuleIDBuilder.resolve(ModuleIDBuilder.java:110)
>         at org.apache.geronimo.jetty.deployment.JettyModuleBuilder.createModule(JettyModuleBuilder.java:231)
>         at org.apache.geronimo.web.deployment.AbstractWebModuleBuilder.createModule(AbstractWebModuleBuilder.java:114)
>         at org.apache.geronimo.web.deployment.AbstractWebModuleBuilder$$FastClassByCGLIB$$459e0cc.invoke(<generated>)
> ...
> {noformat}
> with geronimo-web.xml:
> {noformat}
> <?xml version="1.0" encoding="UTF-8"?>
> <web-app
>   xmlns="http://geronimo.apache.org/xml/ns/j2ee/web-1.1"
>   xmlns:security="http://geronimo.apache.org/xml/ns/security-1.1">
>     <security-realm-name>TestRealm</security-realm-name>
>     <security:security>
>     ...
>     </security:security>
> </web-app>
> {noformat}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira