You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2018/11/14 23:20:57 UTC
Review Request 69339: Break up UpdateDeleteSemanticAnalyzer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69339/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-20919
https://issues.apache.org/jira/browse/HIVE-20919
Repository: hive-git
Description
-------
UpdateDeleteSemanticAnalyzer handles update, delete, acid export and merge queries by rewriting them to a different form. This is a clear violation of SRP, and therefore needs to be refactored. An abstract ancestor needs to take the common part, and each of the specific tasks should be handled by a separate class.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/AcidExportSemanticAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/RewriteSemanticAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 088b5cf
ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java 8651afd
ql/src/java/org/apache/hadoop/hive/ql/plan/ExportWork.java d91569e
Diff: https://reviews.apache.org/r/69339/diff/1/
Testing
-------
Tested by running all the unit tests, and q tests against these functionalities, and they are still fine.
Also tested on local cluster, the commands are still working.
Thanks,
Miklos Gergely
Re: Review Request 69339: Break up UpdateDeleteSemanticAnalyzer
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69339/
-----------------------------------------------------------
(Updated Nov. 15, 2018, 9:43 a.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------
Fixed some checkstyle issues.
Bugs: HIVE-20919
https://issues.apache.org/jira/browse/HIVE-20919
Repository: hive-git
Description
-------
UpdateDeleteSemanticAnalyzer handles update, delete, acid export and merge queries by rewriting them to a different form. This is a clear violation of SRP, and therefore needs to be refactored. An abstract ancestor needs to take the common part, and each of the specific tasks should be handled by a separate class.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/AcidExportSemanticAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/RewriteSemanticAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 088b5cf
ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java 8651afd
ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 423ca2a
ql/src/java/org/apache/hadoop/hive/ql/plan/ExportWork.java d91569e
Diff: https://reviews.apache.org/r/69339/diff/2/
Changes: https://reviews.apache.org/r/69339/diff/1-2/
Testing
-------
Tested by running all the unit tests, and q tests against these functionalities, and they are still fine.
Also tested on local cluster, the commands are still working.
Thanks,
Miklos Gergely