[jira] [Commented] (ROCKETMQ-191) Fix incorret socket option

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999444#comment-15999444 ] 

ASF GitHub Bot commented on ROCKETMQ-191:
-----------------------------------------

Github user vongosling commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/100
  
    That's a good polish, but I must point out the 2 point for this optimization. 1. please comply with PR best practice for title as you have corrected before. 2. you can consider the order when many logic and operator together, such as 0&&1&&1(similar 1||0||0, nor 0||0||1), making your logic more effective. For this context, linux platform and netty epoll judge, which one happen to 0 more easily.


> Fix incorret socket option
> --------------------------
>
>                 Key: ROCKETMQ-191
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-191
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-remoting
>    Affects Versions: 4.1.0-incubating
>            Reporter: Zhanhui Li
>            Assignee: Zhanhui Li
>             Fix For: 4.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)