You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "kiranchavala (via GitHub)" <gi...@apache.org> on 2023/05/23 07:34:36 UTC
[GitHub] [cloudstack] kiranchavala opened a new pull request, #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
kiranchavala opened a new pull request, #7545:
URL: https://github.com/apache/cloudstack/pull/7545
…workOffering
### Description
This PR fixes #7510
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ X ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ X ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ X ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] updated the api documentation for createNetworkOffering and updateNetworkOffering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1801921987
@weizhouapache @kiranchavala , can you agree with my suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#discussion_r1289624596
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java:
##########
@@ -73,7 +73,8 @@ public class CreateNetworkOfferingCmd extends BaseCmd {
@Parameter(name = ApiConstants.SPECIFY_VLAN, type = CommandType.BOOLEAN, description = "true if network offering supports vlans")
private Boolean specifyVlan;
- @Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING, description = "the availability of network offering. Default value is Optional")
+ @Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING, description = "the availability of network offering. The default value is Optional. "
+ + " Another value is Required, which will make it as the default network offering for new networks ")
Review Comment:
```suggestion
@Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING, description = "the availability of network offering. The default value is Optional. "
+ " Another value is Required, which will make it as the default network offering for new networks ")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1672641489
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1558845445
@andrijapanicsb a [LL] Jenkins job has been kicked to build packages. It will be bundled with (testing LL build jobs <----- ignore this) SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "andrijapanicsb (via GitHub)" <gi...@apache.org>.
andrijapanicsb commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1558858072
testing LL build jobs ----- ignore this
@blueorangutan LLpackage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1687789405
ping @kiranchavala can you review outstanding comments, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1672597906
Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1672592086
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#discussion_r1294520534
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java:
##########
@@ -55,7 +55,7 @@ public class UpdateNetworkOfferingCmd extends BaseCmd {
private String displayText;
@Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING, description = "the availability of network offering."
- + " Default value is Required for Guest Virtual network offering; Optional for Guest Direct network offering")
+ + " The default value is Required for Guest Virtual network offering, Optional for Guest Direct network offering. Only one network offering can have the value Required ")
Review Comment:
@kiranchavala
can you update this ? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1558945297
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] updated the api documentation for createNetworkOffering and updateNetworkOffering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#discussion_r1367099699
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java:
##########
@@ -55,7 +55,7 @@ public class UpdateNetworkOfferingCmd extends BaseCmd {
private String displayText;
@Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING, description = "the availability of network offering."
- + " Default value is Required for Guest Virtual network offering; Optional for Guest Direct network offering")
+ + " The default value is Required for Guest Virtual network offering, Optional for Guest Direct network offering. Only one network offering can have the value Required ")
Review Comment:
ping @kiranchavala , can you approve of my suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] updated the api documentation for createNetworkOffering and updateNetworkOffering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1804118663
only textual changes; merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] updated the api documentation for createNetworkOffering and updateNetworkOffering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
URL: https://github.com/apache/cloudstack/pull/7545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1672640724
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1558853484
Packaging result [LL]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#discussion_r1294502146
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java:
##########
@@ -55,7 +55,7 @@ public class UpdateNetworkOfferingCmd extends BaseCmd {
private String displayText;
@Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING, description = "the availability of network offering."
- + " Default value is Required for Guest Virtual network offering; Optional for Guest Direct network offering")
+ + " The default value is Required for Guest Virtual network offering, Optional for Guest Direct network offering. Only one network offering can have the value Required ")
Review Comment:
agree
actually the default value is null in [UpdateNetworkOfferingCmd.java](https://github.com/apache/cloudstack/pull/7545/files#diff-262c2af825c2e0b2c589174a93de44fe0d332ad36c321634f0f1f7ca69bc8fd5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] updated the api documentation for createNetworkOffering and updateNetworkOffering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "andrijapanicsb (via GitHub)" <gi...@apache.org>.
andrijapanicsb commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1558859109
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "andrijapanicsb (via GitHub)" <gi...@apache.org>.
andrijapanicsb commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1558852837
testing LL build jobs ----- ignore this ----> @blueorangutan LLpackage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#discussion_r1334104226
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java:
##########
@@ -55,7 +55,7 @@ public class UpdateNetworkOfferingCmd extends BaseCmd {
private String displayText;
@Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING, description = "the availability of network offering."
- + " Default value is Required for Guest Virtual network offering; Optional for Guest Direct network offering")
+ + " The default value is Required for Guest Virtual network offering, Optional for Guest Direct network offering. Only one network offering can have the value Required ")
Review Comment:
```suggestion
+ " The value is Required makes this network offering default for Guest Virtual Networks. Only one network offering can have the value Required ")
```
I do not know the significance of the term `Guest Direct network offering` in the description so I am proposing this change @weizhouapache @kiranchavala . Please enhance if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1672591931
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1672710131
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1672746338
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7545?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7545](https://app.codecov.io/gh/apache/cloudstack/pull/7545?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (60877e3) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/22871ad2da8b72becd46573ac4e2bc46a3f79407?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (22871ad) will **increase** coverage by `13.02%`.
> Report is 92 commits behind head on 4.18.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 4.18 #7545 +/- ##
===========================================
+ Coverage 0 13.02% +13.02%
- Complexity 0 9032 +9032
===========================================
Files 0 2720 +2720
Lines 0 257071 +257071
Branches 0 40089 +40089
===========================================
+ Hits 0 33475 +33475
- Misses 0 219392 +219392
- Partials 0 4204 +4204
```
[see 2720 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7545/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#discussion_r1259738380
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java:
##########
@@ -55,7 +55,7 @@ public class UpdateNetworkOfferingCmd extends BaseCmd {
private String displayText;
@Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING, description = "the availability of network offering."
- + " Default value is Required for Guest Virtual network offering; Optional for Guest Direct network offering")
+ + " Default value is Required for Guest Virtual network offering; Optional for Guest Direct network offering; Only one network offering can have the value Required ")
Review Comment:
```suggestion
+ " The default value is Required for Guest Virtual network offering, Optional for Guest Direct network offering. Only one network offering can have the value Required ")
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java:
##########
@@ -73,7 +73,8 @@ public class CreateNetworkOfferingCmd extends BaseCmd {
@Parameter(name = ApiConstants.SPECIFY_VLAN, type = CommandType.BOOLEAN, description = "true if network offering supports vlans")
private Boolean specifyVlan;
- @Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING, description = "the availability of network offering. Default value is Optional")
+ @Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING, description = "the availability of network offering. Default value is Optional"
+ + " Other value is Required, which will make it as the default network offering for new networks ")
Review Comment:
```suggestion
@Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING, description = "the availability of network offering. The default value is Optional. "
+ " Another value is Required, which will make it as the default network offering for new networks ")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#discussion_r1291130027
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java:
##########
@@ -55,7 +55,7 @@ public class UpdateNetworkOfferingCmd extends BaseCmd {
private String displayText;
@Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING, description = "the availability of network offering."
- + " Default value is Required for Guest Virtual network offering; Optional for Guest Direct network offering")
+ + " The default value is Required for Guest Virtual network offering, Optional for Guest Direct network offering. Only one network offering can have the value Required ")
Review Comment:
It was not changed in this PR but I don ´t understand `Required for Guest Virtual network offering, Optional for Guest Direct network offering`. it makes the whole thing strange and incomprehensible.
Also I don't think it will make sense to users that the default is different (as discribed) for the create vs the update API. I am not sure if we need to change the code or the doc string, but more work is needed, i think.
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java:
##########
@@ -55,7 +55,7 @@ public class UpdateNetworkOfferingCmd extends BaseCmd {
private String displayText;
@Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING, description = "the availability of network offering."
- + " Default value is Required for Guest Virtual network offering; Optional for Guest Direct network offering")
+ + " The default value is Required for Guest Virtual network offering, Optional for Guest Direct network offering. Only one network offering can have the value Required ")
Review Comment:
It was not changed in this PR but I don ´t understand `Required for Guest Virtual network offering, Optional for Guest Direct network offering`. it makes the whole thing strange and incomprehensible.
Also I don't think it will make sense to users that the default is different (as discribed) for the create vs the update API. I am not sure if we need to change the code or the doc string, but more work is needed, i think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1558863516
@andrijapanicsb a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1558871807
Packaging result [LL]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] updated the api documentation for createNetworkOffering and updateNetworkOffering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1743020756
ping @kiranchavala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#discussion_r1209167092
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java:
##########
@@ -73,7 +73,8 @@ public class CreateNetworkOfferingCmd extends BaseCmd {
@Parameter(name = ApiConstants.SPECIFY_VLAN, type = CommandType.BOOLEAN, description = "true if network offering supports vlans")
private Boolean specifyVlan;
- @Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING, description = "the availability of network offering. Default value is Optional")
+ @Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING, description = "the availability of network offering. Default value is Optional"
+ + " Other value is Required, which will make it as the default network offering for new networks ")
Review Comment:
Perhaps use a period (.) before the previous sentence ends. What if there are multiple network offeirngs where this is required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] updated the api documentation for createNetworkOffering and updateNetworkOffering [cloudstack]
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on code in PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#discussion_r1388207516
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java:
##########
@@ -55,7 +55,7 @@ public class UpdateNetworkOfferingCmd extends BaseCmd {
private String displayText;
@Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING, description = "the availability of network offering."
- + " Default value is Required for Guest Virtual network offering; Optional for Guest Direct network offering")
+ + " The default value is Required for Guest Virtual network offering, Optional for Guest Direct network offering. Only one network offering can have the value Required ")
Review Comment:
@DaanHoogland Yes suggestion is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "andrijapanicsb (via GitHub)" <gi...@apache.org>.
andrijapanicsb commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1558844127
@blueorangutan LLpackage (testing LL build jobs <----- ignore this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1558860184
@andrijapanicsb a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "andrijapanicsb (via GitHub)" <gi...@apache.org>.
andrijapanicsb commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1558860507
@blueorangutan LLpackage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1674355988
@blueorangutan test rocky8 kvm-rocky8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1691635751
moved to 4.18.2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org