You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ad...@apache.org on 2017/12/18 19:35:24 UTC

[48/50] [abbrv] james-project git commit: JAMES-2199 Avoid redundantly logging an exception's message if the exception itself is logged

JAMES-2199 Avoid redundantly logging an exception's message if the exception itself is logged


Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/24b497a1
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/24b497a1
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/24b497a1

Branch: refs/heads/master
Commit: 24b497a1ff1819412954ee2746a48d22bed75731
Parents: 1ef0926
Author: Daniel Trebbien <dt...@gmail.com>
Authored: Wed Dec 6 19:28:25 2017 -0600
Committer: Antoine Duprat <ad...@linagora.com>
Committed: Mon Dec 18 20:31:55 2017 +0100

----------------------------------------------------------------------
 .../apache/james/mailrepository/file/FileMailRepository.java    | 2 +-
 .../java/org/apache/james/user/file/UsersFileRepository.java    | 2 +-
 .../apache/james/mailrepository/jdbc/JDBCMailRepository.java    | 5 ++---
 .../org/apache/james/mailetcontainer/impl/JamesMailSpooler.java | 4 ++--
 4 files changed, 6 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/james-project/blob/24b497a1/server/data/data-file/src/main/java/org/apache/james/mailrepository/file/FileMailRepository.java
----------------------------------------------------------------------
diff --git a/server/data/data-file/src/main/java/org/apache/james/mailrepository/file/FileMailRepository.java b/server/data/data-file/src/main/java/org/apache/james/mailrepository/file/FileMailRepository.java
index a10b3ce..229e187 100644
--- a/server/data/data-file/src/main/java/org/apache/james/mailrepository/file/FileMailRepository.java
+++ b/server/data/data-file/src/main/java/org/apache/james/mailrepository/file/FileMailRepository.java
@@ -145,7 +145,7 @@ public class FileMailRepository extends AbstractMailRepository {
             }
             LOGGER.debug("{} created in {}", getClass().getName(), destination);
         } catch (Exception e) {
-            LOGGER.error("Failed to retrieve Store component:{}", e.getMessage(), e);
+            LOGGER.error("Failed to retrieve Store component", e);
             throw e;
         }
     }

http://git-wip-us.apache.org/repos/asf/james-project/blob/24b497a1/server/data/data-file/src/main/java/org/apache/james/user/file/UsersFileRepository.java
----------------------------------------------------------------------
diff --git a/server/data/data-file/src/main/java/org/apache/james/user/file/UsersFileRepository.java b/server/data/data-file/src/main/java/org/apache/james/user/file/UsersFileRepository.java
index 815b174..d4d88c9 100644
--- a/server/data/data-file/src/main/java/org/apache/james/user/file/UsersFileRepository.java
+++ b/server/data/data-file/src/main/java/org/apache/james/user/file/UsersFileRepository.java
@@ -100,7 +100,7 @@ public class UsersFileRepository extends AbstractJamesUsersRepository {
             objectRepository.init();
             LOGGER.debug("{} created in {}", getClass().getName(), destination);
         } catch (Exception e) {
-            LOGGER.error("Failed to initialize repository: {}", e.getMessage(), e);
+            LOGGER.error("Failed to initialize repository", e);
             throw e;
         }
     }

http://git-wip-us.apache.org/repos/asf/james-project/blob/24b497a1/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/JDBCMailRepository.java
----------------------------------------------------------------------
diff --git a/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/JDBCMailRepository.java b/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/JDBCMailRepository.java
index 73ebd94..db09abe 100644
--- a/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/JDBCMailRepository.java
+++ b/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/JDBCMailRepository.java
@@ -252,9 +252,8 @@ public class JDBCMailRepository extends AbstractMailRepository {
 
             LOGGER.debug("{} created according to {}", getClass().getName(), destination);
         } catch (Exception e) {
-            String message = "Failed to retrieve Store component:" + e.getMessage();
-            LOGGER.error(message, e);
-            throw new ConfigurationException(message, e);
+            LOGGER.error("Failed to retrieve Store component", e);
+            throw new ConfigurationException("Failed to retrieve Store component", e);
         }
 
         theJDBCUtil = new JDBCUtil();

http://git-wip-us.apache.org/repos/asf/james-project/blob/24b497a1/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/JamesMailSpooler.java
----------------------------------------------------------------------
diff --git a/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/JamesMailSpooler.java b/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/JamesMailSpooler.java
index 6721922..c2fc9bb 100644
--- a/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/JamesMailSpooler.java
+++ b/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/JamesMailSpooler.java
@@ -166,7 +166,7 @@ public class JamesMailSpooler implements Runnable, Disposable, Configurable, Mai
                             queueItem.done(true);
                         } catch (Exception e) {
                             if (active.get()) {
-                                LOGGER.error("Exception processing mail while spooling {}", e.getMessage(), e);
+                                LOGGER.error("Exception processing mail while spooling", e);
                             }
                             queueItem.done(false);
 
@@ -176,7 +176,7 @@ public class JamesMailSpooler implements Runnable, Disposable, Configurable, Mai
                         }
                     } catch (Throwable e) {
                         if (active.get()) {
-                            LOGGER.error("Exception processing mail while spooling {}", e.getMessage(), e);
+                            LOGGER.error("Exception processing mail while spooling", e);
 
                         }
                     } finally {


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org