You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by al...@apache.org on 2020/07/29 07:43:55 UTC
[zeppelin] branch master updated: [hotfix][dev] one more fix for
merge script
This is an automated email from the ASF dual-hosted git repository.
alexott pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/master by this push:
new 5779a37 [hotfix][dev] one more fix for merge script
5779a37 is described below
commit 5779a37cddea018afb892f5940596c9dfe9e7acd
Author: Alex Ott <al...@apache.org>
AuthorDate: Wed Jul 29 09:42:52 2020 +0200
[hotfix][dev] one more fix for merge script
in the Python 3, `filter` & `map` are returning iterables, so operations
like accessing by index are not working anymore
---
dev/merge_zeppelin_pr.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/dev/merge_zeppelin_pr.py b/dev/merge_zeppelin_pr.py
index 23b5d19..a31eb28 100755
--- a/dev/merge_zeppelin_pr.py
+++ b/dev/merge_zeppelin_pr.py
@@ -218,7 +218,7 @@ def fix_version_from_branch(branch, versions):
return versions[0]
else:
branch_ver = branch.replace("branch-", "")
- return filter(lambda x: x.name.startswith(branch_ver), versions)[-1]
+ return list(filter(lambda x: x.name.startswith(branch_ver), versions))[-1]
def resolve_jira_issue(merge_branches, comment, default_jira_id=""):
@@ -264,7 +264,7 @@ def resolve_jira_issue(merge_branches, comment, default_jira_id=""):
if patch == "0":
previous = "%s.%s.%s" % (major, int(minor) - 1, 0)
if previous in default_fix_versions:
- default_fix_versions = filter(lambda x: x != v, default_fix_versions)
+ default_fix_versions = list(filter(lambda x: x != v, default_fix_versions))
default_fix_versions = ",".join(default_fix_versions)
fix_versions = input("Enter comma-separated fix version(s) [%s]: " % default_fix_versions)
@@ -273,11 +273,11 @@ def resolve_jira_issue(merge_branches, comment, default_jira_id=""):
fix_versions = fix_versions.replace(" ", "").split(",")
def get_version_json(version_str):
- return filter(lambda v: v.name == version_str, versions)[0].raw
+ return list(filter(lambda v: v.name == version_str, versions))[0].raw
- jira_fix_versions = map(lambda v: get_version_json(v), fix_versions)
+ jira_fix_versions = list(map(lambda v: get_version_json(v), fix_versions))
- resolve = filter(lambda a: a['name'] == "Resolve Issue", asf_jira.transitions(jira_id))[0]
+ resolve = list(filter(lambda a: a['name'] == "Resolve Issue", asf_jira.transitions(jira_id)))[0]
asf_jira.transition_issue(
jira_id, resolve["id"], fixVersions=jira_fix_versions, comment=comment)