You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by "joseph-bennett-sf (via GitHub)" <gi...@apache.org> on 2024/05/31 16:45:47 UTC

[PR] ZOOKEEPER-4818 Add metric JVM_HEAP_BYTES_USED, JVM_HEAP_BYTES_MAX, and JVM_HEAP_BYTES_FREE [zookeeper]

joseph-bennett-sf opened a new pull request, #2170:
URL: https://github.com/apache/zookeeper/pull/2170

   https://issues.apache.org/jira/browse/ZOOKEEPER-4818


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ZOOKEEPER-4818 Add metric JVM_HEAP_BYTES_USED, JVM_HEAP_BYTES_MAX, and JVM_HEAP_BYTES_FREE [zookeeper]

Posted by "joseph-bennett-sf (via GitHub)" <gi...@apache.org>.
joseph-bennett-sf commented on PR #2170:
URL: https://github.com/apache/zookeeper/pull/2170#issuecomment-2173821086

   > We already had this feature?
   
   Is this only for the prometheus metrics provider? This information should ideally be available for implementations using other methods for exporting metrics. Please see [ZOOKEEPER-4818](https://issues.apache.org/jira/browse/ZOOKEEPER-4818)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ZOOKEEPER-4818 Add metric JVM_HEAP_BYTES_USED, JVM_HEAP_BYTES_MAX, and JVM_HEAP_BYTES_FREE [zookeeper]

Posted by "joseph-bennett-sf (via GitHub)" <gi...@apache.org>.
joseph-bennett-sf commented on PR #2170:
URL: https://github.com/apache/zookeeper/pull/2170#issuecomment-2218119425

   @maoling Thanks for the review. I believe this is due to the metric names conflicting with those that Prometheus exports. I have updated the names so that they do not conflict with each other.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ZOOKEEPER-4818 Add metric JVM_HEAP_BYTES_USED, JVM_HEAP_BYTES_MAX, and JVM_HEAP_BYTES_FREE [zookeeper]

Posted by "maoling (via GitHub)" <gi...@apache.org>.
maoling commented on PR #2170:
URL: https://github.com/apache/zookeeper/pull/2170#issuecomment-2173457709

   We already had this feature?
   1. enable the `metricsProvider.exportJvmInfo`
   ```
   cat conf/zoo.cfg
   ## Metrics Providers
   #
   # https://prometheus.io Metrics Exporter
   metricsProvider.className=org.apache.zookeeper.metrics.prometheus.PrometheusMetricsProvider
   metricsProvider.httpHost=0.0.0.0
   metricsProvider.httpPort=7000
   metricsProvider.exportJvmInfo=true
   ```
   
   2. curl http://localhost:7000/metrics |grep "jvm_memory_bytes_"
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org