You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "becketqin (via GitHub)" <gi...@apache.org> on 2023/02/17 15:55:37 UTC

[GitHub] [beam] becketqin commented on issue #25485: [Failing Test]: GroupByKeyTest$BasicTests$.testAfterProcessingTimeContinuationTriggerUsingState()

becketqin commented on issue #25485:
URL: https://github.com/apache/beam/issues/25485#issuecomment-1434839860

   @kennknowles Thanks for the quick reply. 
   
   I was trying to play with the delay time a little bit, and the semantic of the following code block is unclear to me.
   ```
   Repeatedly.forever(
                                 AfterProcessingTime.pastFirstElementInPane()
                                     .plusDelayOf(Duration.millis(triggerMillis))))
   ```
   
   I printed out the timestamps of each element processing, watermark processing and emission. From what I see the `plusDelayOf()` was only honored for the first firing of the trigger. The rest of the firings seem got triggered immediately upon records arrival without any delay. Is that expected?
   
   If we want to make 5.e happen before 5.d, I think we need to increase `triggerMillis`. But if that only works for the first firing, it won't help either.
   
   I will temporarily exclude this test from the Flink runner's validation test. The processing timing triggered behavior is indeed tricky to test. Some kind of manually triggered executors might be helpful. Flink heavily relies on that for processing time related tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org