You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/24 18:30:40 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29533: [SPARK-24266][K8S][3.0] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on a change in pull request #29533:
URL: https://github.com/apache/spark/pull/29533#discussion_r494527451



##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -21,9 +21,11 @@ import java.util.{Collections, UUID}
 import java.util.Properties
 
 import io.fabric8.kubernetes.api.model._
-import io.fabric8.kubernetes.client.KubernetesClient
+import io.fabric8.kubernetes.client.{KubernetesClient, Watch}
+import io.fabric8.kubernetes.client.Watcher.Action
 import scala.collection.mutable
 import scala.util.control.NonFatal
+import util.control.Breaks._

Review comment:
       @jkleckner Apache Spark community always use absolute path. Please fix this.
   > Always import packages using absolute paths (e.g. scala.util.Random) instead of relative ones (e.g. util.Random).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org