You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by cm...@apache.org on 2012/09/14 21:50:46 UTC
svn commit: r1384899 -
/subversion/branches/inheritable-props/subversion/libsvn_ra/compat.c
Author: cmpilato
Date: Fri Sep 14 19:50:45 2012
New Revision: 1384899
URL: http://svn.apache.org/viewvc?rev=1384899&view=rev
Log:
On the 'inheritable-props' branch: Fix the fallback logic for
svn_ra_get_inherited_props() to also ignore SVN_ERR_RA_DAV_FORBIDDEN
errors. (Why, again, do we have to have two different error code to
mean, "No, you can't see that"?)
This fixes 'auth_tests.py 16' and 'iprop_authz_tests.py 1' when run
against a trunk (non-iprop-capable) server.
* subversion/libsvn_ra/compat.c
(svn_ra__get_inherited_props_walk): Also ignore SVN_ERR_RA_DAV_FORBIDDEN.
Modified:
subversion/branches/inheritable-props/subversion/libsvn_ra/compat.c
Modified: subversion/branches/inheritable-props/subversion/libsvn_ra/compat.c
URL: http://svn.apache.org/viewvc/subversion/branches/inheritable-props/subversion/libsvn_ra/compat.c?rev=1384899&r1=1384898&r2=1384899&view=diff
==============================================================================
--- subversion/branches/inheritable-props/subversion/libsvn_ra/compat.c (original)
+++ subversion/branches/inheritable-props/subversion/libsvn_ra/compat.c Fri Sep 14 19:50:45 2012
@@ -914,7 +914,8 @@ svn_ra__get_inherited_props_walk(svn_ra_
skip, but allow them to inherit from further up. */
if (err)
{
- if (err->apr_err == SVN_ERR_RA_NOT_AUTHORIZED)
+ if ((err->apr_err == SVN_ERR_RA_NOT_AUTHORIZED)
+ || (err->apr_err == SVN_ERR_RA_DAV_FORBIDDEN))
{
svn_error_clear(err);
continue;
Re: svn commit: r1384899 -
/subversion/branches/inheritable-props/subversion/libsvn_ra/compat.c
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
cmpilato@apache.org wrote on Fri, Sep 14, 2012 at 19:50:46 -0000:
> Author: cmpilato
> Date: Fri Sep 14 19:50:45 2012
> New Revision: 1384899
>
> URL: http://svn.apache.org/viewvc?rev=1384899&view=rev
> Log:
> On the 'inheritable-props' branch: Fix the fallback logic for
> svn_ra_get_inherited_props() to also ignore SVN_ERR_RA_DAV_FORBIDDEN
> errors. (Why, again, do we have to have two different error code to
> mean, "No, you can't see that"?)
>
Don't know, but it sounds like a sibling to SVN_ERR_IS_LOCK_ERROR() is
in order.
> + if ((err->apr_err == SVN_ERR_RA_NOT_AUTHORIZED)
> + || (err->apr_err == SVN_ERR_RA_DAV_FORBIDDEN))
Re: svn commit: r1384899 -
/subversion/branches/inheritable-props/subversion/libsvn_ra/compat.c
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
cmpilato@apache.org wrote on Fri, Sep 14, 2012 at 19:50:46 -0000:
> Author: cmpilato
> Date: Fri Sep 14 19:50:45 2012
> New Revision: 1384899
>
> URL: http://svn.apache.org/viewvc?rev=1384899&view=rev
> Log:
> On the 'inheritable-props' branch: Fix the fallback logic for
> svn_ra_get_inherited_props() to also ignore SVN_ERR_RA_DAV_FORBIDDEN
> errors. (Why, again, do we have to have two different error code to
> mean, "No, you can't see that"?)
>
Don't know, but it sounds like a sibling to SVN_ERR_IS_LOCK_ERROR() is
in order.
> + if ((err->apr_err == SVN_ERR_RA_NOT_AUTHORIZED)
> + || (err->apr_err == SVN_ERR_RA_DAV_FORBIDDEN))