You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/04 12:06:51 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #28727: [SPARK-31879][SQL][test-java11] Preset monday start(iso) for the first day of week by reflection

cloud-fan commented on a change in pull request #28727:
URL: https://github.com/apache/spark/pull/28727#discussion_r435202365



##########
File path: docs/sql-ref-datetime-pattern.md
##########
@@ -63,7 +63,10 @@ Spark uses pattern letters in the following table for date and timestamp parsing
 
 The count of pattern letters determines the format.
 
-- Text: The text style is determined based on the number of pattern letters used. Less than 4 pattern letters will use the short form. Exactly 4 pattern letters will use the full form. Exactly 5 pattern letters will use the narrow form. 5 or more letters will fail.
+- Text: The text style is determined based on the number of pattern letters used. Less than 4 pattern letters will use the short form. Exactly 4 pattern letters will use the full form. Exactly 5 pattern letters will use the narrow form. 5 or more letters will fail. More details for the text style:

Review comment:
       How about
   ```
   ... will use the short form (typically an abbreviation, for example, day-of-week Monday might output "Mon"). ...
   ```
   
   BTW we should remove `Exactly 5 pattern letters will use the narrow form`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org