You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Stefano Bagnara (JIRA)" <se...@james.apache.org> on 2008/07/13 22:14:31 UTC
[jira] Created: (MIME4J-50) InputBuffer to extend FilterInputStream
InputBuffer to extend FilterInputStream
---------------------------------------
Key: MIME4J-50
URL: https://issues.apache.org/jira/browse/MIME4J-50
Project: Mime4j
Issue Type: Improvement
Affects Versions: 0.3
Reporter: Stefano Bagnara
Fix For: 0.4
I create this issue to attach a patch (not sure our mailing list support this).
I was looking at InputBuffer and I noticed how much it looks like a FilterInputStream class but it doesn't expose the InputStream "interface" (ok, it is not an interface, but an abstract class).
Am I missing something or extending InputStreamFilter does not add complexity to the class while increasing its flexibility/reusability?
I gave this a go by making BufferingInputStream an extension of FilterInputStream and by letting InputBuffer extending the "new" BufferingInputStream.
This also gave me the opportunity to simplify some code aroud avoiding multiple wrapping of the InputBuffer.
After this patch all of the tests still pass.
I did not rename "InputBuffer" with this patch, but maybe it should include Buffered, InputStream and Filter words to better autodocumentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Resolved: (MIME4J-50) InputBuffer to extend
FilterInputStream
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefano Bagnara resolved MIME4J-50.
-----------------------------------
Resolution: Fixed
Branch has been merged.
> InputBuffer to extend FilterInputStream
> ---------------------------------------
>
> Key: MIME4J-50
> URL: https://issues.apache.org/jira/browse/MIME4J-50
> Project: Mime4j
> Issue Type: Improvement
> Affects Versions: 0.3
> Reporter: Stefano Bagnara
> Assignee: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: MIME4J-50.patch
>
>
> I create this issue to attach a patch (not sure our mailing list support this).
> I was looking at InputBuffer and I noticed how much it looks like a FilterInputStream class but it doesn't expose the InputStream "interface" (ok, it is not an interface, but an abstract class).
> Am I missing something or extending InputStreamFilter does not add complexity to the class while increasing its flexibility/reusability?
> I gave this a go by making BufferingInputStream an extension of FilterInputStream and by letting InputBuffer extending the "new" BufferingInputStream.
> This also gave me the opportunity to simplify some code aroud avoiding multiple wrapping of the InputBuffer.
> After this patch all of the tests still pass.
> I did not rename "InputBuffer" with this patch, but maybe it should include Buffered, InputStream and Filter words to better autodocumentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-50) InputBuffer to extend
FilterInputStream
Posted by "Oleg Kalnichevski (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613217#action_12613217 ]
Oleg Kalnichevski commented on MIME4J-50:
-----------------------------------------
Works for me.
Oleg
> InputBuffer to extend FilterInputStream
> ---------------------------------------
>
> Key: MIME4J-50
> URL: https://issues.apache.org/jira/browse/MIME4J-50
> Project: Mime4j
> Issue Type: Improvement
> Affects Versions: 0.3
> Reporter: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: MIME4J-50.patch
>
>
> I create this issue to attach a patch (not sure our mailing list support this).
> I was looking at InputBuffer and I noticed how much it looks like a FilterInputStream class but it doesn't expose the InputStream "interface" (ok, it is not an interface, but an abstract class).
> Am I missing something or extending InputStreamFilter does not add complexity to the class while increasing its flexibility/reusability?
> I gave this a go by making BufferingInputStream an extension of FilterInputStream and by letting InputBuffer extending the "new" BufferingInputStream.
> This also gave me the opportunity to simplify some code aroud avoiding multiple wrapping of the InputBuffer.
> After this patch all of the tests still pass.
> I did not rename "InputBuffer" with this patch, but maybe it should include Buffered, InputStream and Filter words to better autodocumentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (MIME4J-50) InputBuffer to extend FilterInputStream
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefano Bagnara updated MIME4J-50:
----------------------------------
Attachment: MIME4J-50.patch
Forgot to say that this change allowed me to remove BasicBufferingInputStream by moving few methods to InputBuffer and passing around InputBuffer instead of BasicBufferingInputStream.
> InputBuffer to extend FilterInputStream
> ---------------------------------------
>
> Key: MIME4J-50
> URL: https://issues.apache.org/jira/browse/MIME4J-50
> Project: Mime4j
> Issue Type: Improvement
> Affects Versions: 0.3
> Reporter: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: MIME4J-50.patch
>
>
> I create this issue to attach a patch (not sure our mailing list support this).
> I was looking at InputBuffer and I noticed how much it looks like a FilterInputStream class but it doesn't expose the InputStream "interface" (ok, it is not an interface, but an abstract class).
> Am I missing something or extending InputStreamFilter does not add complexity to the class while increasing its flexibility/reusability?
> I gave this a go by making BufferingInputStream an extension of FilterInputStream and by letting InputBuffer extending the "new" BufferingInputStream.
> This also gave me the opportunity to simplify some code aroud avoiding multiple wrapping of the InputBuffer.
> After this patch all of the tests still pass.
> I did not rename "InputBuffer" with this patch, but maybe it should include Buffered, InputStream and Filter words to better autodocumentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Assigned: (MIME4J-50) InputBuffer to extend
FilterInputStream
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefano Bagnara reassigned MIME4J-50:
-------------------------------------
Assignee: Stefano Bagnara
> InputBuffer to extend FilterInputStream
> ---------------------------------------
>
> Key: MIME4J-50
> URL: https://issues.apache.org/jira/browse/MIME4J-50
> Project: Mime4j
> Issue Type: Improvement
> Affects Versions: 0.3
> Reporter: Stefano Bagnara
> Assignee: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: MIME4J-50.patch
>
>
> I create this issue to attach a patch (not sure our mailing list support this).
> I was looking at InputBuffer and I noticed how much it looks like a FilterInputStream class but it doesn't expose the InputStream "interface" (ok, it is not an interface, but an abstract class).
> Am I missing something or extending InputStreamFilter does not add complexity to the class while increasing its flexibility/reusability?
> I gave this a go by making BufferingInputStream an extension of FilterInputStream and by letting InputBuffer extending the "new" BufferingInputStream.
> This also gave me the opportunity to simplify some code aroud avoiding multiple wrapping of the InputBuffer.
> After this patch all of the tests still pass.
> I did not rename "InputBuffer" with this patch, but maybe it should include Buffered, InputStream and Filter words to better autodocumentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org