You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "hantangwangd (via GitHub)" <gi...@apache.org> on 2024/07/22 10:21:22 UTC
[PR] Api, Core: Set upper boundary for the type parameter of `Scan` [iceberg]
hantangwangd opened a new pull request, #10743:
URL: https://github.com/apache/iceberg/pull/10743
The comment of interface `Scan` instructs that it's refined methods, like `select(Collection)` and `filter(Expression)` will return new `Scan` instances. That is, they should always return `Scan` or child classes of `Scan`, and support the method chaining usage as follows:
```
Scan oldScan = ...;
Scan newScan = oldScan.select("col1", "col2")
.filter(expression)
.project(schema);
```
However, at the level of declaration, we do not enforce the above restricts. So that someone can declare a new incremental scan class in his own project as follows:
```
public class NewDefinedIncrementalScan
implements IncrementalScan<Object, FileScanTask, CombinedScanTask>
{
......
}
```
It would violate the instructions in the comment of `Scan` and break the method chain, but is legal during the compilation phase. That may lead in some confusions, as its a little difficult to distinguish whether it's intentionally to allow this.
This PR set the upper boundary of type parameter for `Scan` and it's child classes. It will explicitly disallow the issues described above and report the problem during compilation phase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Api, Core: Set upper boundary for the type parameter of `Scan` [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #10743: Api, Core: Set upper boundary for the type parameter of `Scan`
URL: https://github.com/apache/iceberg/pull/10743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Api, Core: Set upper boundary for the type parameter of `Scan` [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10743:
URL: https://github.com/apache/iceberg/pull/10743#issuecomment-2480862595
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Api, Core: Set upper boundary for the type parameter of `Scan` [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10743:
URL: https://github.com/apache/iceberg/pull/10743#issuecomment-2466519731
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org