You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2024/04/18 11:22:45 UTC

[PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

cstamas opened a new pull request, #933:
URL: https://github.com/apache/maven-mvnd/pull/933

   Port Maven 3.9.7 config and new properties (session.root/top) into Daemon m39.
   
   The IT got this property as it triggers exception (failure) if mvn39 could not "discover" top directory.
   
   Fixes #910


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

Posted by "wendigo (via GitHub)" <gi...@apache.org>.
wendigo commented on PR #933:
URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2067648142

   Adding `-Dmodernizer.violationsFile=${session.rootDirectory}/.mvn/modernizer/violations.xml` to the `.mvn/maven.config` ends with the exception: 
   ```
   [ERROR] Failed to execute goal org.gaul:modernizer-maven-plugin:2.7.0:modernizer (modernizer) on project trino-root: Error opening violation file: ${session.rootDirectory}/.mvn/modernizer/violations.xml: ${session.rootDirectory}/.mvn/modernizer/violations.xml (No such file or directory) -> [Help 1]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #933:
URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2063634024

   @wendigo ping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

Posted by "wendigo (via GitHub)" <gi...@apache.org>.
wendigo commented on PR #933:
URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2067647836

   @cstamas unfortunately still doesn't work for our case. I've tried reapplying: https://github.com/trinodb/trino/commit/ff1cddbd31d70610952922b19c13bd957e33f00f and that works in mvn but not in mvnd


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #933:
URL: https://github.com/apache/maven-mvnd/pull/933


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #933:
URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2067628217

   @wendigo Would be grateful if you build mvnd locally and try it with Trino build, it should now work OOTB. No need for native and all that, just `mvn clean install` and use it on Trino build. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

Posted by "wendigo (via GitHub)" <gi...@apache.org>.
wendigo commented on PR #933:
URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2067628962

   Will do @cstamas 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org