You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/17 15:26:19 UTC

[GitHub] [flink] godfreyhe commented on issue #10005: [FLINK-14533][flink-table-planner] Fix LOWER/UPPER not being pushed down to TableSource

godfreyhe commented on issue #10005: [FLINK-14533][flink-table-planner] Fix LOWER/UPPER not being pushed down to TableSource
URL: https://github.com/apache/flink/pull/10005#issuecomment-587044898
 
 
   sorry for the late reply. 
   the changes looks good to me. I have a minor question: It's better to add some comment like "Only upper and lower function is supported" or we can add a constructor argument like ` filterableFunctions: Set[(String, Function)] = Set()` to make `TestingFilterableTableSource` more generic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services