[GitHub] [hudi] danny0405 commented on a diff in pull request #5545: [HUDI-4078][HUDI-FLINK]BootstrapOperator contains the pending compact…

[GitBox <gi...@apache.org>]

danny0405 commented on code in PR #5545:
URL: https://github.com/apache/hudi/pull/5545#discussion_r868778594


##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -644,14 +644,17 @@ public final Stream<FileSlice> getLatestUnCompactedFileSlices(String partitionSt
 
   @Override
   public final Stream<FileSlice> getLatestFileSlicesBeforeOrOn(String partitionStr, String maxCommitTime,
-      boolean includeFileSlicesInPendingCompaction) {
+      boolean includeFileSlicesInPendingCompaction, boolean includeFilesInPendingCompaction) {
     try {
       readLock.lock();
       String partitionPath = formatPartitionKey(partitionStr);
       ensurePartitionLoadedCorrectly(partitionPath);
       Stream<FileSlice> fileSliceStream = fetchLatestFileSlicesBeforeOrOn(partitionPath, maxCommitTime)
           .filter(slice -> !isFileGroupReplacedBeforeOrOn(slice.getFileGroupId(), maxCommitTime));
       if (includeFileSlicesInPendingCompaction) {
+        if (includeFilesInPendingCompaction) {
+          return fileSliceStream.map(this::addBootstrapBaseFileIfPresent);

Review Comment:
   Can you explain a little more the details ? BTW, we should not modify the interfaces of fs view in most of the cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org