You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "linghengqian (via GitHub)" <gi...@apache.org> on 2024/10/23 12:00:58 UTC
[PR] Add the release process of ShardingSphere Agent's Docker Image to the release guide [shardingsphere]
linghengqian opened a new pull request, #33377:
URL: https://github.com/apache/shardingsphere/pull/33377
Fixes #33350 .
Changes proposed in this pull request:
- Add the release process of ShardingSphere Agent's Docker Image to the release guide.
- Neither Github Packages nor Docker Hub are actually official distribution channels for ASF, so I thought publishing only to Github Packages would simplify the communication process with ASF Infra.
- Publishing to Github Packages also avoids issues like #33263. Even ASF is limited by Docker Hub's rate limiting policy, which is not conducive to unit testing.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [x] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add the release process of ShardingSphere Agent's Docker Image to the release guide [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #33377:
URL: https://github.com/apache/shardingsphere/pull/33377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add the release process of ShardingSphere Agent's Docker Image to the release guide [shardingsphere]
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian commented on code in PR #33377:
URL: https://github.com/apache/shardingsphere/pull/33377#discussion_r1812596694
##########
docs/community/content/involved/release/shardingsphere.en.md:
##########
@@ -584,6 +584,28 @@ Go to [Docker Hub](https://hub.docker.com/r/apache/shardingsphere-proxy/) and ch
docker logout
```
+3.5 Log in to GitHub Packages Container Registry
+
+```shell
+docker login ghcr.io/apache/shardingsphere
+```
+
+3.6 Build and push ShardingSphere Agent Docker image
+
+```shell
+cd ~/shardingsphere
+git checkout ${RELEASE.VERSION}
+./mvnw -am -pl distribution/agent -Prelease,docker.buildx.push -T 1C -DskipTests clean package
+```
+
+3.7 Confirm the successful release
+
+Check [GitHub Packages](https://github.com/apache/shardingsphere/pkgs/container/shardingsphere-agent) for released images, and make sure that the image supports both `linux/amd64` and `linux/arm64`.
+
+```shell
+docker logout
+```
+
Review Comment:
- CC @taojintianxia . Is this enough to resolve the original issue #33350 ? I'm not sure every release manager's github account has the rights to execute `docker login ghcr.io/apache/shardingsphere`. But asking ASF Infra to assist in registering a github account doesn't seem realistic.
> The problem is that the `personal access token (classic)` I generated from https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry does not have permission to manipulate the ASF namespace. And I'm not sure who has this authority, all PMCs? Some ASF members?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org