You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/09/23 10:26:47 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #7630: Minor: remove unecessary `Arc`s in datetime_expressions
alamb opened a new pull request, #7630:
URL: https://github.com/apache/arrow-datafusion/pull/7630
Draft as it builds on https://github.com/apache/arrow-datafusion/pull/7614
## Which issue does this PR close?
Follow on to https://github.com/apache/arrow-datafusion/pull/7614
## Rationale for this change
I noticed this cleanup while reviewing https://github.com/apache/arrow-datafusion/pull/7614
## What changes are included in this PR?
Remove an Arc which is not necessary: https://github.com/apache/arrow-datafusion/pull/7614#discussion_r1334959880
## Are these changes tested?
existing tests
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] viirya commented on pull request #7630: Minor: remove unecessary `Arc`s in datetime_expressions
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #7630:
URL: https://github.com/apache/arrow-datafusion/pull/7630#issuecomment-1732906119
Thank you @alamb @wiedld
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] viirya merged pull request #7630: Minor: remove unecessary `Arc`s in datetime_expressions
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya merged PR #7630:
URL: https://github.com/apache/arrow-datafusion/pull/7630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #7630: Minor: remove unecessary `Arc`s in datetime_expressions
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7630:
URL: https://github.com/apache/arrow-datafusion/pull/7630#issuecomment-1732543597
cc @wiedld
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org