You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/09 13:14:15 UTC
[GitHub] [netbeans] entlicher opened a new pull request #2436: Improved stability of Truffle debugger and implemented step from scripts to Java.
entlicher opened a new pull request #2436:
URL: https://github.com/apache/netbeans/pull/2436
- Stability of Truffle debugger is improved, especially the initialization when a polyglot `Engine` class is detected.
- Stepping from Truffle scripts into Java code is implemented. This is important when e.g. JavaScript calls into java.
- JPDAStep API is enhanced with filters, this is necessary for user-friendly step from scripts into Java.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2436: Improved stability of Truffle debugger and implemented step from scripts to Java.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2436:
URL: https://github.com/apache/netbeans/pull/2436#discussion_r502514617
##########
File path: java/debugger.jpda.truffle/src/org/netbeans/modules/debugger/jpda/truffle/actions/PauseInGraalScriptActionProvider.java
##########
@@ -176,11 +171,23 @@ public static Action createAction(Map<String,?> params) {
java.lang.reflect.Method createActionMethod = debuggerActionClass.getDeclaredMethod("createAction", Map.class);
Action action = (Action) createActionMethod.invoke(null, params);
action.putValue(Actions.ACTION_VALUE_TOGGLE, Boolean.TRUE);
- action.putValue(Action.SELECTED_KEY, actionState);
+ action.putValue(Action.SELECTED_KEY, false);
actionReference = new WeakReference<>(action);
return action;
} catch (Exception ex) {
throw new RuntimeException(ex);
}
}
+
+ private static void updateActionState(boolean active, boolean suspendState) {
+ if (GraphicsEnvironment.isHeadless()) {
Review comment:
Updating the state only when the action is visible is good idea.
##########
File path: java/api.debugger.jpda/src/org/netbeans/api/debugger/jpda/JPDADebugger.java
##########
@@ -614,7 +614,15 @@ public Variable createMirrorVar(Object obj, boolean isPrimitive) throws InvalidO
public ThreadsCollector getThreadsCollector() {
return null;
}
-
+
+ /**
+ * Get the session associated with this debugger.
+ * @since 3.19
+ */
+ public Session getSession() {
Review comment:
Fine evolution given there is just a single implementation of this type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher merged pull request #2436: Improved stability of Truffle debugger and implemented step from scripts to Java.
Posted by GitBox <gi...@apache.org>.
entlicher merged pull request #2436:
URL: https://github.com/apache/netbeans/pull/2436
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists