You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "1Jack2 (via GitHub)" <gi...@apache.org> on 2023/08/07 16:46:54 UTC
[GitHub] [pulsar] 1Jack2 opened a new pull request, #20949: [fix][broker] Fix http error message of Bookie rack placement config API when bookie-rack is not configured.
1Jack2 opened a new pull request, #20949:
URL: https://github.com/apache/pulsar/pull/20949
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes an issue, -->
Fixes #20871
<!-- Details of when a PIP is required and how the PIP process work, please see: https://github.com/apache/pulsar/blob/master/pip/README.md -->
### Motivation
<!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
Fix http error message of Bookie rack placement config API when bookie-rack is not configured.
### Modifications
<!-- Describe the modifications you've done. -->
Fix http error message of Bookie rack placement config API when bookie-rack is not configured.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/1Jack2/pulsar/pull/4
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #20949: [fix][broker] Fix http error message of Bookie rack placement config API when bookie-rack is not configured.
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- closed pull request #20949: [fix][broker] Fix http error message of Bookie rack placement config API when bookie-rack is not configured.
URL: https://github.com/apache/pulsar/pull/20949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #20949: [fix][broker] Fix http error message of Bookie rack placement config API when bookie-rack is not configured.
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #20949:
URL: https://github.com/apache/pulsar/pull/20949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #20949: [fix][broker] Fix http error message of Bookie rack placement config API when bookie-rack is not configured.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20949:
URL: https://github.com/apache/pulsar/pull/20949#issuecomment-1676617525
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20949?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#20949](https://app.codecov.io/gh/apache/pulsar/pull/20949?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (54bd27b) into [master](https://app.codecov.io/gh/apache/pulsar/commit/2ab184e49a036a1dd10dc537bef4ab034a5ad5e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2ab184e) will **decrease** coverage by `0.22%`.
> Report is 6 commits behind head on master.
> The diff coverage is `n/a`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20949?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #20949 +/- ##
============================================
- Coverage 37.11% 36.90% -0.22%
+ Complexity 12250 12227 -23
============================================
Files 1698 1698
Lines 129813 130470 +657
Branches 14156 14233 +77
============================================
- Hits 48179 48144 -35
- Misses 75318 75991 +673
- Partials 6316 6335 +19
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.17% <ø> (-0.22%)` | :arrow_down: |
| systests | `25.20% <ø> (-0.21%)` | :arrow_down: |
| unittests | `32.07% <ø> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/pulsar/pull/20949?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/pulsar/broker/admin/v2/Bookies.java](https://app.codecov.io/gh/apache/pulsar/pull/20949?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92Mi9Cb29raWVzLmphdmE=) | `40.84% <ø> (ø)` | |
... and [63 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20949/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org