You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/05/04 17:11:24 UTC
Review Request 46985: GEODE-1347: do not echo back password and clear
history file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46985/
-----------------------------------------------------------
Review request for geode, Jens Deppe and Kirk Lund.
Repository: geode
Description
-------
GEODE-1347: do not echo back password and clear history file
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/Launcher.java fe806f67957f3ded83102917f69739bade24a70f
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java 0af040a48bcd53beaecbda4591bc439ee4ed63c5
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/Gfsh.java e5bcf06345ead2927719ad3b46c2feadd590f4f0
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshConfig.java 9ee0284496ffff48efdad4aee02d5aa4038373b3
Diff: https://reviews.apache.org/r/46985/diff/
Testing
-------
manual test
Thanks,
Jinmei Liao
Re: Review Request 46985: GEODE-1347: do not echo back password and
clear history file
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46985/#review131737
-----------------------------------------------------------
Can you also add a test to the existing history tests for this please?
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/Launcher.java (line 226)
<https://reviews.apache.org/r/46985/#comment195771>
Let's change GfshHistory.toHistoryLoggable to something more descriptive like GfshHistory.redacted.
- Jens Deppe
On May 4, 2016, 5:11 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46985/
> -----------------------------------------------------------
>
> (Updated May 4, 2016, 5:11 p.m.)
>
>
> Review request for geode, Jens Deppe and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1347: do not echo back password and clear history file
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/Launcher.java fe806f67957f3ded83102917f69739bade24a70f
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java 0af040a48bcd53beaecbda4591bc439ee4ed63c5
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/Gfsh.java e5bcf06345ead2927719ad3b46c2feadd590f4f0
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshConfig.java 9ee0284496ffff48efdad4aee02d5aa4038373b3
>
> Diff: https://reviews.apache.org/r/46985/diff/
>
>
> Testing
> -------
>
> manual test
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 46985: GEODE-1347: do not echo back password and
clear history file
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46985/#review131753
-----------------------------------------------------------
Ship it!
Ship It!
- Jens Deppe
On May 4, 2016, 9:27 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46985/
> -----------------------------------------------------------
>
> (Updated May 4, 2016, 9:27 p.m.)
>
>
> Review request for geode, Jens Deppe and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1347: do not echo back password and clear history file
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/Launcher.java fe806f67957f3ded83102917f69739bade24a70f
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java 0af040a48bcd53beaecbda4591bc439ee4ed63c5
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/Gfsh.java e5bcf06345ead2927719ad3b46c2feadd590f4f0
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshConfig.java 9ee0284496ffff48efdad4aee02d5aa4038373b3
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/jline/GfshHistory.java 7bfc9375a0b31ea73fe972b28ef6282d566a690b
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshHistoryJUnitTest.java 3ad9ce863145c6b3b064e964a82d80ce72c7e1a7
>
> Diff: https://reviews.apache.org/r/46985/diff/
>
>
> Testing
> -------
>
> manual test
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 46985: GEODE-1347: do not echo back password and
clear history file
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46985/#review133151
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On May 4, 2016, 9:27 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46985/
> -----------------------------------------------------------
>
> (Updated May 4, 2016, 9:27 p.m.)
>
>
> Review request for geode, Jens Deppe and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1347: do not echo back password and clear history file
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/Launcher.java fe806f67957f3ded83102917f69739bade24a70f
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java 0af040a48bcd53beaecbda4591bc439ee4ed63c5
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/Gfsh.java e5bcf06345ead2927719ad3b46c2feadd590f4f0
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshConfig.java 9ee0284496ffff48efdad4aee02d5aa4038373b3
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/jline/GfshHistory.java 7bfc9375a0b31ea73fe972b28ef6282d566a690b
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshHistoryJUnitTest.java 3ad9ce863145c6b3b064e964a82d80ce72c7e1a7
>
> Diff: https://reviews.apache.org/r/46985/diff/
>
>
> Testing
> -------
>
> manual test
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 46985: GEODE-1347: do not echo back password and
clear history file
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46985/
-----------------------------------------------------------
(Updated May 4, 2016, 9:27 p.m.)
Review request for geode, Jens Deppe and Kirk Lund.
Changes
-------
incorporate review changes
Repository: geode
Description
-------
GEODE-1347: do not echo back password and clear history file
Diffs (updated)
-----
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/Launcher.java fe806f67957f3ded83102917f69739bade24a70f
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java 0af040a48bcd53beaecbda4591bc439ee4ed63c5
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/Gfsh.java e5bcf06345ead2927719ad3b46c2feadd590f4f0
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshConfig.java 9ee0284496ffff48efdad4aee02d5aa4038373b3
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/jline/GfshHistory.java 7bfc9375a0b31ea73fe972b28ef6282d566a690b
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshHistoryJUnitTest.java 3ad9ce863145c6b3b064e964a82d80ce72c7e1a7
Diff: https://reviews.apache.org/r/46985/diff/
Testing
-------
manual test
Thanks,
Jinmei Liao