You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zanmato1984 (via GitHub)" <gi...@apache.org> on 2024/02/07 15:47:36 UTC
[PR] GH-39973: [C++] [CI] Disable debug memory pool for ASAN and Valgrind [arrow]
zanmato1984 opened a new pull request, #39975:
URL: https://github.com/apache/arrow/pull/39975
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Disable debug memory pool for ASAN and Valgrind so that they can detect more subtle memory issues regarding to buffer tail bytes.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
1. Add a `none` option to debug memory pool env var to make other things slightly easier.
2. Change `*_test.sh` scripts to conditionally set debug memory pool env var.
3. Top-level docker compose change to pass none to debug memory pool env var for ASAN and Valgrind.
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
The CI should cover it well.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
4. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
No.
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++][CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1933290694
The legacy ASAN failure will be gone once #39994 goes in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++] [CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1932393440
@github-actions crossbow submit -g test-conda-cpp-valgrind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++] [CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1932333575
cc @pitrou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++][CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #39975:
URL: https://github.com/apache/arrow/pull/39975#discussion_r1482358927
##########
docker-compose.yml:
##########
@@ -613,6 +615,8 @@ services:
# 1 GB isn't enough for a single sanitizer build
CCACHE_MAXSIZE: 2G
Protobuf_SOURCE: "AUTO"
+ # GH-39973: Do not use debug memory pool for ASAN
+ ARROW_DEBUG_MEMORY_POOL: "none"
Review Comment:
Thank you. Addressed.
##########
docker-compose.yml:
##########
@@ -330,6 +330,8 @@ services:
ARROW_USE_LD_GOLD: "ON"
BUILD_WARNING_LEVEL: "PRODUCTION"
ARROW_CTEST_TIMEOUT: 500
+ # GH-39973: Do not use debug memory pool for valgrind
+ ARROW_DEBUG_MEMORY_POOL: "none"
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++] [CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1932396114
```
Unable to match any tasks for `conda-cpp-valgrind`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7817809005
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++] [CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1932393138
@github-actions crossbow submit conda-cpp-valgrind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++] [CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1932387605
@github-actions crossbow submit conda-cpp-valgrind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++][CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1934452062
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++][CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #39975:
URL: https://github.com/apache/arrow/pull/39975#discussion_r1482279540
##########
docker-compose.yml:
##########
@@ -330,6 +330,8 @@ services:
ARROW_USE_LD_GOLD: "ON"
BUILD_WARNING_LEVEL: "PRODUCTION"
ARROW_CTEST_TIMEOUT: 500
+ # GH-39973: Do not use debug memory pool for valgrind
+ ARROW_DEBUG_MEMORY_POOL: "none"
Review Comment:
Could you keep this list in alphabetical order?
##########
docker-compose.yml:
##########
@@ -613,6 +615,8 @@ services:
# 1 GB isn't enough for a single sanitizer build
CCACHE_MAXSIZE: 2G
Protobuf_SOURCE: "AUTO"
+ # GH-39973: Do not use debug memory pool for ASAN
+ ARROW_DEBUG_MEMORY_POOL: "none"
Review Comment:
Could you keep this list in alphabetical order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++][CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #39975:
URL: https://github.com/apache/arrow/pull/39975#discussion_r1482665254
##########
cpp/src/arrow/memory_pool.cc:
##########
@@ -195,7 +195,7 @@ bool IsDebugEnabled() {
return false;
}
auto env_value = *std::move(maybe_env_value);
- if (env_value.empty()) {
+ if (env_value.empty() || env_value == "none") {
Review Comment:
Sure, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++] [CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1932404797
Revision: 24688a4c1e133d78e2817591486c96fe1f344269
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2b5f133df9](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2b5f133df9)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7817867734/job/21326775762)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/7817867819/job/21326775975)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7817867598/job/21326774543)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/21326778549)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7817867712/job/21326775585)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7817867694/job/21326775681)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/7817867610/job/21326774775)|
|test-fedora-38-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7817867924/job/21326776308)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7817867928/job/21326776309)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/7817867567/job/21326774555)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/7817867660/job/21326775345)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/7817867580/job/21326774975)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7817867582/job/21326774545)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/7817867547/job/21326774550)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/7817867810/job/21326775743)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++] [CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1932368837
If things go well, we should be seeing the ASAN failure as described in #39976 somewhere in CI job. This is expected as we are strengthening the ASAN check so hidden legacy failures are exposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++] [CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1932399588
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++] [CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1932400670
I've cleaned up the failed Crossbow requests :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++][CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1934451369
I've rebased, hopefully CI wil be green now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++] [CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1932389079
```
Only contributors can submit requests to this bot. Please ask someone from the community for help with getting the first commit in.
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7817773478
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++][CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #39975:
URL: https://github.com/apache/arrow/pull/39975#discussion_r1482661318
##########
cpp/src/arrow/memory_pool.cc:
##########
@@ -195,7 +195,7 @@ bool IsDebugEnabled() {
return false;
}
auto env_value = *std::move(maybe_env_value);
- if (env_value.empty()) {
+ if (env_value.empty() || env_value == "none") {
Review Comment:
Can you add a test for this somewhere in https://github.com/apache/arrow/blob/main/python/pyarrow/tests/test_memory.py#L246?
Also, this value could be documented in https://github.com/apache/arrow/blob/main/docs/source/cpp/env_vars.rst
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++][CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1935010336
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a946214b127ff50ea0cf7e68946c186fa66009a2.
There were 4 benchmark results indicating a performance regression:
- Commit Run on `ec2-m5-4xlarge-us-east-2` at [2024-02-08 18:55:06Z](https://conbench.ursa.dev/compare/runs/24b63b20ddfb4948bdb6303e490710b3...ec6d8b05fd9c42a59e332eb80f07b8ad/)
- [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-01, scale_factor=10](https://conbench.ursa.dev/compare/benchmarks/065c4ffa126d7c238000949dd0e92a54...065c5249a141711880008fef981282a0)
- [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-03, scale_factor=10](https://conbench.ursa.dev/compare/benchmarks/065c5019baa279518000c5cb075e5357...065c52661a747f1a800071ed6f5461a1)
- and 2 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/21384551679) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++][CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #39975:
URL: https://github.com/apache/arrow/pull/39975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++][CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1934555044
You can stop praying now :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++][CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1934457459
Revision: b9ff2f337ad099118917ee1d20acd2b7049daaf3
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1f71ea13ea](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1f71ea13ea)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7832513778/job/21371379293)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/7832513898/job/21371380253)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7832514030/job/21371381071)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/21371382182)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7832514153/job/21371381016)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7832514266/job/21371381687)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/7832513991/job/21371380242)|
|test-fedora-38-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7832514192/job/21371381750)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7832513989/job/21371380216)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/7832513954/job/21371380219)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/7832513840/job/21371379704)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/7832514082/job/21371381145)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/7832513765/job/21371379266)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/7832514066/job/21371380853)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/7832514094/job/21371381289)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++][CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #39975:
URL: https://github.com/apache/arrow/pull/39975#discussion_r1483160397
##########
cpp/src/arrow/memory_pool.cc:
##########
@@ -195,7 +195,7 @@ bool IsDebugEnabled() {
return false;
}
auto env_value = *std::move(maybe_env_value);
- if (env_value.empty()) {
+ if (env_value.empty() || env_value == "none") {
Review Comment:
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39973: [C++][CI] Disable debug memory pool for ASAN and Valgrind [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #39975:
URL: https://github.com/apache/arrow/pull/39975#issuecomment-1934457712
> I've rebased, hopefully CI wil be green now.
Thank you for rebasing.
Praying for CI now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org