[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10826: Upsert snapshot should be taken before new a consuming segment created

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #10826:
URL: https://github.com/apache/pinot/pull/10826#discussion_r1212393148


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -1071,6 +1075,21 @@ private void closeStreamConsumers() {
     if (_acquiredConsumerSemaphore.compareAndSet(true, false)) {
       _partitionGroupConsumerSemaphore.release();
     }
+    if (_tableConfig.getUpsertConfig().isEnableSnapshot()) {

Review Comment:
   Why do we take snapshot here? `_isReadyToConsumeData` won't be picked up by the next segment.
   I feel we can take the snapshot just after acquiring the consumer semaphore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org