You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Alex Herbert <al...@gmail.com> on 2021/09/02 18:03:28 UTC

[VOTE][RC1] Release Commons RNG 1.4

We have fixed quite a few bugs and added some significant enhancements
since Apache Commons RNG 1.3 was released, so I would like to release
Apache Commons RNG 1.4.

Apache Commons RNG 1.4 RC1 is available for review here:
    https://dist.apache.org/repos/dist/dev/commons/rng/1.4-RC1 (svn
revision 49724)
    https://home.apache.org/~aherbert/commons-rng-1.4-RC1-site/

The Git tag commit for this RC is RNG_1_4_RC1 which you can browse here:

https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commit;h=RNG_1_4_RC1

You may checkout this tag using:
    git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch
RNG_1_4_RC1 commons-rng-1.4-RC1
(signature can be checked from git using 'git tag -v RNG_1_4_RC1')

Commit ID the tag points at:
    6f2e939bc1ae5d7c1317d4fb1af9ef3ac8d45e54

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1568/org/apache/commons/

These are the artifacts and their hashes:

#Release SHA-512s
#Thu Sep 02 18:11:24 BST 2021
commons-rng-1.4-src.zip=1609416f8852d93f5d139e5c9e9be2f340e90ee2d41d0ecb5543a9bc0e8578d232844b966e65aab12d47acc4df6455012cca03a743dac0e5a6915a58f0c401c8
commons-rng-1.4-src.tar.gz=8665358138395119d7217230ab13e39e83d794524112a99af5ecd6c53bcd9188915e1fa005daa2d21bec7e4d9c0a185df503b8e3e594ffadfc34ffd5b0654669
commons-rng-1.4-bin.tar.gz=670c4cd6309fca836fae5af3e5eb54a1d1c1b0edce4c8fb65ee04fc7e87650a53cd28290578119b8cfd4c3e43039ac7b2efaf269c18d81fd4207ef0d1626f1ed
commons-rng-1.4-bin.zip=5612ad2897958a571e66e7ccff6fe056ed4fb170d2a16c79f5ae08d465e2a81b7c03e69af09fdd1e4f6bb11d1d5bd43034afa126a0a0bc997f4124b7c9387ce5

The source code contains examples that are not part of the public API.
These examples contain Java 11 modules and are enabled using a profile (see
below).

Note: Testing randomness using statistical thresholds results in failures
at a given probability. The 'maven-surefire-plugin' is configured to re-run
tests that fail, and pass the build if they succeed within the allotted
number of reruns (the test will be marked as 'flaky' in the report).

I have tested this with 'mvn clean install' using:

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/local/apache-maven-3.6.3
Java version: 1.8.0_241, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/jdk1.8.0_241/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-153-generic", arch: "amd64", family:
"unix"

I have tested this with 'mvn clean package site site:stage
-Pcommons-rng-examples' using:

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/local/apache-maven-3.6.3
Java version: 11.0.11, vendor: Ubuntu, runtime:
/usr/lib/jvm/java-11-openjdk-amd64
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-153-generic", arch: "amd64", family:
"unix"

Details of changes since 1.3 are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/rng/1.4-RC1/RELEASE-NOTES.txt

https://home.apache.org/~aherbert/commons-rng-1.4-RC1-site/changes-report.html

Site:
    https://home.apache.org/~aherbert/commons-rng-1.4-RC1-site/index.html
    (note some *relative* links are broken and the 1.4 directories are not
yet created - these will be OK once the site is deployed.)

JApiCmp Report (compared to 1.3):

https://home.apache.org/~aherbert/commons-rng-1.4-RC1-site/commons-rng-client-api/japicmp.html

https://home.apache.org/~aherbert/commons-rng-1.4-RC1-site/commons-rng-core/japicmp.html

https://home.apache.org/~aherbert/commons-rng-1.4-RC1-site/commons-rng-simple/japicmp.html

https://home.apache.org/~aherbert/commons-rng-1.4-RC1-site/commons-rng-sampling/japicmp.html


RAT Report:

https://home.apache.org/~aherbert/commons-rng-1.4-RC1-site/rat-report.html

KEYS:
  https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner than 72 hours from now.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thank you,

Alex Herbert,
Release Manager (using key BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567)

The following is intended as a helper and refresher for reviewers.

Validating a release candidate
==============================

These guidelines are NOT complete.

Requirements: Git, Java, Maven.

You can validate a release from a release candidate (RC) tag as follows.

1) Clone and checkout the RC tag

git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch
RNG_1_4_RC1 commons-rng-1.4-RC1
cd commons-rng-1.4-RC1

Alternatively extract the .tar.gz or .zip source archive from the release
artifacts.

2) Check Apache licenses

This step is not required if the site includes a RAT report page which you
then must check.

mvn apache-rat:check

3) Check binary compatibility

This step is not required if the site includes a JApiCmp report page which
you then must check.

mvn package -DskipTests -P japicmp japicmp:cmp

4) Build the package

mvn -V clean verify

You can record the Maven and Java version produced by 'mvn -v' in your VOTE
reply.

To gather OS information from a command line:
Windows: ver
Linux: uname -a

5) Build the site for a multi-module project

mvn package site site:stage

Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html

-the end-

Re: [VOTE][RC1] Release Commons RNG 1.4

Posted by Alex Herbert <al...@gmail.com>.
Vote cancelled in favour of RC2.

Please see the new vote thread and validate the updated release candidate.

Alex

Re: [VOTE][RC1] Release Commons RNG 1.4

Posted by Alex Herbert <al...@gmail.com>.
Hi Matt,

Thanks for the info. I did not realise the source distribution did not
include the .gitignore file. I'll reroll an RC2 tomorrow fixing the
problems caused by the non essential SVN site checkout and the files it
creates.

Alex

On Sun, 5 Sep 2021, 21:13 Matt Juntunen, <ma...@gmail.com> wrote:

> Hi Alex,
>
> > The .gitignore file contains the entry 'site-content*'. This allows the
> > file to be ignored in Linux or Mac. I've never tried windows.  So this
> fails?
>
> > mvn pre-site
> > mvn apache-rat:check
>
> Yes, it fails. I'm building from the source distribution which does
> not include the .gitignore file. It will pass if I either
> - add a .gitignore file with a "site-content*" entry or
> - add "**/site-content.README" as an exclusion in the pom rat
> configurations.
>
> The second option is what I did for commons-geometry.
>
> -Matt
>
> On Sun, Sep 5, 2021 at 9:38 AM Alex Herbert <al...@gmail.com>
> wrote:
> >
> > Hi,
> >
> > On Sun, 5 Sept 2021 at 13:51, Matt Juntunen <ma...@gmail.com>
> > wrote:
> >
> >
> > > [ERROR] Failed to execute goal
> > > org.apache.rat:apache-rat-plugin:0.13:check (rat-check) on project
> > > commons-rng-parent: Too many files with unapproved license: 1 See RAT
> > > report in:
> > >
> C:\Users\matt\projects\commons-rng-1.4-src\commons-rng-1.4-src\target\rat.txt
> > > -> [Help 1]
> > >
> > > The failed file is site-content.README. In commons-geometry, I had to
> > > explicitly add this file to the rat excludes in the pom in order to
> > > get the build to pass.
> > >
> >
> > The .gitignore file contains the entry 'site-content*'. This allows the
> > file to be ignored in Linux or Mac. I've never tried windows. So this
> fails?
> >
> > mvn pre-site
> > mvn apache-rat:check
> >
> > Because the newly created site-content.README is not ignored on windows.
> >
> >
> > > I also noticed that the userguide Dependencies section still lists the
> > > required Java version as 1.7+. I don't consider that a blocker in
> > > itself but we might want to update that as well.
> > >
> >
> > Thanks for spotting the issue.
> >
> > Given the issues with the site-content download I think I will fix this
> and
> > re-roll an RC2.
> >
> > Alex
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Re: [VOTE][RC1] Release Commons RNG 1.4

Posted by Matt Juntunen <ma...@gmail.com>.
Hi Alex,

> The .gitignore file contains the entry 'site-content*'. This allows the
> file to be ignored in Linux or Mac. I've never tried windows.  So this fails?

> mvn pre-site
> mvn apache-rat:check

Yes, it fails. I'm building from the source distribution which does
not include the .gitignore file. It will pass if I either
- add a .gitignore file with a "site-content*" entry or
- add "**/site-content.README" as an exclusion in the pom rat configurations.

The second option is what I did for commons-geometry.

-Matt

On Sun, Sep 5, 2021 at 9:38 AM Alex Herbert <al...@gmail.com> wrote:
>
> Hi,
>
> On Sun, 5 Sept 2021 at 13:51, Matt Juntunen <ma...@gmail.com>
> wrote:
>
>
> > [ERROR] Failed to execute goal
> > org.apache.rat:apache-rat-plugin:0.13:check (rat-check) on project
> > commons-rng-parent: Too many files with unapproved license: 1 See RAT
> > report in:
> > C:\Users\matt\projects\commons-rng-1.4-src\commons-rng-1.4-src\target\rat.txt
> > -> [Help 1]
> >
> > The failed file is site-content.README. In commons-geometry, I had to
> > explicitly add this file to the rat excludes in the pom in order to
> > get the build to pass.
> >
>
> The .gitignore file contains the entry 'site-content*'. This allows the
> file to be ignored in Linux or Mac. I've never tried windows. So this fails?
>
> mvn pre-site
> mvn apache-rat:check
>
> Because the newly created site-content.README is not ignored on windows.
>
>
> > I also noticed that the userguide Dependencies section still lists the
> > required Java version as 1.7+. I don't consider that a blocker in
> > itself but we might want to update that as well.
> >
>
> Thanks for spotting the issue.
>
> Given the issues with the site-content download I think I will fix this and
> re-roll an RC2.
>
> Alex

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE][RC1] Release Commons RNG 1.4

Posted by Alex Herbert <al...@gmail.com>.
Hi,

On Sun, 5 Sept 2021 at 13:51, Matt Juntunen <ma...@gmail.com>
wrote:


> [ERROR] Failed to execute goal
> org.apache.rat:apache-rat-plugin:0.13:check (rat-check) on project
> commons-rng-parent: Too many files with unapproved license: 1 See RAT
> report in:
> C:\Users\matt\projects\commons-rng-1.4-src\commons-rng-1.4-src\target\rat.txt
> -> [Help 1]
>
> The failed file is site-content.README. In commons-geometry, I had to
> explicitly add this file to the rat excludes in the pom in order to
> get the build to pass.
>

The .gitignore file contains the entry 'site-content*'. This allows the
file to be ignored in Linux or Mac. I've never tried windows. So this fails?

mvn pre-site
mvn apache-rat:check

Because the newly created site-content.README is not ignored on windows.


> I also noticed that the userguide Dependencies section still lists the
> required Java version as 1.7+. I don't consider that a blocker in
> itself but we might want to update that as well.
>

Thanks for spotting the issue.

Given the issues with the site-content download I think I will fix this and
re-roll an RC2.

Alex

Re: [VOTE][RC1] Release Commons RNG 1.4

Posted by Matt Juntunen <ma...@gmail.com>.
I ran into an error building from the source distribution on Windows.

C:\Users\matt\projects\commons-rng-1.4-src\commons-rng-1.4-src> mvn -v
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Users\matt\tools\apache-maven-3.6.3-bin\apache-maven-3.6.3\bin\..
Java version: 11.0.12, vendor: Eclipse Foundation, runtime: C:\Program
Files\Eclipse Foundation\jdk-11.0.12.7-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

C:\Users\matt\projects\commons-rng-1.4-src\commons-rng-1.4-src>mvn
clean package site site:stage -Pcommons-rng-examples
...
[INFO] Reactor Summary for Apache Commons RNG 1.4:
[INFO]
[INFO] Apache Commons RNG ................................. FAILURE [  4.472 s]
[INFO] Apache Commons RNG Client API ...................... SKIPPED
[INFO] Apache Commons RNG Core ............................ SKIPPED
[INFO] Apache Commons RNG Simple .......................... SKIPPED
[INFO] Apache Commons RNG Sampling ........................ SKIPPED
[INFO] Apache Commons RNG Examples ........................ SKIPPED
[INFO] Apache Commons RNG Examples Stress Utilities ....... SKIPPED
[INFO] Apache Commons RNG Examples Sampling Utilities ..... SKIPPED
[INFO] Apache Commons RNG Quadrature Example .............. SKIPPED
[INFO] Apache Commons RNG JMH Benchmark ................... SKIPPED
[INFO] Apache Commons RNG JPMS Integration Test ........... SKIPPED
[INFO] Apache Commons RNG JPMS Module Example (Library) ... SKIPPED
[INFO] Apache Commons RNG JPMS Module Example (Application) SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  5.207 s
[INFO] Finished at: 2021-09-05T08:43:29-04:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.rat:apache-rat-plugin:0.13:check (rat-check) on project
commons-rng-parent: Too many files with unapproved license: 1 See RAT
report in: C:\Users\matt\projects\commons-rng-1.4-src\commons-rng-1.4-src\target\rat.txt
-> [Help 1]

The failed file is site-content.README. In commons-geometry, I had to
explicitly add this file to the rat excludes in the pom in order to
get the build to pass.

I also noticed that the userguide Dependencies section still lists the
required Java version as 1.7+. I don't consider that a blocker in
itself but we might want to update that as well.

Everything else looks good.

Regards,
Matt J


On Sat, Sep 4, 2021 at 12:58 PM Alex Herbert <al...@gmail.com> wrote:
>
> Note it also prevents a site build if you don't have SVN installed.
>
> My previous changes to this were to continue its support but improve it to
> a minimal download. I'll move this functionality to a profile as it is only
> of concern when updating the site.
>
> Alex
>
> On Sat, 4 Sep 2021, 14:46 Gilles Sadowski, <gi...@gmail.com> wrote:
>
> > Hello.
> >
> > Le ven. 3 sept. 2021 à 09:32, Alex Herbert <al...@gmail.com> a
> > écrit :
> > >
> > > Hi,
> > >
> > > On Fri, 3 Sept 2021 at 00:29, Gilles Sadowski <gi...@gmail.com>
> > wrote:
> > >
> > >
> > > >
> > > > I noticed that missing "site-content" directories still lead to the
> > > > contents being downloaded as part of the build.
> > > > I thought the "fix" was that it would not occur by default; or did
> > > > I miss something?
> > > >
> > >
> > > The current solution is that the top-level directory of the existing site
> > > is checked out in the parent module (i.e. non recursive site checkout).
> > So
> > > you do get a few files logged by maven as being checked out during the
> > > 'site' goal. There should be a 'site-content.README' file created which
> > > contains information about the site-content directory. It has to be
> > outside
> > > the site-content directory. In all the child modules an otherwise empty
> > > site-content directory is created with a README inside to indicate why it
> > > is there. A repeat of the site build should detect all the directories
> > are
> > > present and not invoke the checkout again.
> > >
> > > All this should be removed by using the 'clean' goal.
> > >
> > > Are you getting a total site checkout or just the solution I described?
> >
> > It works as you describe.
> >
> > Taking a step back, I'm still missing why there is any download
> > from SVN in order to fulfill the "site" target (a local build of the site
> > from the source release should not need "external" material, IIUC).
> >
> > Regards,
> > Gilles
> >
> > > [...]
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE][RC1] Release Commons RNG 1.4

Posted by Alex Herbert <al...@gmail.com>.
Note it also prevents a site build if you don't have SVN installed.

My previous changes to this were to continue its support but improve it to
a minimal download. I'll move this functionality to a profile as it is only
of concern when updating the site.

Alex

On Sat, 4 Sep 2021, 14:46 Gilles Sadowski, <gi...@gmail.com> wrote:

> Hello.
>
> Le ven. 3 sept. 2021 à 09:32, Alex Herbert <al...@gmail.com> a
> écrit :
> >
> > Hi,
> >
> > On Fri, 3 Sept 2021 at 00:29, Gilles Sadowski <gi...@gmail.com>
> wrote:
> >
> >
> > >
> > > I noticed that missing "site-content" directories still lead to the
> > > contents being downloaded as part of the build.
> > > I thought the "fix" was that it would not occur by default; or did
> > > I miss something?
> > >
> >
> > The current solution is that the top-level directory of the existing site
> > is checked out in the parent module (i.e. non recursive site checkout).
> So
> > you do get a few files logged by maven as being checked out during the
> > 'site' goal. There should be a 'site-content.README' file created which
> > contains information about the site-content directory. It has to be
> outside
> > the site-content directory. In all the child modules an otherwise empty
> > site-content directory is created with a README inside to indicate why it
> > is there. A repeat of the site build should detect all the directories
> are
> > present and not invoke the checkout again.
> >
> > All this should be removed by using the 'clean' goal.
> >
> > Are you getting a total site checkout or just the solution I described?
>
> It works as you describe.
>
> Taking a step back, I'm still missing why there is any download
> from SVN in order to fulfill the "site" target (a local build of the site
> from the source release should not need "external" material, IIUC).
>
> Regards,
> Gilles
>
> > [...]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Re: [VOTE][RC1] Release Commons RNG 1.4

Posted by Gilles Sadowski <gi...@gmail.com>.
Hello.

Le ven. 3 sept. 2021 à 09:32, Alex Herbert <al...@gmail.com> a écrit :
>
> Hi,
>
> On Fri, 3 Sept 2021 at 00:29, Gilles Sadowski <gi...@gmail.com> wrote:
>
>
> >
> > I noticed that missing "site-content" directories still lead to the
> > contents being downloaded as part of the build.
> > I thought the "fix" was that it would not occur by default; or did
> > I miss something?
> >
>
> The current solution is that the top-level directory of the existing site
> is checked out in the parent module (i.e. non recursive site checkout). So
> you do get a few files logged by maven as being checked out during the
> 'site' goal. There should be a 'site-content.README' file created which
> contains information about the site-content directory. It has to be outside
> the site-content directory. In all the child modules an otherwise empty
> site-content directory is created with a README inside to indicate why it
> is there. A repeat of the site build should detect all the directories are
> present and not invoke the checkout again.
>
> All this should be removed by using the 'clean' goal.
>
> Are you getting a total site checkout or just the solution I described?

It works as you describe.

Taking a step back, I'm still missing why there is any download
from SVN in order to fulfill the "site" target (a local build of the site
from the source release should not need "external" material, IIUC).

Regards,
Gilles

> [...]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE][RC1] Release Commons RNG 1.4

Posted by Alex Herbert <al...@gmail.com>.
Hi,

On Fri, 3 Sept 2021 at 00:29, Gilles Sadowski <gi...@gmail.com> wrote:


>
> I noticed that missing "site-content" directories still lead to the
> contents being downloaded as part of the build.
> I thought the "fix" was that it would not occur by default; or did
> I miss something?
>

The current solution is that the top-level directory of the existing site
is checked out in the parent module (i.e. non recursive site checkout). So
you do get a few files logged by maven as being checked out during the
'site' goal. There should be a 'site-content.README' file created which
contains information about the site-content directory. It has to be outside
the site-content directory. In all the child modules an otherwise empty
site-content directory is created with a README inside to indicate why it
is there. A repeat of the site build should detect all the directories are
present and not invoke the checkout again.

All this should be removed by using the 'clean' goal.

Are you getting a total site checkout or just the solution I described? Try
this (the tasks run in pre-site so you do not need to run the site goal):

# Should do the minimal checkout
mvn pre-site

# No repeat
mvn pre-site

# Remove site-content directories
mvn clean

Perhaps this is not an ideal solution. However I do not think that
performing a site build is a common task for non-developers. Anyone with
the source code is most likely to run 'mvn install'.

Since it only appears to be used when uploading a new site then it could
run in the release profile or perhaps even a 'site-checkout' profile to run
before the site goal in the maven lifecycle:

mvn -Psite-checkout pre-site

Alex

Re: [VOTE][RC1] Release Commons RNG 1.4

Posted by Gilles Sadowski <gi...@gmail.com>.
Le jeu. 2 sept. 2021 à 20:03, Alex Herbert <al...@gmail.com> a écrit :
>
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons RNG 1.3 was released, so I would like to release
> Apache Commons RNG 1.4.
>
> Apache Commons RNG 1.4 RC1 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/rng/1.4-RC1 (svn
> revision 49724)
>     https://home.apache.org/~aherbert/commons-rng-1.4-RC1-site/
>
> The Git tag commit for this RC is RNG_1_4_RC1 which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commit;h=RNG_1_4_RC1
>
> You may checkout this tag using:
>     git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch
> RNG_1_4_RC1 commons-rng-1.4-RC1
> (signature can be checked from git using 'git tag -v RNG_1_4_RC1')

Build OK with
$ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64/ mvn --version
Apache Maven 3.6.0
Maven home: /usr/share/maven
Java version: 1.8.0_292, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.19.0-16-amd64", arch: "amd64", family: "unix"

I noticed that missing "site-content" directories still lead to the
contents being downloaded as part of the build.
I thought the "fix" was that it would not occur by default; or did
I miss something?

>
> Commit ID the tag points at:
>     6f2e939bc1ae5d7c1317d4fb1af9ef3ac8d45e54
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1568/org/apache/commons/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Thu Sep 02 18:11:24 BST 2021
> commons-rng-1.4-src.zip=1609416f8852d93f5d139e5c9e9be2f340e90ee2d41d0ecb5543a9bc0e8578d232844b966e65aab12d47acc4df6455012cca03a743dac0e5a6915a58f0c401c8
> commons-rng-1.4-src.tar.gz=8665358138395119d7217230ab13e39e83d794524112a99af5ecd6c53bcd9188915e1fa005daa2d21bec7e4d9c0a185df503b8e3e594ffadfc34ffd5b0654669
> commons-rng-1.4-bin.tar.gz=670c4cd6309fca836fae5af3e5eb54a1d1c1b0edce4c8fb65ee04fc7e87650a53cd28290578119b8cfd4c3e43039ac7b2efaf269c18d81fd4207ef0d1626f1ed
> commons-rng-1.4-bin.zip=5612ad2897958a571e66e7ccff6fe056ed4fb170d2a16c79f5ae08d465e2a81b7c03e69af09fdd1e4f6bb11d1d5bd43034afa126a0a0bc997f4124b7c9387ce5
>

Checksum OK.

> The source code contains examples that are not part of the public API.
> These examples contain Java 11 modules and are enabled using a profile (see
> below).
>
> Note: Testing randomness using statistical thresholds results in failures
> at a given probability. The 'maven-surefire-plugin' is configured to re-run
> tests that fail, and pass the build if they succeed within the allotted
> number of reruns (the test will be marked as 'flaky' in the report).
>
> I have tested this with 'mvn clean install' using:
>
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /usr/local/apache-maven-3.6.3
> Java version: 1.8.0_241, vendor: Oracle Corporation, runtime:
> /usr/lib/jvm/jdk1.8.0_241/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-153-generic", arch: "amd64", family:
> "unix"
>
> I have tested this with 'mvn clean package site site:stage
> -Pcommons-rng-examples' using:
>
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /usr/local/apache-maven-3.6.3
> Java version: 11.0.11, vendor: Ubuntu, runtime:
> /usr/lib/jvm/java-11-openjdk-amd64
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-153-generic", arch: "amd64", family:
> "unix"

Build OK with:
$ JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64/ mvn --version
Apache Maven 3.6.0
Maven home: /usr/share/maven
Java version: 11.0.11, vendor: Debian, runtime:
/usr/lib/jvm/java-11-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.19.0-16-amd64", arch: "amd64", family: "unix"

>
> Details of changes since 1.3 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/rng/1.4-RC1/RELEASE-NOTES.txt
>
> https://home.apache.org/~aherbert/commons-rng-1.4-RC1-site/changes-report.html
>
> Site:
>     https://home.apache.org/~aherbert/commons-rng-1.4-RC1-site/index.html
>     (note some *relative* links are broken and the 1.4 directories are not
> yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.3):
>
> https://home.apache.org/~aherbert/commons-rng-1.4-RC1-site/commons-rng-client-api/japicmp.html
>
> https://home.apache.org/~aherbert/commons-rng-1.4-RC1-site/commons-rng-core/japicmp.html
>
> https://home.apache.org/~aherbert/commons-rng-1.4-RC1-site/commons-rng-simple/japicmp.html
>
> https://home.apache.org/~aherbert/commons-rng-1.4-RC1-site/commons-rng-sampling/japicmp.html
>
>
> RAT Report:
>
> https://home.apache.org/~aherbert/commons-rng-1.4-RC1-site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>

[X] +1 Release these artifacts

Regards,
Gilles

>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
>  [...]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org