You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by martincgg <gi...@git.apache.org> on 2014/04/11 19:14:46 UTC
[GitHub] cordova-windows pull request: CB-6435 ./VERSION & /template/VERSIO...
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-windows/pull/25
CB-6435 ./VERSION & /template/VERSION updated
Version files updated to 3.4.0.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-windows CB-6435
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit 6ae3beeba5e0924e539d99d7b7ff98e6b52c5ed0
Author: Martin Gonzalez <ma...@gmail.com>
Date: 2014-04-11T17:10:39Z
CB-6435 ./VERSION & /template/VERSION updated
version files updated to 3.4.0, to be merged into master.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-windows pull request: CB-6435 ./VERSION & /template/VERSIO...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-windows pull request: CB-6435 ./VERSION & /template/VERSIO...
Posted by martincgg <gi...@git.apache.org>.
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-windows/pull/25#issuecomment-40526960
Well, there's the files 3.5.0-dev set.
If want to merge them, or fix it by your own, it would be great.
Thanks a lot @clelland for taking the time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-windows pull request: CB-6435 ./VERSION & /template/VERSIO...
Posted by clelland <gi...@git.apache.org>.
Github user clelland commented on the pull request:
https://github.com/apache/cordova-windows/pull/25#issuecomment-40361496
It seems odd that this wasn't taken care of automatically by coho when 3.3.0 was released (and when 3.4.0 was released); if it's still not happening when we do 3.5.0, we should look deeper to see if something else is wrong with the tools.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-windows pull request: CB-6435 ./VERSION & /template/VERSIO...
Posted by martincgg <gi...@git.apache.org>.
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-windows/pull/25#issuecomment-40375277
Yes, agree. This is completely odd, what worries me, is when trying to install plugins to a project with windows 8 platform installed, it throws an error with plugman module:
https://github.com/apache/cordova-plugman/blob/master/src/install.js#L90
So it stops the whole thing and is not possible add plugins to the project. So this need to be fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-windows pull request: CB-6435 ./VERSION & /template/VERSIO...
Posted by martincgg <gi...@git.apache.org>.
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-windows/pull/25#issuecomment-40494097
Hello @clelland , are able to merge this changes, or you will take care of this in another way?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-windows pull request: CB-6435 ./VERSION & /template/VERSIO...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/25#issuecomment-40528015
Closed, thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-windows pull request: CB-6435 ./VERSION & /template/VERSIO...
Posted by clelland <gi...@git.apache.org>.
Github user clelland commented on the pull request:
https://github.com/apache/cordova-windows/pull/25#issuecomment-40526123
I think that we should change version to 3.5.0-dev, like the other platforms (since 3.4.0 is released already, development should now be on 3.5.0-dev), and then we'll make sure that it gets fixed to 3.5.0 when that gets released.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---