[GitHub] [accumulo] EdColeman commented on a change in pull request #2186: Refactor common table property validation to reduce duplication

[GitBox <gi...@apache.org>]

EdColeman commented on a change in pull request #2186:
URL: https://github.com/apache/accumulo/pull/2186#discussion_r662536188



##########
File path: core/src/test/java/org/apache/accumulo/core/conf/PropertyTest.java
##########
@@ -186,4 +188,61 @@ public void testIsValidTablePropertyKey() {
 
     assertFalse(Property.isValidTablePropertyKey("abc.def"));
   }
+
+  /**
+   * PR #2186 eliminated a loop in the computation - this test verifies the original methods and the
+   * refactor method produce the same result.
+   */
+  @Test
+  public void verifyRefactor() {
+

Review comment:
       The test compares that that current code and the proposed code maps contain the same contents.  It was basically a one-off to show that the proposed code functions the same as what is there now.  No issues deleting it if the code modifications are accepted.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org