[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #607: PHOENIX-5103: Can't create/drop table using 4.14 client against 4.15 server (Addendum)

[GitBox <gi...@apache.org>]

ChinmaySKulkarni commented on a change in pull request #607: PHOENIX-5103: Can't create/drop table using 4.14 client against 4.15 server (Addendum)
URL: https://github.com/apache/phoenix/pull/607#discussion_r343247931
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/query/DelegateConnectionQueryServices.java
 ##########
 @@ -361,6 +361,11 @@ public boolean isUpgradeRequired() {
         return getDelegate().isUpgradeRequired();
     }
 
+    @Override
+    public void clearUpgradeRequired() {
+        getDelegate().isUpgradeRequired();
 
 Review comment:
   Good catch! Copy-paste error. Luckily this method is never really used in our upgrade code path since we use the `CQSI.clearUpgradeRequired`. I will add this to my changes for PHOENIX-5544 since it works with relatively the same path and 5103 is already committed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services