You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/05/10 14:58:28 UTC
[GitHub] [incubator-kyuubi] packyan opened a new pull request, #2625: [KYUUBI #2624] Support isExtended for FilteredShowDatabasesCommand in AuthZ module.
packyan opened a new pull request, #2625:
URL: https://github.com/apache/incubator-kyuubi/pull/2625
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
to close #2624.
### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2625: [KYUUBI #2624] Support isExtended for FilteredShowTablesCommand in AuthZ module.
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #2625:
URL: https://github.com/apache/incubator-kyuubi/pull/2625#discussion_r880013341
##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala:
##########
@@ -273,6 +273,30 @@ abstract class RangerSparkExtensionSuite extends KyuubiFunSuite with SparkSessio
doAs("admin", sql(s"DROP DATABASE IF EXISTS $db"))
}
}
+
+ test("show table extended") {
Review Comment:
is this same to hive？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] packyan commented on a diff in pull request #2625: [KYUUBI #2624] Support isExtended for FilteredShowTablesCommand in AuthZ module.
Posted by GitBox <gi...@apache.org>.
packyan commented on code in PR #2625:
URL: https://github.com/apache/incubator-kyuubi/pull/2625#discussion_r882537398
##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala:
##########
@@ -273,6 +273,30 @@ abstract class RangerSparkExtensionSuite extends KyuubiFunSuite with SparkSessio
doAs("admin", sql(s"DROP DATABASE IF EXISTS $db"))
}
}
+
+ test("show table extended") {
Review Comment:
> is this same to hive？
in hive, you can describe a table without any privilege.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhaomin1423 commented on pull request #2625: [KYUUBI #2624] Support isExtended for FilteredShowDatabasesCommand in AuthZ module.
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on PR #2625:
URL: https://github.com/apache/incubator-kyuubi/pull/2625#issuecomment-1123809365
The pr update the method of FilteredShowTablesCommand, but title is about FilteredShowDatabasesCommand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] packyan commented on a diff in pull request #2625: [KYUUBI #2624] Support isExtended for FilteredShowTablesCommand in AuthZ module.
Posted by GitBox <gi...@apache.org>.
packyan commented on code in PR #2625:
URL: https://github.com/apache/incubator-kyuubi/pull/2625#discussion_r882563847
##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala:
##########
@@ -273,6 +273,30 @@ abstract class RangerSparkExtensionSuite extends KyuubiFunSuite with SparkSessio
doAs("admin", sql(s"DROP DATABASE IF EXISTS $db"))
}
}
+
+ test("show table extended") {
Review Comment:
> you can submit PRs accordingly if the hive's behavior is reasonable. For example, DESCRIBE table seems that hive's right to me
My bad, after I try hive access control in real, I found you need SELECT privilege on a table to describe it. 😹
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2625: [KYUUBI #2624] Support isExtended for FilteredShowTablesCommand in AuthZ module.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2625:
URL: https://github.com/apache/incubator-kyuubi/pull/2625#issuecomment-1153049790
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2625](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (645ca97) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/ce56d700707434e6c3ee22952ab86121897e1d78?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ce56d70) will **increase** coverage by `0.28%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 645ca97 differs from pull request most recent head 6e8053a. Consider uploading reports for the commit 6e8053a to get more accurate results
```diff
@@ Coverage Diff @@
## master #2625 +/- ##
============================================
+ Coverage 63.32% 63.61% +0.28%
+ Complexity 205 79 -126
============================================
Files 485 380 -105
Lines 21692 18518 -3174
Branches 2859 2508 -351
============================================
- Hits 13737 11780 -1957
+ Misses 6655 5625 -1030
+ Partials 1300 1113 -187
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...k/authz/ranger/RuleReplaceShowObjectCommands.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstYXV0aHovc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvcGx1Z2luL3NwYXJrL2F1dGh6L3Jhbmdlci9SdWxlUmVwbGFjZVNob3dPYmplY3RDb21tYW5kcy5zY2FsYQ==) | `76.19% <100.00%> (+16.19%)` | :arrow_up: |
| [...c/main/java/org/apache/kyuubi/jdbc/hive/Utils.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9VdGlscy5qYXZh) | `2.34% <0.00%> (-34.25%)` | :arrow_down: |
| [...kyuubi/engine/trino/operation/TrinoOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9Ucmlub09wZXJhdGlvbi5zY2FsYQ==) | `53.06% <0.00%> (-16.33%)` | :arrow_down: |
| [...he/kyuubi/spark/connector/tpcds/TPCDSCatalog.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstY29ubmVjdG9yLXRwY2RzL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NwYXJrL2Nvbm5lY3Rvci90cGNkcy9UUENEU0NhdGFsb2cuc2NhbGE=) | `42.10% <0.00%> (-15.04%)` | :arrow_down: |
| [...org/apache/kyuubi/engine/flink/schema/RowSet.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9mbGluay9zY2hlbWEvUm93U2V0LnNjYWxh) | `54.86% <0.00%> (-10.96%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `63.33% <0.00%> (-10.36%)` | :arrow_down: |
| [...ache/kyuubi/jdbc/hive/KyuubiPreparedStatement.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9LeXV1YmlQcmVwYXJlZFN0YXRlbWVudC5qYXZh) | `27.58% <0.00%> (-9.12%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `68.96% <0.00%> (-9.01%)` | :arrow_down: |
| [...thentication/KyuubiHttpAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvaHR0cC9hdXRoZW50aWNhdGlvbi9LeXV1YmlIdHRwQXV0aGVudGljYXRpb25GYWN0b3J5LnNjYWxh) | `80.00% <0.00%> (-8.00%)` | :arrow_down: |
| [...ver/http/authentication/AuthenticationFilter.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvaHR0cC9hdXRoZW50aWNhdGlvbi9BdXRoZW50aWNhdGlvbkZpbHRlci5zY2FsYQ==) | `84.21% <0.00%> (-7.46%)` | :arrow_down: |
| ... and [224 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ce56d70...6e8053a](https://codecov.io/gh/apache/incubator-kyuubi/pull/2625?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2625: [KYUUBI #2624] Support isExtended for FilteredShowTablesCommand in AuthZ module.
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #2625:
URL: https://github.com/apache/incubator-kyuubi/pull/2625#discussion_r882551277
##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala:
##########
@@ -273,6 +273,30 @@ abstract class RangerSparkExtensionSuite extends KyuubiFunSuite with SparkSessio
doAs("admin", sql(s"DROP DATABASE IF EXISTS $db"))
}
}
+
+ test("show table extended") {
Review Comment:
you can submit PRs accordingly if the hive's behavior is reasonable. For example, DESCRIBE table seems that hive's right to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2625: [KYUUBI #2624] Support isExtended for FilteredShowDatabasesCommand in AuthZ module.
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #2625:
URL: https://github.com/apache/incubator-kyuubi/pull/2625#discussion_r869833845
##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala:
##########
@@ -273,6 +273,30 @@ abstract class RangerSparkExtensionSuite extends KyuubiFunSuite with SparkSessio
doAs("admin", sql(s"DROP DATABASE IF EXISTS $db"))
}
}
+
+ test("show table extended") {
Review Comment:
based on this test, nothing actually changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] packyan commented on a diff in pull request #2625: [KYUUBI #2624] Support isExtended for FilteredShowTablesCommand in AuthZ module.
Posted by GitBox <gi...@apache.org>.
packyan commented on code in PR #2625:
URL: https://github.com/apache/incubator-kyuubi/pull/2625#discussion_r882547518
##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala:
##########
@@ -273,6 +273,30 @@ abstract class RangerSparkExtensionSuite extends KyuubiFunSuite with SparkSessio
doAs("admin", sql(s"DROP DATABASE IF EXISTS $db"))
}
}
+
+ test("show table extended") {
Review Comment:
> Looks like we can follow hive's behavior
The permission control of hive is very simply, far less than what is considered in the privilegesbuilder. If we imitate the permission control of hive, the privilegesbuilder will reduce a lot of cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2625: [KYUUBI #2624] Support isExtended for FilteredShowTablesCommand in AuthZ module.
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #2625:
URL: https://github.com/apache/incubator-kyuubi/pull/2625#issuecomment-1153397271
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] packyan commented on a diff in pull request #2625: [KYUUBI #2624] Support isExtended for FilteredShowDatabasesCommand in AuthZ module.
Posted by GitBox <gi...@apache.org>.
packyan commented on code in PR #2625:
URL: https://github.com/apache/incubator-kyuubi/pull/2625#discussion_r874322229
##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala:
##########
@@ -273,6 +273,30 @@ abstract class RangerSparkExtensionSuite extends KyuubiFunSuite with SparkSessio
doAs("admin", sql(s"DROP DATABASE IF EXISTS $db"))
}
}
+
+ test("show table extended") {
Review Comment:
In PrivilegesBuilder, users should have SELECT privileges on a table to perform DESCRIBE operations on it, and `show table extended xxx` is similar to performing DESCRIBE operations on batched tables, so when it comes to `show tables extended xxx ` you should have SELECT privileges instead of USE privileges on these tables.
Since the tables in the test case either have SELECT privileges or none at all, nothing changes. I will further improve the test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] packyan commented on a diff in pull request #2625: [KYUUBI #2624] Support isExtended for FilteredShowTablesCommand in AuthZ module.
Posted by GitBox <gi...@apache.org>.
packyan commented on code in PR #2625:
URL: https://github.com/apache/incubator-kyuubi/pull/2625#discussion_r882564819
##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala:
##########
@@ -273,6 +273,30 @@ abstract class RangerSparkExtensionSuite extends KyuubiFunSuite with SparkSessio
doAs("admin", sql(s"DROP DATABASE IF EXISTS $db"))
}
}
+
+ test("show table extended") {
Review Comment:
> > you can submit PRs accordingly if the hive's behavior is reasonable. For example, DESCRIBE table seems that hive's right to me
>
> My bad, after I try hive access control in real, I found you need SELECT privilege on a table to describe it. 😹
At least in hive 2.3 you should have SELECT privilege to describe a table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2625: [KYUUBI #2624] Support isExtended for FilteredShowTablesCommand in AuthZ module.
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #2625:
URL: https://github.com/apache/incubator-kyuubi/pull/2625#discussion_r882542269
##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala:
##########
@@ -273,6 +273,30 @@ abstract class RangerSparkExtensionSuite extends KyuubiFunSuite with SparkSessio
doAs("admin", sql(s"DROP DATABASE IF EXISTS $db"))
}
}
+
+ test("show table extended") {
Review Comment:
Looks like we can follow hive's behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #2625: [KYUUBI #2624] Support isExtended for FilteredShowTablesCommand in AuthZ module.
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #2625: [KYUUBI #2624] Support isExtended for FilteredShowTablesCommand in AuthZ module.
URL: https://github.com/apache/incubator-kyuubi/pull/2625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] packyan commented on pull request #2625: [KYUUBI #2624] Support isExtended for FilteredShowTablesCommand in AuthZ module.
Posted by GitBox <gi...@apache.org>.
packyan commented on PR #2625:
URL: https://github.com/apache/incubator-kyuubi/pull/2625#issuecomment-1153090877
> please help。resolve conflicts
PLEASE REVIEW AGAIN.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2625: [KYUUBI #2624] Support isExtended for FilteredShowTablesCommand in AuthZ module.
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #2625:
URL: https://github.com/apache/incubator-kyuubi/pull/2625#issuecomment-1138464162
please help。resolve conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org