You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Namit Jain (JIRA)" <ji...@apache.org> on 2012/08/13 17:48:37 UTC
[jira] [Created] (HIVE-3375) bucketed map join should check that
the number of files match the number of buckets
Namit Jain created HIVE-3375:
--------------------------------
Summary: bucketed map join should check that the number of files match the number of buckets
Key: HIVE-3375
URL: https://issues.apache.org/jira/browse/HIVE-3375
Project: Hive
Issue Type: Bug
Components: Query Processor
Reporter: Namit Jain
Assignee: Namit Jain
Currently, we get NPE if that is not the case
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3375) bucketed map join should check that
the number of files match the number of buckets
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3375:
-----------------------------
Status: Patch Available (was: Open)
> bucketed map join should check that the number of files match the number of buckets
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3375
> URL: https://issues.apache.org/jira/browse/HIVE-3375
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.3375.1.patch
>
>
> Currently, we get NPE if that is not the case
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3375) bucketed map join should check that
the number of files match the number of buckets
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433255#comment-13433255 ]
Namit Jain commented on HIVE-3375:
----------------------------------
https://reviews.facebook.net/D4629
> bucketed map join should check that the number of files match the number of buckets
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3375
> URL: https://issues.apache.org/jira/browse/HIVE-3375
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Currently, we get NPE if that is not the case
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3375) bucketed map join should check that
the number of files match the number of buckets
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436190#comment-13436190 ]
Namit Jain commented on HIVE-3375:
----------------------------------
refreshed after few other commits
> bucketed map join should check that the number of files match the number of buckets
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3375
> URL: https://issues.apache.org/jira/browse/HIVE-3375
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.3375.1.patch, hive.3375.2.patch, hive.3375.3.patch
>
>
> Currently, we get NPE if that is not the case
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3375) bucketed map join should check that
the number of files match the number of buckets
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3375:
-----------------------------
Attachment: hive.3375.2.patch
> bucketed map join should check that the number of files match the number of buckets
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3375
> URL: https://issues.apache.org/jira/browse/HIVE-3375
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.3375.1.patch, hive.3375.2.patch
>
>
> Currently, we get NPE if that is not the case
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3375) bucketed map join should check that
the number of files match the number of buckets
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3375:
---------------------------------
Status: Open (was: Patch Available)
@Namit: I left a couple minor comments on phabricator. Thanks.
> bucketed map join should check that the number of files match the number of buckets
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3375
> URL: https://issues.apache.org/jira/browse/HIVE-3375
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.3375.1.patch
>
>
> Currently, we get NPE if that is not the case
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3375) bucketed map join should check that
the number of files match the number of buckets
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3375:
-----------------------------
Attachment: hive.3375.3.patch
> bucketed map join should check that the number of files match the number of buckets
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3375
> URL: https://issues.apache.org/jira/browse/HIVE-3375
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.3375.1.patch, hive.3375.2.patch, hive.3375.3.patch
>
>
> Currently, we get NPE if that is not the case
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3375) bucketed map join should check that
the number of files match the number of buckets
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433314#comment-13433314 ]
Kevin Wilfong commented on HIVE-3375:
-------------------------------------
+1 Looks good, let us know if the unit tests pass.
> bucketed map join should check that the number of files match the number of buckets
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3375
> URL: https://issues.apache.org/jira/browse/HIVE-3375
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.3375.1.patch
>
>
> Currently, we get NPE if that is not the case
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3375) bucketed map join should check that
the number of files match the number of buckets
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3375:
-----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed (Thanks kevin and carl)
> bucketed map join should check that the number of files match the number of buckets
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3375
> URL: https://issues.apache.org/jira/browse/HIVE-3375
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.3375.1.patch, hive.3375.2.patch, hive.3375.3.patch
>
>
> Currently, we get NPE if that is not the case
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3375) bucketed map join should check that
the number of files match the number of buckets
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434404#comment-13434404 ]
Kevin Wilfong commented on HIVE-3375:
-------------------------------------
[~cwsteinbach] Namit responded to your commments, and again, this looks good to me.
> bucketed map join should check that the number of files match the number of buckets
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3375
> URL: https://issues.apache.org/jira/browse/HIVE-3375
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.3375.1.patch, hive.3375.2.patch
>
>
> Currently, we get NPE if that is not the case
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3375) bucketed map join should check that
the number of files match the number of buckets
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3375:
-----------------------------
Status: Patch Available (was: Open)
comments
> bucketed map join should check that the number of files match the number of buckets
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3375
> URL: https://issues.apache.org/jira/browse/HIVE-3375
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.3375.1.patch, hive.3375.2.patch
>
>
> Currently, we get NPE if that is not the case
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3375) bucketed map join should check that
the number of files match the number of buckets
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3375:
-----------------------------
Attachment: hive.3375.1.patch
> bucketed map join should check that the number of files match the number of buckets
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3375
> URL: https://issues.apache.org/jira/browse/HIVE-3375
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.3375.1.patch
>
>
> Currently, we get NPE if that is not the case
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3375) bucketed map join should check that
the number of files match the number of buckets
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436227#comment-13436227 ]
Carl Steinbach commented on HIVE-3375:
--------------------------------------
+1
@Namit: Can you handle testing this and getting it committed? Thanks.
> bucketed map join should check that the number of files match the number of buckets
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3375
> URL: https://issues.apache.org/jira/browse/HIVE-3375
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.3375.1.patch, hive.3375.2.patch, hive.3375.3.patch
>
>
> Currently, we get NPE if that is not the case
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3375) bucketed map join should check that
the number of files match the number of buckets
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436667#comment-13436667 ]
Hudson commented on HIVE-3375:
------------------------------
Integrated in Hive-trunk-h0.21 #1613 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1613/])
HIVE-3375 bucketed map join should check that the number of files match
the number of buckets (namit via kevin and carl) (Revision 1374142)
Result = FAILURE
namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1374142
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapJoinOptimizer.java
* /hive/trunk/ql/src/test/queries/clientnegative/bucket_mapjoin_wrong_table_metadata_1.q
* /hive/trunk/ql/src/test/queries/clientnegative/bucket_mapjoin_wrong_table_metadata_2.q
* /hive/trunk/ql/src/test/queries/clientpositive/smb_mapjoin9.q
* /hive/trunk/ql/src/test/queries/clientpositive/smb_mapjoin_10.q
* /hive/trunk/ql/src/test/results/clientnegative/bucket_mapjoin_wrong_table_metadata_1.q.out
* /hive/trunk/ql/src/test/results/clientnegative/bucket_mapjoin_wrong_table_metadata_2.q.out
* /hive/trunk/ql/src/test/results/clientpositive/smb_mapjoin_10.q.out
> bucketed map join should check that the number of files match the number of buckets
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3375
> URL: https://issues.apache.org/jira/browse/HIVE-3375
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: hive.3375.1.patch, hive.3375.2.patch, hive.3375.3.patch
>
>
> Currently, we get NPE if that is not the case
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira