You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/09/21 23:18:44 UTC
Review Request 68807: Used `Future::discard` to abort an outdated
resuorce provider launches.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68807/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Repository: mesos
Description
-------
Used `Future::discard` to abort an outdated resuorce provider launches.
Diffs
-----
src/resource_provider/daemon.cpp 0a76cc6d1d34413674d1af1aa514679a4d2b7b55
Diff: https://reviews.apache.org/r/68807/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 68807: Used `Future::discard` to abort an outdated
resuorce provider launches.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68807/#review213028
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68755, 68756, 68757, 68777, 68758, 68790, 68763, 68762, 68807]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 22, 2018, 6:54 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68807/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2018, 6:54 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used `Future::discard` to abort an outdated resuorce provider launches.
>
>
> Diffs
> -----
>
> src/resource_provider/daemon.cpp 0a76cc6d1d34413674d1af1aa514679a4d2b7b55
>
>
> Diff: https://reviews.apache.org/r/68807/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68807: Used `Future::discard` to abort an outdated
resuorce provider launches.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68807/#review208918
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68807']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2380/mesos-review-68807
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2380/mesos-review-68807/logs/mesos-tests.log):
```
I0922 07:55:00.831970 9312 executor.cpp:909] Sending SIGTERM to process tree at pid 1232] Updating the state of task 25cecafe-088c-4ca4-b589-933c72016f88 of framework fac7222c-21d4-4a85-9da3-cbc09ed66823-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0922 07:55:00.829968 12832 slave.cpp:6640] Shutting down executor '25cecafe-088c-4ca4-b589-933c72016f88' of framework fac7222c-21d4-4a85-9da3-cbc09ed66823-0000 at executor(1)@192.10.1.8:50352
I0922 07:55:00.831970 12104 master.cpp:11030] Removing task 25cecafe-088c-4ca4-b589-933c72016f88 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework fac7222c-21d4-4a85-9da3-cbc09ed66823-0000 on agent fac7222c-21d4-4a85-9da3-cbc09ed66823-S0 at slave(463)@192.10.1.8:64912 (windows-05.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I0922 07:55:00.831970 11816 slave.cpp:909] Agent terminating
W0922 07:55:00.831970 11816 slave.cpp:3917] Ignoring shutdown framework fac7222c-21d4-4a85-9da3-cbc09ed66823-0000 because it is terminating
I0922 07:55:00.833963 12104 master.cpp:1251] Agent fac7222c-21d4-4a85-9da3-cbc09ed66823-S0 at slave(463)@192.10.1.8:64912 (windows-05.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I0922 07:55:00.833963 12104 master.cpp:3267] Disconnecting agent fac7222c-21d4-4a85-9da3-cbc09ed66823-S0 at slave(463)@192.10.1.8:64912 (windows-05.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I0922 07:55:00.835485 12104 master.cpp:3286] Deactivating agent fac7222c-21d4-4a85-9da3-cbc09ed66823-S0 at slave(463)@192.10.1.8:64912 (windows-05.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I0922 07:55:00.835968 7584 hierarchical.cpp:359] Removed framework fac7222c-21d4-4a85-9da3-cbc09ed66823-0000
I0922 07:55:00.835968 7584 hierarchical.cpp:795] Agent fac7222c-21d4-4a85-9da3-cbc09ed66823-S0 deactivated
I0922 07:55:00.835968 12104 containerizer.cpp:2455] Destroying container 0bfa8a25-ef98-4d0d-ace1-6bfe55b373b2 in RUNNING state
I0922 07:55:00.836985 12104 containerizer.cpp:3118] Transitioning the state of container 0bfa8a25-ef98-4d0[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (584 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (602 ms total)
[----------] Global test environment tear-down
[==========] 1052 tests from 103 test cases ran. (490668 ms total)
[ PASSED ] 1051 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
1 FAILED TEST
YOU HAVE 231 DISABLED TESTS
d-ace1-6bfe55b373b2 from RUNNING to DESTROYING
I0922 07:55:00.836985 12104 launcher.cpp:166] Asked to destroy container 0bfa8a25-ef98-4d0d-ace1-6bfe55b373b2
I0922 07:55:00.844982 11372 containerizer.cpp:2957] Container 0bfa8a25-ef98-4d0d-ace1-6bfe55b373b2 has exited
I0922 07:55:00.873970 11816 master.cpp:1093] Master terminating
I0922 07:55:00.875982 11372 hierarchical.cpp:637] Removed agent fac7222c-21d4-4a85-9da3-cbc09ed66823-S0
I0922 07:55:01.148006 10720 process.cpp:926] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Sept. 22, 2018, 6:54 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68807/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2018, 6:54 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used `Future::discard` to abort an outdated resuorce provider launches.
>
>
> Diffs
> -----
>
> src/resource_provider/daemon.cpp 0a76cc6d1d34413674d1af1aa514679a4d2b7b55
>
>
> Diff: https://reviews.apache.org/r/68807/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68807: Used `Future::discard` to abort an outdated
resuorce provider launches.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68807/
-----------------------------------------------------------
(Updated Sept. 22, 2018, 6:54 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Removed an unused function declaration.
Repository: mesos
Description
-------
Used `Future::discard` to abort an outdated resuorce provider launches.
Diffs (updated)
-----
src/resource_provider/daemon.cpp 0a76cc6d1d34413674d1af1aa514679a4d2b7b55
Diff: https://reviews.apache.org/r/68807/diff/3/
Changes: https://reviews.apache.org/r/68807/diff/2-3/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 68807: Used `Future::discard` to abort an outdated
resuorce provider launches.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68807/#review208913
-----------------------------------------------------------
PASS: Mesos patch 68807 was successfully built and tested.
Reviews applied: `['68755', '68756', '68757', '68777', '68758', '68790', '68763', '68762', '68807']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2376/mesos-review-68807
- Mesos Reviewbot Windows
On Sept. 22, 2018, 12:19 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68807/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2018, 12:19 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used `Future::discard` to abort an outdated resuorce provider launches.
>
>
> Diffs
> -----
>
> src/resource_provider/daemon.cpp 0a76cc6d1d34413674d1af1aa514679a4d2b7b55
>
>
> Diff: https://reviews.apache.org/r/68807/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68807: Used `Future::discard` to abort an outdated
resuorce provider launches.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68807/
-----------------------------------------------------------
(Updated Sept. 22, 2018, 12:19 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Renamed `launched` to `launching`.
Repository: mesos
Description
-------
Used `Future::discard` to abort an outdated resuorce provider launches.
Diffs (updated)
-----
src/resource_provider/daemon.cpp 0a76cc6d1d34413674d1af1aa514679a4d2b7b55
Diff: https://reviews.apache.org/r/68807/diff/2/
Changes: https://reviews.apache.org/r/68807/diff/1-2/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao