You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/20 14:53:42 UTC
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #20: Support GitHub Action
kezhenxu94 commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654945878
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
+ - shell: bash
+ run: |
+ cd skywalking-e2e
+ git clone https://github.com/mrproliu/skywalking-infra-e2e.git
Review comment:
```suggestion
git clone https://github.com/apache/skywalking-infra-e2e.git
```
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
+ - shell: bash
+ run: |
+ cd skywalking-e2e
+ git clone https://github.com/mrproliu/skywalking-infra-e2e.git
+ git -C skywalking-infra-e2e reset --hard 4fb6aef3f84b8d19bc38c75e4e4489d7ce1d8d71
+ cd skywalking-infra-e2e
+ go mod download && make linux && mv bin/linux/e2e ../bin/e2e
+ - shell: bash
+ run: |
+ cd skywalking-e2e
+ git clone https://github.com/apache/skywalking-cli.git
+ git -C skywalking-cli reset --hard 21ba64dd2ddfd6cfeca14801e7c3888f1befc3ca
+ cd skywalking-cli
+ make build && mv bin/swctl-*-linux-amd64 ../bin/swctl
+ - shell: bash
+ run: |
+ cd skywalking-e2e/bin
+ pwd=`pwd`
+ export PATH="$PATH:$pwd"
Review comment:
```suggestion
export PATH="$PATH:$(pwd)"
```
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
+ - shell: bash
+ run: |
+ cd skywalking-e2e
+ git clone https://github.com/mrproliu/skywalking-infra-e2e.git
+ git -C skywalking-infra-e2e reset --hard 4fb6aef3f84b8d19bc38c75e4e4489d7ce1d8d71
Review comment:
Did you find any clue about how to get the revision if a user specify it in `uses: apache/skywalking-infra-e2e@main`, for example, get the `v1.0` in `uses: apache/skywalking-infra-e2e@v1.0`?
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
Review comment:
Let's use an absolute path, for example, `/home/e2e`
##########
File path: test/verify/3.expected.yaml
##########
@@ -15,8 +15,10 @@
# specific language governing permissions and limitations
# under the License.
-{{- contains . }}
-- id: {{ notEmpty .id }}
- name: {{ notEmpty .name }}
+{{if . }}
+- id: { { notEmpty .id } }
+ name: { { notEmpty .name } }
Review comment:
this is syntax error I believe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org