You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Dandandan (via GitHub)" <gi...@apache.org> on 2026/03/16 15:19:41 UTC
[PR] feat: Batched accumulator storage for hash aggregation [datafusion]
Dandandan opened a new pull request, #20964:
URL: https://github.com/apache/datafusion/pull/20964
## Summary
- Introduces `BatchedVec<T>`, a Vec-like container that stores elements in fixed-size batches (default 8192)
- Updates `PrimitiveGroupsAccumulator` to use `BatchedVec` as proof of concept
- Flat `usize` group index is decomposed into `(batch, offset)` internally via division/modulo
Key operations on `BatchedVec`:
- `ensure_capacity(n, default)` — grow lazily on demand
- `get_unchecked_mut(index)` — O(1) indexed access via decomposition
- `take_batch(idx)` — **O(1)** emission of one batch via `mem::take`
- `take_all()` / `take_first(n)` — for existing `EmitTo::All` / `EmitTo::First(n)`
This enables O(1) per-batch emission from hash aggregation without materializing all groups into one large batch, and without the O(n²/batch_size) shifting cost of repeated `EmitTo::First(batch_size)`.
## Test plan
- [x] All 79 aggregate unit tests pass
- [x] All 23 functions-aggregate-common tests pass (including new BatchedVec unit tests)
- [ ] Extend to other accumulators (avg, count, variance, etc.)
- [ ] Wire up `EmittingBatches` state in `row_hash.rs` to use `take_batch`
- [ ] Extend to `GroupValues` implementations
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068515613
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068495691)
`Linux bench-c4068495691-319-c7wt4 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (495b6f20d5f5fd5b6851877f1c43f290f142d95e) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..495b6f20d5f5fd5b6851877f1c43f290f142d95e) using: tpcds
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068652363
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068495691)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark tpcds_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 49.22 / 50.22 ±0.59 / 50.84 ms │ 49.20 / 50.08 ±0.52 / 50.62 ms │ no change │
│ QQuery 2 │ 154.73 / 156.29 ±1.23 / 158.04 ms │ 151.36 / 152.57 ±0.91 / 154.02 ms │ no change │
│ QQuery 3 │ 119.37 / 119.96 ±0.52 / 120.66 ms │ 118.96 / 120.20 ±1.00 / 121.83 ms │ no change │
│ QQuery 4 │ 1321.85 / 1347.91 ±13.63 / 1361.15 ms │ 1320.17 / 1353.89 ±19.74 / 1378.08 ms │ no change │
│ QQuery 5 │ 183.12 / 185.30 ±1.36 / 186.92 ms │ 183.49 / 184.73 ±1.04 / 186.35 ms │ no change │
│ QQuery 6 │ 995.57 / 1010.07 ±24.29 / 1058.58 ms │ 996.10 / 1017.99 ±16.97 / 1040.14 ms │ no change │
│ QQuery 7 │ 358.17 / 359.78 ±2.29 / 364.32 ms │ 355.80 / 357.25 ±1.98 / 361.15 ms │ no change │
│ QQuery 8 │ 122.73 / 124.13 ±0.94 / 125.54 ms │ 122.32 / 123.41 ±0.83 / 124.48 ms │ no change │
│ QQuery 9 │ 110.89 / 115.60 ±2.91 / 118.37 ms │ 111.52 / 114.23 ±2.49 / 117.30 ms │ no change │
│ QQuery 10 │ 114.94 / 115.74 ±0.78 / 117.16 ms │ 113.12 / 114.30 ±1.09 / 116.09 ms │ no change │
│ QQuery 11 │ 908.21 / 919.94 ±6.53 / 925.41 ms │ 906.53 / 921.33 ±9.02 / 931.30 ms │ no change │
│ QQuery 12 │ 47.36 / 48.98 ±1.03 / 50.26 ms │ 48.11 / 49.23 ±1.37 / 51.51 ms │ no change │
│ QQuery 13 │ 406.79 / 408.17 ±0.73 / 408.70 ms │ 403.11 / 405.15 ±1.78 / 407.76 ms │ no change │
│ QQuery 14 │ 1082.29 / 1088.10 ±4.16 / 1094.13 ms │ 1083.65 / 1087.81 ±3.83 / 1094.61 ms │ no change │
│ QQuery 15 │ 17.72 / 18.90 ±0.86 / 20.22 ms │ 17.78 / 18.99 ±1.07 / 20.87 ms │ no change │
│ QQuery 16 │ 44.75 / 46.02 ±0.89 / 47.35 ms │ 44.52 / 45.29 ±0.51 / 45.97 ms │ no change │
│ QQuery 17 │ 248.48 / 249.63 ±0.97 / 251.28 ms │ 245.35 / 247.50 ±1.84 / 250.81 ms │ no change │
│ QQuery 18 │ 131.24 / 133.64 ±1.21 / 134.39 ms │ 131.37 / 132.41 ±0.93 / 133.81 ms │ no change │
│ QQuery 19 │ 161.63 / 163.65 ±1.56 / 166.30 ms │ 161.11 / 163.78 ±2.08 / 166.70 ms │ no change │
│ QQuery 20 │ 16.02 / 16.55 ±0.60 / 17.56 ms │ 15.24 / 16.15 ±1.07 / 17.81 ms │ no change │
│ QQuery 21 │ 23.49 / 24.17 ±0.48 / 24.71 ms │ 22.82 / 23.34 ±0.37 / 23.82 ms │ no change │
│ QQuery 22 │ 515.13 / 523.61 ±11.63 / 546.50 ms │ 520.57 / 525.55 ±5.05 / 532.80 ms │ no change │
│ QQuery 23 │ 931.07 / 941.40 ±5.38 / 946.69 ms │ 938.02 / 949.66 ±7.24 / 959.97 ms │ no change │
│ QQuery 24 │ 427.17 / 432.11 ±4.40 / 440.32 ms │ 431.64 / 433.75 ±1.69 / 435.89 ms │ no change │
│ QQuery 25 │ 362.07 / 365.26 ±2.72 / 370.25 ms │ 363.81 / 364.92 ±1.12 / 366.95 ms │ no change │
│ QQuery 26 │ 84.40 / 86.95 ±1.44 / 88.63 ms │ 84.51 / 85.25 ±0.64 / 86.30 ms │ no change │
│ QQuery 27 │ 349.53 / 351.67 ±2.29 / 355.35 ms │ 347.51 / 352.90 ±3.47 / 358.35 ms │ no change │
│ QQuery 28 │ 154.19 / 156.09 ±1.04 / 157.38 ms │ 152.72 / 153.41 ±0.55 / 153.97 ms │ no change │
│ QQuery 29 │ 307.10 / 308.86 ±1.54 / 311.68 ms │ 306.27 / 309.08 ±1.73 / 311.32 ms │ no change │
│ QQuery 30 │ 47.94 / 48.26 ±0.26 / 48.56 ms │ 47.36 / 49.99 ±2.07 / 51.75 ms │ no change │
│ QQuery 31 │ 184.03 / 185.44 ±1.22 / 186.85 ms │ 183.09 / 184.88 ±1.88 / 188.32 ms │ no change │
│ QQuery 32 │ 61.70 / 62.40 ±0.42 / 62.83 ms │ 61.69 / 62.28 ±0.52 / 62.95 ms │ no change │
│ QQuery 33 │ 149.52 / 152.39 ±2.71 / 156.31 ms │ 148.79 / 151.90 ±1.74 / 154.16 ms │ no change │
│ QQuery 34 │ 110.92 / 111.77 ±0.70 / 112.77 ms │ 110.19 / 110.86 ±0.40 / 111.34 ms │ no change │
│ QQuery 35 │ 116.39 / 118.86 ±1.68 / 120.76 ms │ 115.15 / 116.23 ±1.00 / 117.78 ms │ no change │
│ QQuery 36 │ 217.59 / 224.10 ±4.19 / 229.39 ms │ 222.78 / 225.04 ±1.99 / 228.08 ms │ no change │
│ QQuery 37 │ 183.60 / 186.23 ±1.90 / 188.44 ms │ 186.54 / 188.91 ±2.17 / 192.31 ms │ no change │
│ QQuery 38 │ 91.01 / 93.53 ±2.17 / 97.23 ms │ 89.43 / 94.52 ±3.22 / 98.27 ms │ no change │
│ QQuery 39 │ 136.93 / 140.10 ±3.06 / 145.86 ms │ 136.80 / 138.44 ±0.94 / 139.55 ms │ no change │
│ QQuery 40 │ 113.82 / 122.29 ±5.46 / 130.82 ms │ 117.88 / 122.77 ±4.73 / 131.55 ms │ no change │
│ QQuery 41 │ 17.58 / 18.62 ±0.71 / 19.59 ms │ 17.21 / 18.50 ±1.32 / 20.83 ms │ no change │
│ QQuery 42 │ 110.77 / 112.90 ±1.31 / 114.88 ms │ 112.01 / 113.26 ±0.83 / 114.43 ms │ no change │
│ QQuery 43 │ 87.00 / 88.42 ±1.07 / 89.98 ms │ 87.13 / 88.73 ±1.49 / 90.72 ms │ no change │
│ QQuery 44 │ 17.05 / 17.84 ±1.04 / 19.88 ms │ 16.19 / 16.81 ±0.32 / 17.05 ms │ +1.06x faster │
│ QQuery 45 │ 55.77 / 56.84 ±1.05 / 58.37 ms │ 54.63 / 55.98 ±0.87 / 56.96 ms │ no change │
│ QQuery 46 │ 234.36 / 238.05 ±3.37 / 242.52 ms │ 237.67 / 238.65 ±0.88 / 239.96 ms │ no change │
│ QQuery 47 │ 725.67 / 728.18 ±2.95 / 732.40 ms │ 729.55 / 734.38 ±4.12 / 740.89 ms │ no change │
│ QQuery 48 │ 283.95 / 294.13 ±7.06 / 305.30 ms │ 289.76 / 295.46 ±3.59 / 300.29 ms │ no change │
│ QQuery 49 │ 264.42 / 266.17 ±1.62 / 269.16 ms │ 263.49 / 265.43 ±2.22 / 269.65 ms │ no change │
│ QQuery 50 │ 233.79 / 236.66 ±2.09 / 239.18 ms │ 237.55 / 243.05 ±4.51 / 248.77 ms │ no change │
│ QQuery 51 │ 187.08 / 190.23 ±1.95 / 193.23 ms │ 189.10 / 193.35 ±2.69 / 196.45 ms │ no change │
│ QQuery 52 │ 112.38 / 114.07 ±0.98 / 114.89 ms │ 111.92 / 113.01 ±0.87 / 114.02 ms │ no change │
│ QQuery 53 │ 107.33 / 108.94 ±0.98 / 110.43 ms │ 107.41 / 109.40 ±1.21 / 110.68 ms │ no change │
│ QQuery 54 │ 155.14 / 156.03 ±0.66 / 157.13 ms │ 153.48 / 155.69 ±1.57 / 157.76 ms │ no change │
│ QQuery 55 │ 110.50 / 111.63 ±1.08 / 113.48 ms │ 111.48 / 112.00 ±0.30 / 112.40 ms │ no change │
│ QQuery 56 │ 151.98 / 152.71 ±0.79 / 154.17 ms │ 150.25 / 151.54 ±1.31 / 153.86 ms │ no change │
│ QQuery 57 │ 190.68 / 191.02 ±0.19 / 191.27 ms │ 186.89 / 189.11 ±1.61 / 191.24 ms │ no change │
│ QQuery 58 │ 304.08 / 311.88 ±4.96 / 318.63 ms │ 307.85 / 318.14 ±5.33 / 323.42 ms │ no change │
│ QQuery 59 │ 209.98 / 211.61 ±1.78 / 214.99 ms │ 208.76 / 210.87 ±3.20 / 217.20 ms │ no change │
│ QQuery 60 │ 152.58 / 155.33 ±1.66 / 157.40 ms │ 152.11 / 154.78 ±1.86 / 156.76 ms │ no change │
│ QQuery 61 │ 178.78 / 179.79 ±0.74 / 180.78 ms │ 177.69 / 179.68 ±1.37 / 181.21 ms │ no change │
│ QQuery 62 │ 885.24 / 928.10 ±46.51 / 1012.95 ms │ 900.11 / 932.39 ±39.76 / 1009.34 ms │ no change │
│ QQuery 63 │ 110.03 / 113.70 ±2.40 / 116.58 ms │ 110.52 / 113.24 ±2.08 / 116.12 ms │ no change │
│ QQuery 64 │ 722.12 / 727.27 ±3.21 / 730.97 ms │ 711.34 / 716.26 ±4.25 / 722.13 ms │ no change │
│ QQuery 65 │ 262.27 / 265.46 ±2.00 / 268.53 ms │ 259.89 / 265.53 ±4.80 / 273.97 ms │ no change │
│ QQuery 66 │ 258.04 / 266.19 ±7.97 / 281.22 ms │ 255.58 / 269.02 ±12.21 / 291.41 ms │ no change │
│ QQuery 67 │ 341.26 / 346.04 ±4.48 / 352.18 ms │ 336.36 / 344.09 ±5.26 / 351.63 ms │ no change │
│ QQuery 68 │ 282.49 / 288.97 ±5.61 / 297.63 ms │ 284.34 / 288.95 ±3.90 / 294.76 ms │ no change │
│ QQuery 69 │ 114.30 / 115.40 ±0.89 / 116.33 ms │ 111.23 / 113.53 ±1.59 / 115.69 ms │ no change │
│ QQuery 70 │ 345.53 / 360.51 ±9.29 / 372.38 ms │ 350.97 / 364.26 ±8.53 / 372.54 ms │ no change │
│ QQuery 71 │ 140.67 / 142.16 ±1.77 / 145.37 ms │ 138.52 / 141.65 ±3.01 / 147.35 ms │ no change │
│ QQuery 72 │ 705.59 / 725.89 ±14.72 / 740.39 ms │ 729.35 / 740.17 ±8.44 / 751.99 ms │ no change │
│ QQuery 73 │ 106.98 / 109.49 ±2.01 / 111.99 ms │ 105.68 / 107.63 ±1.64 / 110.55 ms │ no change │
│ QQuery 74 │ 576.11 / 578.90 ±1.86 / 581.17 ms │ 576.92 / 583.50 ±4.37 / 589.30 ms │ no change │
│ QQuery 75 │ 290.50 / 293.57 ±1.54 / 294.63 ms │ 288.11 / 293.57 ±3.41 / 297.17 ms │ no change │
│ QQuery 76 │ 138.14 / 139.28 ±1.07 / 141.30 ms │ 137.44 / 139.42 ±1.24 / 141.01 ms │ no change │
│ QQuery 77 │ 202.19 / 204.47 ±1.34 / 206.12 ms │ 201.07 / 202.87 ±1.30 / 204.86 ms │ no change │
│ QQuery 78 │ 358.71 / 363.10 ±2.45 / 365.77 ms │ 365.39 / 367.79 ±1.41 / 369.36 ms │ no change │
│ QQuery 79 │ 235.68 / 238.33 ±2.65 / 242.86 ms │ 234.40 / 238.55 ±2.51 / 242.18 ms │ no change │
│ QQuery 80 │ 338.07 / 341.66 ±2.06 / 343.78 ms │ 338.99 / 343.01 ±3.15 / 346.72 ms │ no change │
│ QQuery 81 │ 30.87 / 31.48 ±0.76 / 32.95 ms │ 30.49 / 31.78 ±1.46 / 34.60 ms │ no change │
│ QQuery 82 │ 207.13 / 208.80 ±1.50 / 210.66 ms │ 208.80 / 210.40 ±1.54 / 213.25 ms │ no change │
│ QQuery 83 │ 46.24 / 47.57 ±0.87 / 48.58 ms │ 46.20 / 47.90 ±1.31 / 49.78 ms │ no change │
│ QQuery 84 │ 51.55 / 52.97 ±1.54 / 55.69 ms │ 50.86 / 51.78 ±0.50 / 52.32 ms │ no change │
│ QQuery 85 │ 153.03 / 154.07 ±1.28 / 156.58 ms │ 152.31 / 154.35 ±1.17 / 155.38 ms │ no change │
│ QQuery 86 │ 40.20 / 41.50 ±0.88 / 42.71 ms │ 40.93 / 42.14 ±0.87 / 43.18 ms │ no change │
│ QQuery 87 │ 95.23 / 96.94 ±2.22 / 101.17 ms │ 92.65 / 95.06 ±1.67 / 97.75 ms │ no change │
│ QQuery 88 │ 112.86 / 114.33 ±1.04 / 115.84 ms │ 111.69 / 113.12 ±1.31 / 115.41 ms │ no change │
│ QQuery 89 │ 125.16 / 126.08 ±0.67 / 127.09 ms │ 125.35 / 127.03 ±1.14 / 128.52 ms │ no change │
│ QQuery 90 │ 28.87 / 29.88 ±1.52 / 32.90 ms │ 27.96 / 28.88 ±1.14 / 31.03 ms │ no change │
│ QQuery 91 │ 65.12 / 66.94 ±1.07 / 68.18 ms │ 65.93 / 66.50 ±0.63 / 67.60 ms │ no change │
│ QQuery 92 │ 61.59 / 62.60 ±1.09 / 64.39 ms │ 60.95 / 62.19 ±0.91 / 63.68 ms │ no change │
│ QQuery 93 │ 194.87 / 196.21 ±0.90 / 197.52 ms │ 194.99 / 198.08 ±2.19 / 201.09 ms │ no change │
│ QQuery 94 │ 65.37 / 67.72 ±1.66 / 69.45 ms │ 64.29 / 66.23 ±1.31 / 68.25 ms │ no change │
│ QQuery 95 │ 142.26 / 143.73 ±1.33 / 146.10 ms │ 142.03 / 144.07 ±1.26 / 145.69 ms │ no change │
│ QQuery 96 │ 78.53 / 79.84 ±1.10 / 81.84 ms │ 79.55 / 80.24 ±0.49 / 80.93 ms │ no change │
│ QQuery 97 │ 134.95 / 136.84 ±1.44 / 139.03 ms │ 135.16 / 136.32 ±0.70 / 137.09 ms │ no change │
│ QQuery 98 │ 154.72 / 156.90 ±1.75 / 159.05 ms │ 155.80 / 157.77 ±1.81 / 160.32 ms │ no change │
│ QQuery 99 │ 10724.16 / 10749.91 ±15.78 / 10773.74 ms │ 10735.18 / 10761.98 ±31.18 / 10816.01 ms │ no change │
└───────────┴──────────────────────────────────────────┴──────────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 34367.94ms │
│ Total Time (batched-accumulator-storage) │ 34419.02ms │
│ Average Time (HEAD) │ 347.15ms │
│ Average Time (batched-accumulator-storage) │ 347.67ms │
│ Queries Faster │ 1 │
│ Queries Slower │ 0 │
│ Queries with No Change │ 98 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴────────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpcds — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 172.2s |
| Peak memory | 5.9 GiB |
| Avg memory | 4.7 GiB |
| CPU user | 273.0s |
| CPU sys | 20.5s |
| Disk read | 0 B |
| Disk write | 572.4 MiB |
**tpcds — branch**
| Metric | Value |
|--------|-------|
| Wall time | 172.4s |
| Peak memory | 5.7 GiB |
| Avg memory | 4.6 GiB |
| CPU user | 273.2s |
| CPU sys | 21.1s |
| Disk read | 0 B |
| Disk write | 144.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068472642
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068451493)
`Linux bench-c4068451493-315-rkdm4 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (771c89be60f89b801f332320553062971c8e58e9) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..771c89be60f89b801f332320553062971c8e58e9) using: clickbench_partitioned
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068927343
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068907576)
`Linux bench-c4068907576-330-j4gj2 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (439ee1973b4d1c0863c9c10050ea744066a89b96) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..439ee1973b4d1c0863c9c10050ea744066a89b96) using: clickbench_partitioned
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068619157
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068451493)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark tpcds_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1 │ 50.90 / 51.63 ±0.59 / 52.36 ms │ 51.65 / 52.32 ±0.69 / 53.57 ms │ no change │
│ QQuery 2 │ 156.74 / 158.32 ±0.80 / 158.86 ms │ 155.60 / 156.78 ±1.11 / 158.64 ms │ no change │
│ QQuery 3 │ 120.30 / 121.21 ±0.47 / 121.58 ms │ 122.00 / 122.64 ±0.45 / 123.31 ms │ no change │
│ QQuery 4 │ 1475.39 / 1498.02 ±16.81 / 1517.50 ms │ 1481.94 / 1509.33 ±19.68 / 1539.26 ms │ no change │
│ QQuery 5 │ 187.62 / 190.51 ±1.90 / 192.67 ms │ 190.20 / 191.45 ±1.29 / 193.71 ms │ no change │
│ QQuery 6 │ 1032.61 / 1081.13 ±39.58 / 1132.49 ms │ 1039.61 / 1092.34 ±32.82 / 1129.49 ms │ no change │
│ QQuery 7 │ 363.38 / 370.19 ±5.03 / 378.79 ms │ 362.71 / 366.97 ±4.08 / 374.74 ms │ no change │
│ QQuery 8 │ 126.09 / 127.57 ±1.23 / 129.36 ms │ 126.53 / 127.16 ±0.43 / 127.73 ms │ no change │
│ QQuery 9 │ 114.47 / 118.01 ±2.41 / 120.51 ms │ 114.88 / 117.68 ±2.25 / 120.13 ms │ no change │
│ QQuery 10 │ 117.33 / 119.79 ±1.51 / 121.94 ms │ 118.33 / 118.97 ±0.86 / 120.53 ms │ no change │
│ QQuery 11 │ 1065.05 / 1084.29 ±16.22 / 1103.58 ms │ 1068.23 / 1074.38 ±4.74 / 1079.11 ms │ no change │
│ QQuery 12 │ 49.06 / 50.92 ±1.51 / 53.18 ms │ 49.91 / 51.66 ±1.31 / 53.69 ms │ no change │
│ QQuery 13 │ 423.66 / 428.14 ±3.93 / 433.79 ms │ 423.40 / 424.90 ±0.99 / 426.44 ms │ no change │
│ QQuery 14 │ 1112.45 / 1123.39 ±7.94 / 1135.78 ms │ 1118.42 / 1131.95 ±12.82 / 1153.88 ms │ no change │
│ QQuery 15 │ 18.92 / 19.88 ±0.72 / 20.70 ms │ 19.09 / 19.85 ±0.90 / 21.49 ms │ no change │
│ QQuery 16 │ 46.78 / 47.90 ±1.13 / 49.90 ms │ 47.67 / 48.26 ±0.42 / 48.81 ms │ no change │
│ QQuery 17 │ 259.64 / 263.64 ±2.97 / 266.90 ms │ 261.93 / 262.90 ±0.73 / 263.73 ms │ no change │
│ QQuery 18 │ 137.60 / 138.89 ±1.32 / 141.43 ms │ 138.20 / 139.23 ±0.89 / 140.43 ms │ no change │
│ QQuery 19 │ 167.94 / 169.04 ±0.74 / 170.17 ms │ 173.50 / 174.80 ±1.09 / 176.79 ms │ no change │
│ QQuery 20 │ 16.92 / 17.23 ±0.20 / 17.54 ms │ 16.72 / 17.50 ±0.54 / 18.24 ms │ no change │
│ QQuery 21 │ 24.84 / 25.64 ±0.51 / 26.42 ms │ 25.24 / 25.90 ±0.39 / 26.39 ms │ no change │
│ QQuery 22 │ 541.04 / 549.70 ±7.43 / 559.55 ms │ 547.86 / 559.92 ±9.90 / 574.79 ms │ no change │
│ QQuery 23 │ 1002.35 / 1017.21 ±9.58 / 1028.98 ms │ 1023.69 / 1037.04 ±7.37 / 1045.35 ms │ no change │
│ QQuery 24 │ 458.11 / 459.91 ±1.02 / 461.07 ms │ 447.38 / 451.55 ±2.33 / 454.49 ms │ no change │
│ QQuery 25 │ 383.05 / 384.03 ±0.76 / 384.97 ms │ 374.28 / 376.98 ±2.13 / 379.92 ms │ no change │
│ QQuery 26 │ 88.47 / 90.92 ±1.62 / 93.25 ms │ 86.85 / 88.59 ±1.03 / 89.77 ms │ no change │
│ QQuery 27 │ 364.56 / 374.01 ±4.91 / 378.43 ms │ 361.11 / 365.45 ±2.46 / 368.74 ms │ no change │
│ QQuery 28 │ 158.77 / 160.09 ±1.14 / 162.02 ms │ 156.10 / 157.98 ±1.61 / 160.59 ms │ no change │
│ QQuery 29 │ 325.52 / 330.34 ±2.58 / 332.83 ms │ 319.38 / 320.73 ±1.19 / 322.64 ms │ no change │
│ QQuery 30 │ 50.82 / 52.18 ±1.53 / 54.62 ms │ 51.01 / 52.19 ±0.66 / 52.84 ms │ no change │
│ QQuery 31 │ 189.68 / 191.78 ±1.12 / 192.84 ms │ 191.04 / 192.02 ±1.01 / 193.67 ms │ no change │
│ QQuery 32 │ 64.05 / 65.48 ±1.07 / 67.19 ms │ 63.93 / 65.43 ±1.16 / 67.37 ms │ no change │
│ QQuery 33 │ 156.63 / 159.31 ±1.38 / 160.39 ms │ 154.51 / 155.99 ±1.27 / 158.24 ms │ no change │
│ QQuery 34 │ 115.67 / 117.81 ±1.70 / 120.58 ms │ 115.09 / 117.21 ±1.12 / 118.14 ms │ no change │
│ QQuery 35 │ 117.61 / 120.80 ±2.76 / 125.19 ms │ 120.40 / 121.94 ±1.01 / 123.31 ms │ no change │
│ QQuery 36 │ 231.94 / 235.93 ±2.73 / 238.73 ms │ 221.96 / 228.08 ±5.33 / 237.12 ms │ no change │
│ QQuery 37 │ 187.85 / 190.07 ±2.52 / 194.70 ms │ 187.26 / 190.11 ±2.41 / 194.50 ms │ no change │
│ QQuery 38 │ 96.37 / 97.97 ±1.29 / 99.95 ms │ 97.67 / 101.00 ±3.26 / 106.66 ms │ no change │
│ QQuery 39 │ 143.95 / 147.93 ±3.00 / 153.15 ms │ 145.07 / 148.47 ±3.03 / 152.18 ms │ no change │
│ QQuery 40 │ 123.93 / 129.45 ±6.47 / 141.35 ms │ 123.67 / 128.79 ±5.48 / 139.41 ms │ no change │
│ QQuery 41 │ 18.78 / 19.50 ±0.70 / 20.83 ms │ 18.67 / 19.77 ±0.69 / 20.70 ms │ no change │
│ QQuery 42 │ 114.02 / 115.03 ±1.04 / 116.53 ms │ 115.52 / 118.23 ±1.47 / 119.77 ms │ no change │
│ QQuery 43 │ 89.03 / 89.75 ±0.66 / 90.88 ms │ 91.07 / 92.38 ±0.98 / 93.67 ms │ no change │
│ QQuery 44 │ 17.64 / 18.49 ±0.72 / 19.73 ms │ 17.89 / 18.84 ±0.78 / 20.17 ms │ no change │
│ QQuery 45 │ 57.55 / 58.86 ±0.98 / 60.58 ms │ 56.97 / 57.95 ±0.96 / 59.64 ms │ no change │
│ QQuery 46 │ 251.13 / 254.26 ±1.63 / 255.53 ms │ 252.41 / 254.65 ±1.16 / 255.62 ms │ no change │
│ QQuery 47 │ 810.20 / 818.07 ±6.60 / 826.68 ms │ 823.71 / 831.40 ±4.25 / 835.32 ms │ no change │
│ QQuery 48 │ 290.94 / 299.48 ±5.15 / 306.63 ms │ 293.57 / 302.97 ±5.40 / 309.33 ms │ no change │
│ QQuery 49 │ 267.16 / 271.16 ±3.58 / 276.69 ms │ 269.86 / 271.58 ±1.61 / 274.11 ms │ no change │
│ QQuery 50 │ 246.26 / 254.62 ±4.77 / 261.00 ms │ 252.25 / 257.57 ±4.09 / 264.53 ms │ no change │
│ QQuery 51 │ 195.32 / 196.21 ±0.60 / 197.06 ms │ 195.35 / 200.29 ±3.71 / 205.64 ms │ no change │
│ QQuery 52 │ 115.84 / 117.49 ±1.27 / 119.50 ms │ 115.09 / 117.77 ±1.94 / 121.06 ms │ no change │
│ QQuery 53 │ 109.99 / 112.12 ±1.56 / 114.15 ms │ 110.89 / 112.39 ±1.31 / 114.41 ms │ no change │
│ QQuery 54 │ 158.64 / 160.14 ±1.37 / 162.52 ms │ 160.72 / 161.42 ±1.00 / 163.37 ms │ no change │
│ QQuery 55 │ 113.52 / 115.40 ±1.60 / 118.19 ms │ 114.57 / 116.44 ±1.22 / 118.03 ms │ no change │
│ QQuery 56 │ 154.10 / 154.82 ±0.62 / 155.89 ms │ 157.36 / 158.68 ±1.58 / 160.82 ms │ no change │
│ QQuery 57 │ 196.24 / 198.43 ±1.33 / 200.18 ms │ 193.51 / 197.21 ±2.13 / 199.70 ms │ no change │
│ QQuery 58 │ 307.79 / 319.80 ±10.05 / 333.16 ms │ 328.56 / 337.31 ±5.63 / 342.44 ms │ 1.05x slower │
│ QQuery 59 │ 214.49 / 215.96 ±1.07 / 217.50 ms │ 216.88 / 218.28 ±0.95 / 219.48 ms │ no change │
│ QQuery 60 │ 157.88 / 159.37 ±1.59 / 162.33 ms │ 159.01 / 161.22 ±1.89 / 163.54 ms │ no change │
│ QQuery 61 │ 185.03 / 186.24 ±1.31 / 188.68 ms │ 184.95 / 186.87 ±1.52 / 189.01 ms │ no change │
│ QQuery 62 │ 943.21 / 981.45 ±39.76 / 1056.89 ms │ 948.45 / 982.10 ±26.70 / 1015.79 ms │ no change │
│ QQuery 63 │ 112.20 / 115.52 ±1.77 / 117.36 ms │ 111.91 / 115.45 ±4.70 / 124.72 ms │ no change │
│ QQuery 64 │ 741.19 / 759.15 ±9.76 / 770.89 ms │ 742.04 / 750.16 ±8.66 / 762.93 ms │ no change │
│ QQuery 65 │ 284.62 / 291.48 ±3.77 / 295.02 ms │ 284.94 / 292.86 ±5.30 / 300.18 ms │ no change │
│ QQuery 66 │ 250.62 / 270.36 ±14.52 / 292.96 ms │ 264.69 / 274.59 ±7.09 / 284.81 ms │ no change │
│ QQuery 67 │ 362.86 / 367.04 ±2.86 / 371.08 ms │ 354.94 / 371.15 ±8.40 / 378.11 ms │ no change │
│ QQuery 68 │ 300.73 / 307.56 ±4.42 / 314.33 ms │ 299.97 / 305.74 ±3.74 / 310.66 ms │ no change │
│ QQuery 69 │ 117.12 / 119.40 ±1.87 / 122.56 ms │ 117.62 / 118.49 ±0.47 / 119.02 ms │ no change │
│ QQuery 70 │ 362.99 / 374.47 ±11.15 / 395.64 ms │ 353.25 / 369.43 ±15.43 / 395.69 ms │ no change │
│ QQuery 71 │ 143.25 / 146.76 ±2.38 / 150.32 ms │ 143.81 / 146.47 ±1.98 / 149.39 ms │ no change │
│ QQuery 72 │ 754.77 / 771.36 ±12.22 / 785.52 ms │ 759.07 / 771.81 ±10.51 / 790.43 ms │ no change │
│ QQuery 73 │ 111.19 / 114.10 ±1.90 / 116.66 ms │ 113.20 / 115.25 ±1.34 / 116.85 ms │ no change │
│ QQuery 74 │ 704.05 / 706.59 ±2.75 / 711.62 ms │ 686.68 / 700.86 ±9.75 / 711.60 ms │ no change │
│ QQuery 75 │ 299.05 / 302.18 ±2.40 / 305.72 ms │ 300.81 / 302.12 ±1.14 / 303.65 ms │ no change │
│ QQuery 76 │ 141.84 / 143.51 ±1.75 / 146.77 ms │ 140.46 / 144.87 ±2.38 / 147.24 ms │ no change │
│ QQuery 77 │ 207.44 / 208.27 ±0.77 / 209.65 ms │ 207.22 / 208.90 ±1.28 / 210.60 ms │ no change │
│ QQuery 78 │ 375.85 / 381.56 ±4.20 / 388.75 ms │ 380.61 / 382.62 ±1.43 / 384.45 ms │ no change │
│ QQuery 79 │ 256.44 / 260.32 ±2.38 / 262.81 ms │ 261.45 / 264.30 ±1.96 / 266.44 ms │ no change │
│ QQuery 80 │ 347.58 / 348.71 ±1.09 / 350.06 ms │ 352.64 / 353.60 ±0.62 / 354.57 ms │ no change │
│ QQuery 81 │ 32.93 / 33.72 ±0.73 / 34.78 ms │ 33.93 / 34.87 ±0.51 / 35.46 ms │ no change │
│ QQuery 82 │ 210.33 / 212.81 ±1.48 / 214.57 ms │ 211.87 / 214.61 ±2.65 / 218.19 ms │ no change │
│ QQuery 83 │ 48.08 / 49.55 ±0.93 / 50.55 ms │ 49.84 / 50.72 ±0.94 / 52.10 ms │ no change │
│ QQuery 84 │ 53.26 / 54.37 ±1.32 / 56.96 ms │ 54.07 / 55.18 ±0.65 / 55.97 ms │ no change │
│ QQuery 85 │ 153.88 / 157.22 ±1.69 / 158.43 ms │ 157.82 / 161.41 ±1.98 / 163.56 ms │ no change │
│ QQuery 86 │ 41.97 / 43.92 ±1.18 / 45.60 ms │ 43.36 / 44.11 ±0.52 / 44.90 ms │ no change │
│ QQuery 87 │ 95.00 / 99.27 ±3.07 / 104.36 ms │ 97.71 / 104.64 ±4.41 / 110.36 ms │ 1.05x slower │
│ QQuery 88 │ 115.73 / 116.52 ±0.62 / 117.13 ms │ 118.56 / 119.99 ±1.01 / 121.69 ms │ no change │
│ QQuery 89 │ 125.41 / 127.46 ±1.91 / 130.65 ms │ 129.55 / 132.39 ±1.70 / 134.25 ms │ no change │
│ QQuery 90 │ 29.69 / 29.99 ±0.26 / 30.47 ms │ 29.96 / 30.54 ±0.38 / 31.16 ms │ no change │
│ QQuery 91 │ 66.81 / 69.17 ±1.95 / 71.43 ms │ 68.35 / 70.09 ±1.73 / 72.79 ms │ no change │
│ QQuery 92 │ 64.82 / 66.15 ±1.09 / 68.08 ms │ 64.65 / 65.74 ±0.69 / 66.71 ms │ no change │
│ QQuery 93 │ 201.96 / 206.09 ±2.51 / 208.95 ms │ 206.50 / 207.84 ±1.06 / 209.62 ms │ no change │
│ QQuery 94 │ 67.75 / 68.36 ±0.55 / 69.38 ms │ 68.72 / 70.13 ±0.93 / 71.13 ms │ no change │
│ QQuery 95 │ 143.13 / 147.45 ±3.01 / 152.24 ms │ 145.29 / 148.10 ±2.73 / 152.82 ms │ no change │
│ QQuery 96 │ 76.61 / 80.88 ±2.17 / 82.41 ms │ 83.08 / 84.68 ±1.45 / 87.08 ms │ no change │
│ QQuery 97 │ 138.88 / 140.49 ±1.54 / 142.83 ms │ 140.15 / 142.11 ±1.86 / 145.57 ms │ no change │
│ QQuery 98 │ 160.66 / 162.50 ±1.05 / 163.93 ms │ 163.94 / 167.09 ±2.00 / 170.18 ms │ no change │
│ QQuery 99 │ 10902.78 / 10942.06 ±35.59 / 10986.07 ms │ 10917.57 / 10965.10 ±32.38 / 11010.40 ms │ no change │
└───────────┴──────────────────────────────────────────┴──────────────────────────────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 35993.24ms │
│ Total Time (batched-accumulator-storage) │ 36119.78ms │
│ Average Time (HEAD) │ 363.57ms │
│ Average Time (batched-accumulator-storage) │ 364.85ms │
│ Queries Faster │ 0 │
│ Queries Slower │ 2 │
│ Queries with No Change │ 97 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴────────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpcds — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 180.3s |
| Peak memory | 5.5 GiB |
| Avg memory | 4.6 GiB |
| CPU user | 286.4s |
| CPU sys | 21.6s |
| Disk read | 0 B |
| Disk write | 640.4 MiB |
**tpcds — branch**
| Metric | Value |
|--------|-------|
| Wall time | 180.9s |
| Peak memory | 5.6 GiB |
| Avg memory | 4.6 GiB |
| CPU user | 287.8s |
| CPU sys | 22.6s |
| Disk read | 0 B |
| Disk write | 788.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068474246
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068451493)
`Linux bench-c4068451493-317-xl792 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (771c89be60f89b801f332320553062971c8e58e9) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..771c89be60f89b801f332320553062971c8e58e9) using: tpch
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068698039
run benchmarks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4069194458
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4069055822)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 981.84 / 998.87 ±12.71 / 1017.97 ms │ 817.79 / 927.62 ±82.24 / 998.61 ms │ +1.08x faster │
│ QQuery 1 │ 227.76 / 229.51 ±1.79 / 232.18 ms │ 223.91 / 225.52 ±1.15 / 227.47 ms │ no change │
│ QQuery 2 │ 530.41 / 536.14 ±3.78 / 539.98 ms │ 527.88 / 531.60 ±3.83 / 538.43 ms │ no change │
│ QQuery 3 │ 330.66 / 334.49 ±3.02 / 339.01 ms │ 340.56 / 342.45 ±1.08 / 343.62 ms │ no change │
│ QQuery 4 │ 673.42 / 711.29 ±30.78 / 749.66 ms │ 696.84 / 706.37 ±6.21 / 714.41 ms │ no change │
│ QQuery 5 │ 9797.86 / 10168.58 ±211.62 / 10425.24 ms │ 9829.24 / 10227.51 ±257.98 / 10484.92 ms │ no change │
│ QQuery 6 │ 995.49 / 1025.85 ±24.03 / 1064.86 ms │ 987.39 / 1000.20 ±19.17 / 1038.36 ms │ no change │
│ QQuery 7 │ 821.59 / 866.99 ±22.84 / 883.06 ms │ 908.95 / 939.46 ±17.10 / 958.59 ms │ 1.08x slower │
└──────────┴──────────────────────────────────────────┴──────────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 14871.73ms │
│ Total Time (batched-accumulator-storage) │ 14900.74ms │
│ Average Time (HEAD) │ 1858.97ms │
│ Average Time (batched-accumulator-storage) │ 1862.59ms │
│ Queries Faster │ 1 │
│ Queries Slower │ 1 │
│ Queries with No Change │ 6 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴────────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**clickbench_extended — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 75.0s |
| Peak memory | 32.4 GiB |
| Avg memory | 27.6 GiB |
| CPU user | 737.1s |
| CPU sys | 24.9s |
| Disk read | 0 B |
| Disk write | 22.5 MiB |
**clickbench_extended — branch**
| Metric | Value |
|--------|-------|
| Wall time | 75.2s |
| Peak memory | 32.0 GiB |
| Avg memory | 27.6 GiB |
| CPU user | 740.9s |
| CPU sys | 24.0s |
| Disk read | 0 B |
| Disk write | 692.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068653787
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068525672)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark tpcds_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1 │ 49.43 / 49.89 ±0.47 / 50.50 ms │ 50.57 / 51.93 ±0.85 / 53.23 ms │ no change │
│ QQuery 2 │ 157.06 / 157.53 ±0.34 / 158.00 ms │ 155.98 / 156.66 ±0.59 / 157.44 ms │ no change │
│ QQuery 3 │ 119.18 / 120.28 ±1.02 / 122.18 ms │ 119.67 / 120.33 ±0.39 / 120.74 ms │ no change │
│ QQuery 4 │ 1320.48 / 1378.98 ±45.34 / 1429.81 ms │ 1362.92 / 1392.12 ±16.55 / 1408.06 ms │ no change │
│ QQuery 5 │ 185.22 / 186.01 ±0.60 / 186.76 ms │ 187.96 / 189.38 ±1.41 / 191.96 ms │ no change │
│ QQuery 6 │ 996.23 / 1015.50 ±13.06 / 1035.52 ms │ 1009.53 / 1048.72 ±32.70 / 1095.95 ms │ no change │
│ QQuery 7 │ 356.55 / 361.11 ±2.51 / 363.59 ms │ 356.92 / 362.83 ±3.54 / 367.98 ms │ no change │
│ QQuery 8 │ 122.75 / 124.69 ±1.21 / 126.26 ms │ 124.16 / 124.56 ±0.35 / 125.20 ms │ no change │
│ QQuery 9 │ 113.62 / 116.62 ±2.09 / 119.30 ms │ 116.31 / 125.57 ±9.77 / 144.53 ms │ 1.08x slower │
│ QQuery 10 │ 114.80 / 115.53 ±0.64 / 116.71 ms │ 114.24 / 116.19 ±1.14 / 117.34 ms │ no change │
│ QQuery 11 │ 916.60 / 923.89 ±9.72 / 942.74 ms │ 992.66 / 1007.47 ±9.48 / 1018.89 ms │ 1.09x slower │
│ QQuery 12 │ 46.84 / 48.76 ±1.08 / 49.95 ms │ 47.83 / 48.86 ±0.75 / 49.92 ms │ no change │
│ QQuery 13 │ 404.33 / 410.14 ±3.62 / 414.73 ms │ 410.32 / 413.53 ±2.01 / 416.10 ms │ no change │
│ QQuery 14 │ 1097.50 / 1108.16 ±8.13 / 1117.84 ms │ 1102.64 / 1108.42 ±3.87 / 1113.02 ms │ no change │
│ QQuery 15 │ 17.72 / 18.78 ±1.18 / 21.00 ms │ 17.71 / 19.81 ±1.47 / 22.26 ms │ 1.05x slower │
│ QQuery 16 │ 45.29 / 46.65 ±1.88 / 50.36 ms │ 47.04 / 47.71 ±0.70 / 49.01 ms │ no change │
│ QQuery 17 │ 246.50 / 250.09 ±2.58 / 253.66 ms │ 252.46 / 253.35 ±0.87 / 254.94 ms │ no change │
│ QQuery 18 │ 133.64 / 134.83 ±0.72 / 135.49 ms │ 135.67 / 136.60 ±0.98 / 138.38 ms │ no change │
│ QQuery 19 │ 163.34 / 165.04 ±1.36 / 167.16 ms │ 164.76 / 166.74 ±1.59 / 168.82 ms │ no change │
│ QQuery 20 │ 15.14 / 15.67 ±0.53 / 16.52 ms │ 16.72 / 17.35 ±0.49 / 18.22 ms │ 1.11x slower │
│ QQuery 21 │ 23.59 / 24.33 ±0.43 / 24.83 ms │ 24.99 / 25.26 ±0.32 / 25.83 ms │ no change │
│ QQuery 22 │ 516.84 / 519.76 ±2.66 / 523.55 ms │ 525.84 / 543.68 ±10.48 / 554.35 ms │ no change │
│ QQuery 23 │ 934.04 / 943.27 ±7.07 / 951.59 ms │ 973.71 / 976.78 ±2.42 / 980.70 ms │ no change │
│ QQuery 24 │ 431.16 / 434.68 ±1.86 / 436.06 ms │ 444.45 / 446.68 ±1.92 / 449.35 ms │ no change │
│ QQuery 25 │ 365.50 / 368.92 ±2.28 / 371.63 ms │ 366.30 / 369.99 ±3.16 / 375.87 ms │ no change │
│ QQuery 26 │ 85.63 / 88.02 ±1.76 / 90.26 ms │ 84.59 / 87.50 ±2.52 / 90.95 ms │ no change │
│ QQuery 27 │ 354.69 / 357.15 ±1.95 / 360.07 ms │ 354.54 / 357.59 ±3.63 / 364.52 ms │ no change │
│ QQuery 28 │ 153.46 / 154.48 ±0.58 / 155.10 ms │ 156.39 / 157.87 ±1.05 / 158.88 ms │ no change │
│ QQuery 29 │ 309.72 / 312.84 ±2.25 / 316.63 ms │ 310.35 / 313.17 ±2.08 / 315.12 ms │ no change │
│ QQuery 30 │ 47.05 / 50.51 ±2.14 / 53.02 ms │ 50.55 / 52.46 ±1.22 / 54.25 ms │ no change │
│ QQuery 31 │ 187.30 / 189.40 ±1.29 / 191.32 ms │ 186.61 / 188.41 ±1.57 / 190.47 ms │ no change │
│ QQuery 32 │ 64.28 / 65.58 ±0.76 / 66.63 ms │ 62.76 / 64.75 ±1.22 / 66.33 ms │ no change │
│ QQuery 33 │ 154.05 / 155.11 ±1.36 / 157.72 ms │ 154.87 / 156.28 ±0.89 / 157.64 ms │ no change │
│ QQuery 34 │ 113.49 / 114.65 ±0.72 / 115.34 ms │ 111.57 / 113.03 ±1.18 / 114.57 ms │ no change │
│ QQuery 35 │ 118.60 / 120.01 ±1.29 / 121.89 ms │ 119.45 / 120.37 ±0.81 / 121.61 ms │ no change │
│ QQuery 36 │ 226.62 / 230.21 ±3.13 / 234.78 ms │ 225.17 / 226.61 ±1.03 / 227.90 ms │ no change │
│ QQuery 37 │ 190.38 / 193.16 ±1.59 / 194.67 ms │ 190.37 / 191.82 ±0.89 / 192.92 ms │ no change │
│ QQuery 38 │ 93.78 / 96.99 ±2.61 / 100.18 ms │ 94.60 / 97.36 ±2.52 / 101.83 ms │ no change │
│ QQuery 39 │ 142.48 / 144.17 ±1.27 / 145.70 ms │ 141.42 / 144.50 ±2.30 / 146.95 ms │ no change │
│ QQuery 40 │ 118.63 / 122.07 ±4.35 / 130.61 ms │ 119.38 / 122.61 ±3.27 / 128.85 ms │ no change │
│ QQuery 41 │ 17.56 / 18.56 ±0.96 / 19.89 ms │ 18.65 / 20.52 ±1.09 / 21.67 ms │ 1.11x slower │
│ QQuery 42 │ 113.04 / 114.22 ±0.93 / 115.83 ms │ 112.51 / 114.98 ±1.51 / 117.19 ms │ no change │
│ QQuery 43 │ 88.94 / 90.36 ±0.99 / 91.73 ms │ 88.71 / 89.93 ±1.17 / 92.01 ms │ no change │
│ QQuery 44 │ 16.87 / 17.55 ±0.68 / 18.78 ms │ 19.25 / 19.46 ±0.14 / 19.64 ms │ 1.11x slower │
│ QQuery 45 │ 55.57 / 57.54 ±1.67 / 60.40 ms │ 56.58 / 58.95 ±1.75 / 61.88 ms │ no change │
│ QQuery 46 │ 239.69 / 242.37 ±1.83 / 245.17 ms │ 238.45 / 242.28 ±2.22 / 244.52 ms │ no change │
│ QQuery 47 │ 729.36 / 734.80 ±3.32 / 738.99 ms │ 767.90 / 778.30 ±6.33 / 786.62 ms │ 1.06x slower │
│ QQuery 48 │ 289.93 / 292.44 ±2.37 / 296.60 ms │ 286.32 / 292.13 ±3.45 / 296.03 ms │ no change │
│ QQuery 49 │ 264.05 / 266.49 ±2.21 / 270.55 ms │ 266.11 / 267.30 ±0.89 / 268.36 ms │ no change │
│ QQuery 50 │ 237.14 / 240.88 ±3.27 / 246.23 ms │ 235.82 / 246.37 ±7.65 / 256.37 ms │ no change │
│ QQuery 51 │ 194.74 / 196.32 ±1.26 / 197.85 ms │ 190.70 / 193.51 ±2.20 / 196.61 ms │ no change │
│ QQuery 52 │ 111.80 / 113.88 ±1.60 / 115.80 ms │ 113.13 / 114.24 ±1.16 / 116.23 ms │ no change │
│ QQuery 53 │ 108.19 / 110.01 ±1.28 / 111.97 ms │ 110.34 / 111.99 ±1.24 / 113.67 ms │ no change │
│ QQuery 54 │ 154.81 / 156.38 ±0.92 / 157.34 ms │ 156.32 / 158.65 ±1.90 / 161.18 ms │ no change │
│ QQuery 55 │ 110.87 / 112.15 ±1.12 / 114.00 ms │ 111.22 / 112.51 ±1.46 / 115.28 ms │ no change │
│ QQuery 56 │ 152.35 / 153.84 ±1.09 / 155.36 ms │ 152.62 / 153.44 ±0.54 / 154.12 ms │ no change │
│ QQuery 57 │ 192.44 / 194.76 ±1.68 / 196.79 ms │ 191.55 / 194.26 ±1.84 / 196.79 ms │ no change │
│ QQuery 58 │ 306.98 / 330.80 ±32.39 / 394.93 ms │ 310.97 / 320.14 ±6.67 / 331.39 ms │ no change │
│ QQuery 59 │ 211.34 / 213.38 ±1.19 / 214.58 ms │ 212.72 / 214.93 ±2.38 / 219.33 ms │ no change │
│ QQuery 60 │ 152.83 / 154.43 ±1.76 / 157.71 ms │ 155.11 / 156.58 ±1.11 / 158.45 ms │ no change │
│ QQuery 61 │ 179.96 / 181.29 ±1.35 / 183.69 ms │ 182.59 / 184.02 ±1.38 / 186.46 ms │ no change │
│ QQuery 62 │ 908.78 / 935.99 ±32.76 / 1000.48 ms │ 919.12 / 948.52 ±16.86 / 967.46 ms │ no change │
│ QQuery 63 │ 111.17 / 113.48 ±1.90 / 116.68 ms │ 110.42 / 114.34 ±2.30 / 117.02 ms │ no change │
│ QQuery 64 │ 716.82 / 725.76 ±6.10 / 733.76 ms │ 722.17 / 727.07 ±4.06 / 734.53 ms │ no change │
│ QQuery 65 │ 265.38 / 272.40 ±4.86 / 280.63 ms │ 263.89 / 271.28 ±6.41 / 280.21 ms │ no change │
│ QQuery 66 │ 248.83 / 262.27 ±7.61 / 270.62 ms │ 258.69 / 269.14 ±5.65 / 274.85 ms │ no change │
│ QQuery 67 │ 345.51 / 348.93 ±3.24 / 354.89 ms │ 345.45 / 348.86 ±3.72 / 355.12 ms │ no change │
│ QQuery 68 │ 284.41 / 289.28 ±3.26 / 293.75 ms │ 289.37 / 292.79 ±2.60 / 295.67 ms │ no change │
│ QQuery 69 │ 114.16 / 114.90 ±0.66 / 116.09 ms │ 113.02 / 114.71 ±1.34 / 116.93 ms │ no change │
│ QQuery 70 │ 347.47 / 357.95 ±8.15 / 372.49 ms │ 337.74 / 357.08 ±14.30 / 376.94 ms │ no change │
│ QQuery 71 │ 140.06 / 142.13 ±1.54 / 143.89 ms │ 143.13 / 144.63 ±1.18 / 146.57 ms │ no change │
│ QQuery 72 │ 704.20 / 732.84 ±16.38 / 749.77 ms │ 746.29 / 759.08 ±9.93 / 775.06 ms │ no change │
│ QQuery 73 │ 106.42 / 109.89 ±2.45 / 112.86 ms │ 107.90 / 110.87 ±1.72 / 112.96 ms │ no change │
│ QQuery 74 │ 611.03 / 627.61 ±16.70 / 648.68 ms │ 641.19 / 665.88 ±15.52 / 681.77 ms │ 1.06x slower │
│ QQuery 75 │ 295.14 / 296.36 ±1.91 / 300.18 ms │ 298.68 / 300.13 ±0.98 / 301.53 ms │ no change │
│ QQuery 76 │ 138.22 / 139.44 ±0.74 / 140.16 ms │ 140.25 / 141.73 ±1.80 / 145.07 ms │ no change │
│ QQuery 77 │ 204.84 / 205.91 ±0.97 / 207.37 ms │ 207.09 / 210.36 ±2.08 / 213.52 ms │ no change │
│ QQuery 78 │ 360.17 / 365.30 ±4.68 / 372.26 ms │ 370.72 / 376.45 ±4.64 / 381.77 ms │ no change │
│ QQuery 79 │ 246.14 / 247.41 ±0.99 / 249.19 ms │ 246.33 / 249.65 ±1.94 / 251.80 ms │ no change │
│ QQuery 80 │ 340.16 / 344.12 ±3.02 / 347.24 ms │ 346.27 / 349.68 ±2.95 / 353.98 ms │ no change │
│ QQuery 81 │ 30.42 / 32.02 ±1.35 / 34.01 ms │ 33.68 / 34.20 ±0.45 / 35.01 ms │ 1.07x slower │
│ QQuery 82 │ 210.42 / 213.23 ±1.98 / 215.71 ms │ 211.31 / 215.58 ±2.94 / 219.06 ms │ no change │
│ QQuery 83 │ 46.93 / 50.12 ±2.80 / 54.89 ms │ 50.41 / 50.82 ±0.43 / 51.58 ms │ no change │
│ QQuery 84 │ 51.64 / 52.54 ±0.56 / 53.24 ms │ 52.28 / 53.53 ±0.68 / 54.14 ms │ no change │
│ QQuery 85 │ 155.63 / 156.91 ±1.05 / 158.47 ms │ 153.60 / 156.97 ±2.38 / 160.32 ms │ no change │
│ QQuery 86 │ 41.52 / 43.20 ±1.61 / 46.16 ms │ 42.43 / 43.17 ±0.52 / 43.79 ms │ no change │
│ QQuery 87 │ 96.42 / 98.13 ±2.11 / 102.27 ms │ 97.52 / 100.12 ±2.52 / 104.51 ms │ no change │
│ QQuery 88 │ 114.18 / 115.72 ±1.14 / 117.50 ms │ 117.98 / 119.72 ±1.28 / 121.67 ms │ no change │
│ QQuery 89 │ 125.86 / 127.41 ±1.13 / 129.08 ms │ 130.01 / 130.81 ±0.79 / 132.21 ms │ no change │
│ QQuery 90 │ 29.19 / 29.79 ±0.41 / 30.24 ms │ 30.18 / 30.62 ±0.36 / 31.26 ms │ no change │
│ QQuery 91 │ 66.41 / 68.64 ±1.25 / 70.07 ms │ 65.52 / 67.05 ±0.99 / 68.13 ms │ no change │
│ QQuery 92 │ 62.79 / 63.88 ±1.68 / 67.20 ms │ 64.27 / 65.16 ±0.89 / 66.61 ms │ no change │
│ QQuery 93 │ 197.92 / 201.69 ±2.62 / 204.94 ms │ 201.79 / 204.66 ±1.66 / 206.65 ms │ no change │
│ QQuery 94 │ 66.74 / 67.44 ±0.55 / 68.12 ms │ 68.24 / 68.95 ±0.42 / 69.34 ms │ no change │
│ QQuery 95 │ 144.47 / 146.88 ±1.44 / 148.52 ms │ 147.14 / 149.16 ±1.88 / 151.42 ms │ no change │
│ QQuery 96 │ 78.00 / 80.76 ±1.48 / 82.44 ms │ 79.82 / 80.78 ±0.96 / 82.16 ms │ no change │
│ QQuery 97 │ 136.88 / 139.56 ±1.82 / 141.36 ms │ 137.58 / 143.79 ±8.71 / 161.07 ms │ no change │
│ QQuery 98 │ 156.15 / 158.97 ±1.46 / 160.30 ms │ 159.26 / 160.87 ±1.54 / 163.23 ms │ no change │
│ QQuery 99 │ 10806.55 / 10874.24 ±48.55 / 10921.17 ms │ 10821.20 / 10861.77 ±28.73 / 10910.10 ms │ no change │
└───────────┴──────────────────────────────────────────┴──────────────────────────────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 34778.99ms │
│ Total Time (batched-accumulator-storage) │ 35199.28ms │
│ Average Time (HEAD) │ 351.30ms │
│ Average Time (batched-accumulator-storage) │ 355.55ms │
│ Queries Faster │ 0 │
│ Queries Slower │ 9 │
│ Queries with No Change │ 90 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴────────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpcds — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 174.2s |
| Peak memory | 5.6 GiB |
| Avg memory | 4.6 GiB |
| CPU user | 276.1s |
| CPU sys | 21.0s |
| Disk read | 0 B |
| Disk write | 700.4 MiB |
**tpcds — branch**
| Metric | Value |
|--------|-------|
| Wall time | 176.3s |
| Peak memory | 5.6 GiB |
| Avg memory | 4.6 GiB |
| CPU user | 279.8s |
| CPU sys | 21.0s |
| Disk read | 0 B |
| Disk write | 584.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068658528
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068495691)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 1.62 / 4.88 ±6.38 / 17.64 ms │ 1.61 / 4.95 ±6.47 / 17.89 ms │ no change │
│ QQuery 1 │ 15.04 / 15.43 ±0.23 / 15.76 ms │ 14.81 / 15.33 ±0.28 / 15.60 ms │ no change │
│ QQuery 2 │ 56.40 / 56.81 ±0.45 / 57.58 ms │ 56.85 / 57.30 ±0.46 / 58.13 ms │ no change │
│ QQuery 3 │ 48.89 / 51.01 ±1.26 / 52.60 ms │ 48.88 / 51.38 ±1.33 / 52.81 ms │ no change │
│ QQuery 4 │ 310.82 / 316.31 ±4.94 / 322.23 ms │ 311.93 / 318.18 ±5.15 / 323.95 ms │ no change │
│ QQuery 5 │ 358.70 / 360.55 ±1.40 / 362.28 ms │ 358.94 / 361.79 ±2.09 / 364.78 ms │ no change │
│ QQuery 6 │ 5.51 / 6.16 ±0.68 / 7.43 ms │ 5.60 / 6.04 ±0.32 / 6.56 ms │ no change │
│ QQuery 7 │ 17.67 / 18.32 ±0.54 / 19.20 ms │ 17.34 / 21.59 ±5.31 / 31.96 ms │ 1.18x slower │
│ QQuery 8 │ 456.51 / 467.57 ±6.87 / 476.19 ms │ 450.14 / 470.50 ±17.81 / 502.97 ms │ no change │
│ QQuery 9 │ 707.27 / 710.52 ±3.77 / 717.76 ms │ 709.32 / 711.97 ±3.10 / 717.92 ms │ no change │
│ QQuery 10 │ 95.20 / 99.32 ±3.43 / 103.65 ms │ 92.13 / 97.44 ±5.35 / 107.45 ms │ no change │
│ QQuery 11 │ 108.99 / 109.72 ±0.81 / 111.23 ms │ 105.99 / 108.40 ±1.87 / 111.74 ms │ no change │
│ QQuery 12 │ 351.32 / 359.97 ±7.19 / 369.41 ms │ 351.45 / 364.34 ±9.37 / 378.82 ms │ no change │
│ QQuery 13 │ 465.59 / 477.29 ±10.02 / 493.62 ms │ 460.67 / 465.25 ±3.41 / 471.14 ms │ no change │
│ QQuery 14 │ 363.03 / 367.91 ±4.61 / 376.22 ms │ 357.98 / 363.38 ±4.16 / 369.14 ms │ no change │
│ QQuery 15 │ 366.87 / 385.00 ±15.59 / 412.91 ms │ 373.57 / 398.08 ±16.78 / 417.15 ms │ no change │
│ QQuery 16 │ 762.43 / 790.00 ±20.51 / 820.14 ms │ 762.54 / 783.59 ±20.72 / 822.02 ms │ no change │
│ QQuery 17 │ 758.06 / 766.69 ±5.24 / 771.18 ms │ 747.93 / 757.43 ±6.07 / 765.17 ms │ no change │
│ QQuery 18 │ 1472.61 / 1557.23 ±48.39 / 1603.19 ms │ 1521.13 / 1551.40 ±19.90 / 1572.61 ms │ no change │
│ QQuery 19 │ 37.25 / 45.06 ±15.26 / 75.57 ms │ 35.59 / 42.97 ±12.14 / 67.21 ms │ no change │
│ QQuery 20 │ 715.52 / 738.40 ±27.50 / 780.55 ms │ 711.97 / 722.87 ±10.98 / 736.51 ms │ no change │
│ QQuery 21 │ 762.60 / 781.96 ±23.81 / 826.37 ms │ 756.99 / 764.94 ±9.37 / 782.48 ms │ no change │
│ QQuery 22 │ 1129.34 / 1139.36 ±9.83 / 1157.02 ms │ 1132.07 / 1165.40 ±57.97 / 1281.17 ms │ no change │
│ QQuery 23 │ 3242.66 / 3251.77 ±14.70 / 3280.95 ms │ 3182.53 / 3204.90 ±26.97 / 3256.83 ms │ no change │
│ QQuery 24 │ 106.34 / 108.46 ±2.39 / 111.71 ms │ 99.35 / 105.81 ±3.88 / 110.90 ms │ no change │
│ QQuery 25 │ 140.54 / 143.07 ±1.70 / 145.40 ms │ 141.06 / 141.80 ±0.92 / 143.55 ms │ no change │
│ QQuery 26 │ 101.39 / 105.42 ±2.52 / 108.17 ms │ 103.78 / 105.54 ±1.04 / 106.73 ms │ no change │
│ QQuery 27 │ 846.07 / 851.55 ±4.38 / 858.76 ms │ 847.62 / 856.09 ±5.54 / 863.66 ms │ no change │
│ QQuery 28 │ 7714.08 / 7782.13 ±43.12 / 7822.02 ms │ 7753.77 / 7807.76 ±34.21 / 7852.60 ms │ no change │
│ QQuery 29 │ 331.01 / 336.45 ±8.81 / 353.88 ms │ 330.70 / 335.42 ±7.72 / 350.72 ms │ no change │
│ QQuery 30 │ 369.98 / 380.70 ±7.33 / 391.65 ms │ 370.09 / 380.61 ±10.03 / 398.44 ms │ no change │
│ QQuery 31 │ 371.87 / 379.57 ±8.05 / 394.44 ms │ 380.47 / 395.76 ±12.77 / 415.60 ms │ no change │
│ QQuery 32 │ 1080.62 / 1122.61 ±45.60 / 1204.17 ms │ 1332.48 / 1373.76 ±33.40 / 1432.73 ms │ 1.22x slower │
│ QQuery 33 │ 1509.72 / 1525.07 ±9.98 / 1540.23 ms │ 1511.16 / 1560.90 ±35.48 / 1620.50 ms │ no change │
│ QQuery 34 │ 1497.62 / 1520.64 ±18.17 / 1546.48 ms │ 1492.76 / 1515.97 ±18.32 / 1546.27 ms │ no change │
│ QQuery 35 │ 423.99 / 428.29 ±3.64 / 433.11 ms │ 425.97 / 435.67 ±12.44 / 459.61 ms │ no change │
│ QQuery 36 │ 125.68 / 128.33 ±2.23 / 131.82 ms │ 120.90 / 128.80 ±4.37 / 134.39 ms │ no change │
│ QQuery 37 │ 50.19 / 53.33 ±1.84 / 55.34 ms │ 51.53 / 53.38 ±1.89 / 56.93 ms │ no change │
│ QQuery 38 │ 75.21 / 77.63 ±1.73 / 79.86 ms │ 76.31 / 78.55 ±1.40 / 80.34 ms │ no change │
│ QQuery 39 │ 215.22 / 227.16 ±12.87 / 250.61 ms │ 217.49 / 231.54 ±8.29 / 241.80 ms │ no change │
│ QQuery 40 │ 23.48 / 25.88 ±1.71 / 28.52 ms │ 25.54 / 26.92 ±1.37 / 29.42 ms │ no change │
│ QQuery 41 │ 21.22 / 23.83 ±2.20 / 27.28 ms │ 20.66 / 21.63 ±0.96 / 22.95 ms │ +1.10x faster │
│ QQuery 42 │ 20.59 / 21.88 ±0.70 / 22.53 ms │ 21.03 / 21.30 ±0.27 / 21.75 ms │ no change │
└───────────┴───────────────────────────────────────┴───────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 28119.26ms │
│ Total Time (batched-accumulator-storage) │ 28386.65ms │
│ Average Time (HEAD) │ 653.94ms │
│ Average Time (batched-accumulator-storage) │ 660.15ms │
│ Queries Faster │ 1 │
│ Queries Slower │ 2 │
│ Queries with No Change │ 40 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴────────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**clickbench_partitioned — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 141.8s |
| Peak memory | 42.5 GiB |
| Avg memory | 31.1 GiB |
| CPU user | 1327.2s |
| CPU sys | 93.2s |
| Disk read | 0 B |
| Disk write | 4.9 GiB |
**clickbench_partitioned — branch**
| Metric | Value |
|--------|-------|
| Wall time | 143.1s |
| Peak memory | 42.2 GiB |
| Avg memory | 31.3 GiB |
| CPU user | 1331.2s |
| CPU sys | 103.7s |
| Disk read | 0 B |
| Disk write | 116.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4069009356
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068907576)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 48.65 / 49.28 ±0.77 / 50.77 ms │ 47.85 / 48.52 ±0.58 / 49.58 ms │ no change │
│ QQuery 2 │ 26.12 / 26.44 ±0.24 / 26.82 ms │ 24.94 / 25.20 ±0.26 / 25.61 ms │ no change │
│ QQuery 3 │ 35.64 / 36.01 ±0.26 / 36.36 ms │ 33.92 / 34.81 ±0.93 / 36.46 ms │ no change │
│ QQuery 4 │ 22.89 / 24.35 ±1.02 / 25.93 ms │ 21.65 / 22.35 ±0.90 / 24.13 ms │ +1.09x faster │
│ QQuery 5 │ 54.85 / 56.97 ±1.14 / 58.30 ms │ 50.07 / 51.78 ±0.95 / 52.89 ms │ +1.10x faster │
│ QQuery 6 │ 18.88 / 19.68 ±0.94 / 21.27 ms │ 17.75 / 18.12 ±0.25 / 18.46 ms │ +1.09x faster │
│ QQuery 7 │ 62.03 / 64.17 ±1.61 / 66.14 ms │ 57.03 / 58.55 ±1.38 / 60.72 ms │ +1.10x faster │
│ QQuery 8 │ 54.68 / 55.07 ±0.35 / 55.52 ms │ 51.47 / 52.23 ±0.69 / 53.18 ms │ +1.05x faster │
│ QQuery 9 │ 59.36 / 61.47 ±1.53 / 64.09 ms │ 56.96 / 58.09 ±1.64 / 61.36 ms │ +1.06x faster │
│ QQuery 10 │ 74.00 / 76.37 ±2.85 / 81.18 ms │ 74.22 / 74.98 ±0.53 / 75.66 ms │ no change │
│ QQuery 11 │ 16.85 / 17.28 ±0.43 / 18.11 ms │ 16.72 / 17.18 ±0.30 / 17.55 ms │ no change │
│ QQuery 12 │ 29.39 / 29.55 ±0.16 / 29.83 ms │ 29.05 / 29.34 ±0.21 / 29.59 ms │ no change │
│ QQuery 13 │ 40.96 / 41.70 ±0.83 / 43.27 ms │ 39.96 / 40.75 ±0.55 / 41.41 ms │ no change │
│ QQuery 14 │ 29.42 / 29.69 ±0.26 / 30.15 ms │ 29.49 / 30.07 ±0.49 / 30.81 ms │ no change │
│ QQuery 15 │ 36.34 / 37.45 ±0.97 / 38.86 ms │ 36.39 / 37.68 ±0.94 / 38.92 ms │ no change │
│ QQuery 16 │ 18.26 / 18.53 ±0.25 / 18.83 ms │ 18.16 / 18.45 ±0.21 / 18.74 ms │ no change │
│ QQuery 17 │ 75.70 / 77.27 ±1.50 / 79.68 ms │ 79.12 / 80.35 ±0.90 / 81.72 ms │ no change │
│ QQuery 18 │ 81.35 / 83.45 ±1.12 / 84.69 ms │ 82.32 / 83.63 ±1.06 / 84.83 ms │ no change │
│ QQuery 19 │ 39.57 / 39.98 ±0.37 / 40.63 ms │ 38.90 / 40.16 ±1.27 / 41.95 ms │ no change │
│ QQuery 20 │ 43.34 / 43.90 ±0.55 / 44.91 ms │ 44.16 / 44.97 ±0.68 / 45.97 ms │ no change │
│ QQuery 21 │ 68.85 / 71.64 ±1.59 / 73.07 ms │ 69.48 / 71.22 ±1.35 / 72.65 ms │ no change │
│ QQuery 22 │ 20.05 / 20.88 ±0.56 / 21.68 ms │ 19.93 / 20.17 ±0.26 / 20.65 ms │ no change │
└───────────┴────────────────────────────────┴────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩
│ Total Time (HEAD) │ 981.13ms │
│ Total Time (batched-accumulator-storage) │ 958.59ms │
│ Average Time (HEAD) │ 44.60ms │
│ Average Time (batched-accumulator-storage) │ 43.57ms │
│ Queries Faster │ 6 │
│ Queries Slower │ 0 │
│ Queries with No Change │ 16 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴──────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpch — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 5.2s |
| Peak memory | 3.9 GiB |
| Avg memory | 3.5 GiB |
| CPU user | 35.0s |
| CPU sys | 3.2s |
| Disk read | 0 B |
| Disk write | 140.0 KiB |
**tpch — branch**
| Metric | Value |
|--------|-------|
| Wall time | 5.0s |
| Peak memory | 4.0 GiB |
| Avg memory | 3.5 GiB |
| CPU user | 34.6s |
| CPU sys | 3.1s |
| Disk read | 0 B |
| Disk write | 68.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068525672
run benchmarks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068575835
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068451493)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1 │ 47.53 / 48.11 ±0.69 / 49.42 ms │ 49.95 / 50.84 ±1.14 / 53.10 ms │ 1.06x slower │
│ QQuery 2 │ 25.50 / 25.89 ±0.28 / 26.33 ms │ 25.58 / 25.73 ±0.08 / 25.82 ms │ no change │
│ QQuery 3 │ 34.94 / 35.59 ±0.99 / 37.56 ms │ 34.70 / 35.27 ±0.66 / 36.55 ms │ no change │
│ QQuery 4 │ 22.54 / 22.98 ±0.54 / 24.05 ms │ 22.28 / 22.85 ±0.50 / 23.71 ms │ no change │
│ QQuery 5 │ 52.43 / 55.17 ±3.09 / 60.61 ms │ 53.08 / 55.11 ±1.37 / 56.50 ms │ no change │
│ QQuery 6 │ 17.99 / 18.42 ±0.48 / 19.32 ms │ 18.02 / 18.18 ±0.16 / 18.47 ms │ no change │
│ QQuery 7 │ 59.12 / 61.06 ±1.02 / 61.99 ms │ 58.32 / 60.73 ±1.81 / 63.61 ms │ no change │
│ QQuery 8 │ 52.62 / 53.73 ±0.85 / 54.53 ms │ 52.79 / 53.51 ±0.61 / 54.65 ms │ no change │
│ QQuery 9 │ 59.07 / 59.80 ±0.76 / 61.05 ms │ 58.16 / 58.84 ±0.58 / 59.88 ms │ no change │
│ QQuery 10 │ 74.67 / 76.13 ±0.77 / 76.67 ms │ 74.97 / 76.80 ±1.07 / 78.15 ms │ no change │
│ QQuery 11 │ 17.55 / 17.73 ±0.15 / 17.89 ms │ 17.00 / 17.59 ±0.39 / 18.21 ms │ no change │
│ QQuery 12 │ 30.06 / 30.24 ±0.11 / 30.39 ms │ 29.43 / 30.12 ±0.39 / 30.59 ms │ no change │
│ QQuery 13 │ 41.29 / 41.69 ±0.44 / 42.44 ms │ 41.22 / 42.16 ±1.15 / 44.41 ms │ no change │
│ QQuery 14 │ 29.99 / 30.37 ±0.21 / 30.55 ms │ 30.24 / 30.49 ±0.20 / 30.82 ms │ no change │
│ QQuery 15 │ 37.08 / 37.28 ±0.24 / 37.74 ms │ 37.81 / 38.02 ±0.19 / 38.37 ms │ no change │
│ QQuery 16 │ 18.55 / 19.00 ±0.35 / 19.50 ms │ 18.76 / 19.09 ±0.35 / 19.69 ms │ no change │
│ QQuery 17 │ 78.95 / 80.87 ±2.41 / 85.50 ms │ 79.25 / 80.63 ±1.32 / 82.97 ms │ no change │
│ QQuery 18 │ 82.88 / 84.27 ±1.22 / 85.73 ms │ 86.00 / 87.72 ±1.24 / 89.88 ms │ no change │
│ QQuery 19 │ 39.74 / 40.07 ±0.38 / 40.78 ms │ 39.77 / 40.89 ±0.71 / 41.77 ms │ no change │
│ QQuery 20 │ 44.25 / 44.95 ±0.71 / 46.04 ms │ 45.04 / 46.25 ±1.63 / 49.42 ms │ no change │
│ QQuery 21 │ 73.18 / 74.72 ±1.72 / 78.03 ms │ 71.61 / 72.76 ±1.28 / 75.01 ms │ no change │
│ QQuery 22 │ 20.62 / 21.14 ±0.80 / 22.74 ms │ 20.96 / 21.44 ±0.30 / 21.90 ms │ no change │
└───────────┴────────────────────────────────┴────────────────────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩
│ Total Time (HEAD) │ 979.23ms │
│ Total Time (batched-accumulator-storage) │ 985.02ms │
│ Average Time (HEAD) │ 44.51ms │
│ Average Time (batched-accumulator-storage) │ 44.77ms │
│ Queries Faster │ 0 │
│ Queries Slower │ 1 │
│ Queries with No Change │ 21 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴──────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpch — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 5.2s |
| Peak memory | 3.9 GiB |
| Avg memory | 3.5 GiB |
| CPU user | 34.9s |
| CPU sys | 3.3s |
| Disk read | 0 B |
| Disk write | 148.0 KiB |
**tpch — branch**
| Metric | Value |
|--------|-------|
| Wall time | 5.2s |
| Peak memory | 3.9 GiB |
| Avg memory | 3.5 GiB |
| CPU user | 35.4s |
| CPU sys | 3.3s |
| Disk read | 0 B |
| Disk write | 56.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068877101
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068698039)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 1.61 / 4.92 ±6.43 / 17.78 ms │ 1.62 / 4.91 ±6.39 / 17.70 ms │ no change │
│ QQuery 1 │ 15.11 / 15.58 ±0.29 / 16.03 ms │ 15.28 / 15.76 ±0.52 / 16.77 ms │ no change │
│ QQuery 2 │ 57.11 / 58.02 ±0.68 / 59.22 ms │ 57.07 / 57.43 ±0.20 / 57.66 ms │ no change │
│ QQuery 3 │ 49.95 / 51.63 ±1.32 / 53.44 ms │ 48.24 / 51.32 ±1.82 / 53.19 ms │ no change │
│ QQuery 4 │ 310.25 / 318.97 ±7.44 / 330.87 ms │ 312.43 / 324.37 ±9.52 / 338.73 ms │ no change │
│ QQuery 5 │ 364.53 / 366.65 ±2.00 / 370.41 ms │ 359.23 / 364.74 ±5.01 / 373.76 ms │ no change │
│ QQuery 6 │ 5.66 / 6.13 ±0.31 / 6.54 ms │ 5.66 / 6.17 ±0.34 / 6.71 ms │ no change │
│ QQuery 7 │ 17.49 / 19.44 ±3.32 / 26.08 ms │ 17.37 / 20.49 ±6.01 / 32.51 ms │ 1.05x slower │
│ QQuery 8 │ 441.53 / 447.36 ±4.80 / 455.89 ms │ 456.46 / 471.06 ±12.57 / 494.08 ms │ 1.05x slower │
│ QQuery 9 │ 688.60 / 704.16 ±13.79 / 727.71 ms │ 716.17 / 742.93 ±22.96 / 778.98 ms │ 1.06x slower │
│ QQuery 10 │ 95.14 / 97.13 ±1.97 / 100.51 ms │ 93.20 / 96.83 ±4.67 / 105.87 ms │ no change │
│ QQuery 11 │ 107.99 / 110.12 ±1.29 / 111.50 ms │ 107.98 / 109.56 ±0.85 / 110.49 ms │ no change │
│ QQuery 12 │ 356.32 / 360.68 ±3.84 / 366.43 ms │ 365.61 / 384.78 ±13.64 / 403.95 ms │ 1.07x slower │
│ QQuery 13 │ 477.81 / 489.61 ±8.39 / 501.63 ms │ 472.32 / 489.50 ±13.21 / 509.45 ms │ no change │
│ QQuery 14 │ 363.17 / 367.88 ±4.24 / 374.15 ms │ 367.15 / 372.79 ±4.52 / 380.95 ms │ no change │
│ QQuery 15 │ 385.30 / 393.33 ±10.18 / 411.51 ms │ 387.70 / 427.00 ±29.17 / 467.16 ms │ 1.09x slower │
│ QQuery 16 │ 774.15 / 790.73 ±13.20 / 813.26 ms │ 770.88 / 800.52 ±21.27 / 832.12 ms │ no change │
│ QQuery 17 │ 765.55 / 769.58 ±3.56 / 774.97 ms │ 767.97 / 792.14 ±16.23 / 810.37 ms │ no change │
│ QQuery 18 │ 1479.68 / 1543.08 ±40.79 / 1595.77 ms │ 1467.46 / 1510.21 ±37.37 / 1579.36 ms │ no change │
│ QQuery 19 │ 36.63 / 50.83 ±16.50 / 78.19 ms │ 37.39 / 38.90 ±1.16 / 40.85 ms │ +1.31x faster │
│ QQuery 20 │ 719.13 / 739.55 ±24.83 / 774.25 ms │ 710.08 / 716.22 ±4.76 / 723.16 ms │ no change │
│ QQuery 21 │ 760.59 / 766.41 ±4.61 / 771.97 ms │ 761.16 / 763.70 ±3.03 / 768.51 ms │ no change │
│ QQuery 22 │ 1126.87 / 1134.16 ±6.51 / 1145.96 ms │ 1135.49 / 1140.07 ±3.33 / 1143.80 ms │ no change │
│ QQuery 23 │ 3173.23 / 3216.06 ±24.35 / 3239.96 ms │ 3159.54 / 3190.47 ±25.92 / 3226.06 ms │ no change │
│ QQuery 24 │ 103.28 / 108.51 ±4.65 / 116.97 ms │ 103.62 / 106.07 ±3.08 / 112.04 ms │ no change │
│ QQuery 25 │ 140.02 / 143.45 ±3.18 / 149.09 ms │ 141.08 / 143.04 ±1.33 / 144.57 ms │ no change │
│ QQuery 26 │ 105.44 / 106.82 ±0.83 / 108.04 ms │ 105.32 / 106.96 ±1.75 / 110.09 ms │ no change │
│ QQuery 27 │ 857.59 / 864.84 ±4.63 / 871.34 ms │ 851.22 / 856.56 ±5.79 / 867.18 ms │ no change │
│ QQuery 28 │ 7747.10 / 7791.37 ±23.71 / 7813.50 ms │ 7784.93 / 7812.66 ±18.51 / 7831.03 ms │ no change │
│ QQuery 29 │ 329.68 / 336.23 ±9.21 / 354.49 ms │ 331.86 / 339.20 ±13.08 / 365.32 ms │ no change │
│ QQuery 30 │ 364.02 / 375.30 ±7.55 / 385.52 ms │ 401.88 / 407.43 ±3.97 / 411.83 ms │ 1.09x slower │
│ QQuery 31 │ 369.92 / 382.75 ±8.74 / 397.43 ms │ 381.63 / 392.96 ±9.03 / 406.18 ms │ no change │
│ QQuery 32 │ 1321.12 / 1342.33 ±26.58 / 1387.67 ms │ 1180.94 / 1190.94 ±7.85 / 1200.54 ms │ +1.13x faster │
│ QQuery 33 │ 1622.51 / 1673.82 ±36.32 / 1713.14 ms │ 1571.96 / 1595.17 ±23.55 / 1637.80 ms │ no change │
│ QQuery 34 │ 1577.76 / 1618.51 ±28.18 / 1652.78 ms │ 1549.87 / 1581.74 ±31.99 / 1641.51 ms │ no change │
│ QQuery 35 │ 425.61 / 440.26 ±14.80 / 466.17 ms │ 447.51 / 453.14 ±7.24 / 466.77 ms │ no change │
│ QQuery 36 │ 124.79 / 127.92 ±2.29 / 130.98 ms │ 123.87 / 126.86 ±2.72 / 130.51 ms │ no change │
│ QQuery 37 │ 52.36 / 53.04 ±0.64 / 54.04 ms │ 53.49 / 54.73 ±1.20 / 56.69 ms │ no change │
│ QQuery 38 │ 76.67 / 78.26 ±1.60 / 80.67 ms │ 77.55 / 79.32 ±1.31 / 81.49 ms │ no change │
│ QQuery 39 │ 234.57 / 238.84 ±2.93 / 242.06 ms │ 229.60 / 242.82 ±8.72 / 252.67 ms │ no change │
│ QQuery 40 │ 27.57 / 28.48 ±0.64 / 29.35 ms │ 24.77 / 27.41 ±2.38 / 30.82 ms │ no change │
│ QQuery 41 │ 21.75 / 22.68 ±0.87 / 24.02 ms │ 21.89 / 23.48 ±1.47 / 26.20 ms │ no change │
│ QQuery 42 │ 21.45 / 22.17 ±0.51 / 22.87 ms │ 21.71 / 22.22 ±0.33 / 22.66 ms │ no change │
└───────────┴───────────────────────────────────────┴───────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 28577.58ms │
│ Total Time (batched-accumulator-storage) │ 28454.57ms │
│ Average Time (HEAD) │ 664.59ms │
│ Average Time (batched-accumulator-storage) │ 661.73ms │
│ Queries Faster │ 2 │
│ Queries Slower │ 6 │
│ Queries with No Change │ 35 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴────────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**clickbench_partitioned — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 143.8s |
| Peak memory | 38.5 GiB |
| Avg memory | 29.8 GiB |
| CPU user | 1330.2s |
| CPU sys | 111.5s |
| Disk read | 0 B |
| Disk write | 3.9 GiB |
**clickbench_partitioned — branch**
| Metric | Value |
|--------|-------|
| Wall time | 143.4s |
| Peak memory | 40.3 GiB |
| Avg memory | 33.0 GiB |
| CPU user | 1346.6s |
| CPU sys | 93.8s |
| Disk read | 0 B |
| Disk write | 760.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068907576
run benchmarks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4069051045
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068907576)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark tpcds_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 52.29 / 53.08 ±0.66 / 53.98 ms │ 52.06 / 53.03 ±0.64 / 53.99 ms │ no change │
│ QQuery 2 │ 159.62 / 160.65 ±1.09 / 162.71 ms │ 158.70 / 159.89 ±0.64 / 160.53 ms │ no change │
│ QQuery 3 │ 123.02 / 123.29 ±0.28 / 123.83 ms │ 122.91 / 123.91 ±0.93 / 125.53 ms │ no change │
│ QQuery 4 │ 1378.17 / 1498.09 ±67.62 / 1567.50 ms │ 1367.70 / 1427.65 ±62.70 / 1548.01 ms │ no change │
│ QQuery 5 │ 190.80 / 193.10 ±1.63 / 195.66 ms │ 184.77 / 187.58 ±2.88 / 192.50 ms │ no change │
│ QQuery 6 │ 982.81 / 1036.03 ±39.66 / 1095.74 ms │ 1069.58 / 1089.07 ±16.93 / 1117.66 ms │ 1.05x slower │
│ QQuery 7 │ 359.92 / 362.69 ±2.15 / 366.42 ms │ 368.65 / 372.88 ±3.64 / 379.51 ms │ no change │
│ QQuery 8 │ 122.10 / 124.67 ±1.33 / 125.98 ms │ 123.01 / 125.31 ±1.56 / 127.61 ms │ no change │
│ QQuery 9 │ 114.47 / 121.10 ±6.52 / 132.80 ms │ 118.24 / 119.36 ±0.73 / 120.18 ms │ no change │
│ QQuery 10 │ 115.02 / 117.06 ±1.59 / 119.51 ms │ 114.84 / 115.28 ±0.52 / 116.28 ms │ no change │
│ QQuery 11 │ 971.81 / 979.65 ±6.58 / 991.54 ms │ 953.48 / 976.16 ±17.58 / 992.50 ms │ no change │
│ QQuery 12 │ 47.07 / 48.64 ±1.47 / 51.13 ms │ 47.34 / 49.44 ±2.22 / 53.74 ms │ no change │
│ QQuery 13 │ 404.55 / 409.17 ±2.87 / 413.38 ms │ 407.38 / 409.17 ±1.30 / 410.81 ms │ no change │
│ QQuery 14 │ 1101.34 / 1130.39 ±15.93 / 1148.35 ms │ 1097.99 / 1106.75 ±7.67 / 1118.53 ms │ no change │
│ QQuery 15 │ 19.84 / 21.12 ±0.87 / 22.33 ms │ 19.51 / 21.07 ±1.15 / 23.07 ms │ no change │
│ QQuery 16 │ 47.57 / 48.62 ±0.57 / 49.18 ms │ 48.41 / 49.06 ±0.79 / 50.54 ms │ no change │
│ QQuery 17 │ 263.74 / 265.75 ±1.05 / 266.70 ms │ 264.10 / 264.99 ±0.77 / 266.38 ms │ no change │
│ QQuery 18 │ 138.72 / 140.93 ±1.49 / 142.87 ms │ 140.18 / 141.35 ±0.95 / 142.62 ms │ no change │
│ QQuery 19 │ 170.41 / 172.14 ±1.44 / 174.39 ms │ 174.64 / 175.76 ±0.89 / 176.99 ms │ no change │
│ QQuery 20 │ 17.53 / 18.02 ±0.56 / 19.11 ms │ 16.65 / 17.56 ±0.50 / 18.13 ms │ no change │
│ QQuery 21 │ 25.23 / 26.00 ±0.60 / 26.99 ms │ 26.13 / 26.74 ±0.40 / 27.18 ms │ no change │
│ QQuery 22 │ 520.86 / 524.42 ±2.88 / 528.21 ms │ 569.47 / 578.67 ±5.50 / 583.88 ms │ 1.10x slower │
│ QQuery 23 │ 1020.06 / 1059.88 ±20.45 / 1078.43 ms │ 962.56 / 994.72 ±32.53 / 1050.06 ms │ +1.07x faster │
│ QQuery 24 │ 462.33 / 463.31 ±0.70 / 464.17 ms │ 447.44 / 461.17 ±7.61 / 469.19 ms │ no change │
│ QQuery 25 │ 376.67 / 382.30 ±4.19 / 387.80 ms │ 382.93 / 385.92 ±1.56 / 387.21 ms │ no change │
│ QQuery 26 │ 89.34 / 90.70 ±0.97 / 92.20 ms │ 88.60 / 91.09 ±2.01 / 94.34 ms │ no change │
│ QQuery 27 │ 351.10 / 357.36 ±6.97 / 369.88 ms │ 356.26 / 365.80 ±5.26 / 371.49 ms │ no change │
│ QQuery 28 │ 154.88 / 156.97 ±1.83 / 159.43 ms │ 158.85 / 160.45 ±1.45 / 163.09 ms │ no change │
│ QQuery 29 │ 309.15 / 310.87 ±1.04 / 312.13 ms │ 308.80 / 318.66 ±6.51 / 327.71 ms │ no change │
│ QQuery 30 │ 48.80 / 52.02 ±1.81 / 53.92 ms │ 48.45 / 50.34 ±1.37 / 52.30 ms │ no change │
│ QQuery 31 │ 184.09 / 187.07 ±1.84 / 188.90 ms │ 185.77 / 187.20 ±1.07 / 189.05 ms │ no change │
│ QQuery 32 │ 62.38 / 63.41 ±0.68 / 64.16 ms │ 62.77 / 63.64 ±0.86 / 65.22 ms │ no change │
│ QQuery 33 │ 154.89 / 157.45 ±2.31 / 160.79 ms │ 153.26 / 154.08 ±0.62 / 154.92 ms │ no change │
│ QQuery 34 │ 117.50 / 118.70 ±0.73 / 119.44 ms │ 109.86 / 112.08 ±1.35 / 114.00 ms │ +1.06x faster │
│ QQuery 35 │ 124.62 / 125.44 ±0.55 / 126.28 ms │ 117.65 / 118.63 ±0.77 / 119.92 ms │ +1.06x faster │
│ QQuery 36 │ 235.57 / 239.82 ±4.00 / 247.22 ms │ 225.23 / 228.48 ±2.77 / 232.79 ms │ no change │
│ QQuery 37 │ 191.99 / 194.62 ±2.01 / 197.52 ms │ 184.95 / 185.69 ±0.76 / 186.98 ms │ no change │
│ QQuery 38 │ 101.18 / 105.05 ±3.45 / 109.93 ms │ 95.71 / 97.12 ±1.07 / 98.42 ms │ +1.08x faster │
│ QQuery 39 │ 161.09 / 163.19 ±1.92 / 166.66 ms │ 159.17 / 162.57 ±1.85 / 164.00 ms │ no change │
│ QQuery 40 │ 117.74 / 127.46 ±7.33 / 140.10 ms │ 126.07 / 129.88 ±4.33 / 138.21 ms │ no change │
│ QQuery 41 │ 17.47 / 19.35 ±1.18 / 20.81 ms │ 20.08 / 20.87 ±1.02 / 22.80 ms │ 1.08x slower │
│ QQuery 42 │ 111.71 / 114.27 ±1.65 / 116.71 ms │ 114.78 / 115.78 ±0.77 / 117.00 ms │ no change │
│ QQuery 43 │ 88.20 / 89.11 ±0.75 / 89.95 ms │ 91.23 / 91.84 ±0.51 / 92.67 ms │ no change │
│ QQuery 44 │ 17.67 / 18.11 ±0.31 / 18.40 ms │ 18.62 / 19.46 ±0.76 / 20.49 ms │ 1.07x slower │
│ QQuery 45 │ 54.47 / 56.63 ±1.11 / 57.67 ms │ 57.96 / 60.30 ±1.73 / 63.30 ms │ 1.06x slower │
│ QQuery 46 │ 235.95 / 238.63 ±1.43 / 240.18 ms │ 265.72 / 268.32 ±2.66 / 273.20 ms │ 1.12x slower │
│ QQuery 47 │ 725.90 / 756.25 ±44.24 / 844.24 ms │ 752.52 / 792.19 ±60.54 / 909.25 ms │ no change │
│ QQuery 48 │ 296.41 / 306.62 ±7.78 / 316.44 ms │ 288.91 / 297.23 ±4.47 / 301.49 ms │ no change │
│ QQuery 49 │ 272.34 / 273.71 ±1.58 / 276.77 ms │ 265.92 / 267.03 ±1.63 / 270.25 ms │ no change │
│ QQuery 50 │ 263.06 / 265.69 ±2.15 / 268.69 ms │ 239.76 / 243.57 ±2.94 / 248.54 ms │ +1.09x faster │
│ QQuery 51 │ 201.02 / 204.18 ±2.70 / 208.48 ms │ 192.81 / 195.74 ±2.24 / 198.81 ms │ no change │
│ QQuery 52 │ 117.10 / 118.81 ±1.39 / 121.27 ms │ 114.00 / 115.29 ±1.19 / 116.87 ms │ no change │
│ QQuery 53 │ 110.39 / 112.85 ±1.94 / 116.05 ms │ 109.12 / 109.79 ±0.48 / 110.62 ms │ no change │
│ QQuery 54 │ 155.42 / 157.38 ±1.52 / 159.91 ms │ 154.11 / 156.80 ±1.50 / 158.58 ms │ no change │
│ QQuery 55 │ 110.54 / 111.62 ±1.14 / 113.70 ms │ 111.02 / 113.14 ±1.43 / 115.30 ms │ no change │
│ QQuery 56 │ 151.84 / 153.65 ±1.49 / 156.09 ms │ 158.26 / 161.19 ±1.80 / 163.13 ms │ no change │
│ QQuery 57 │ 190.21 / 192.04 ±1.91 / 195.27 ms │ 199.35 / 203.53 ±2.37 / 205.88 ms │ 1.06x slower │
│ QQuery 58 │ 316.30 / 320.34 ±4.29 / 327.43 ms │ 317.96 / 333.37 ±9.02 / 343.97 ms │ no change │
│ QQuery 59 │ 208.98 / 211.71 ±2.17 / 214.21 ms │ 223.04 / 225.43 ±1.42 / 226.71 ms │ 1.06x slower │
│ QQuery 60 │ 152.79 / 155.13 ±1.68 / 158.00 ms │ 161.03 / 163.43 ±1.49 / 165.22 ms │ 1.05x slower │
│ QQuery 61 │ 179.09 / 181.08 ±1.72 / 184.28 ms │ 189.59 / 192.80 ±1.80 / 194.61 ms │ 1.06x slower │
│ QQuery 62 │ 898.77 / 951.04 ±69.69 / 1088.94 ms │ 905.90 / 936.62 ±37.32 / 1010.17 ms │ no change │
│ QQuery 63 │ 111.58 / 115.50 ±3.72 / 122.59 ms │ 110.54 / 113.16 ±2.32 / 116.10 ms │ no change │
│ QQuery 64 │ 721.28 / 724.67 ±3.49 / 729.23 ms │ 722.08 / 726.07 ±2.84 / 728.51 ms │ no change │
│ QQuery 65 │ 262.75 / 274.89 ±11.74 / 293.66 ms │ 268.76 / 293.13 ±12.20 / 299.51 ms │ 1.07x slower │
│ QQuery 66 │ 274.79 / 282.66 ±6.98 / 292.68 ms │ 280.53 / 285.12 ±5.07 / 292.15 ms │ no change │
│ QQuery 67 │ 348.89 / 368.50 ±11.17 / 383.56 ms │ 347.88 / 366.86 ±16.40 / 394.64 ms │ no change │
│ QQuery 68 │ 313.74 / 316.11 ±1.46 / 317.96 ms │ 318.97 / 323.28 ±2.47 / 326.49 ms │ no change │
│ QQuery 69 │ 117.78 / 120.31 ±1.39 / 121.81 ms │ 119.52 / 120.65 ±0.97 / 122.06 ms │ no change │
│ QQuery 70 │ 354.19 / 370.30 ±15.61 / 397.93 ms │ 360.55 / 376.50 ±12.04 / 395.89 ms │ no change │
│ QQuery 71 │ 141.94 / 143.13 ±1.03 / 144.57 ms │ 142.49 / 145.32 ±2.69 / 149.33 ms │ no change │
│ QQuery 72 │ 721.60 / 746.05 ±14.15 / 763.22 ms │ 756.97 / 784.38 ±16.91 / 799.18 ms │ 1.05x slower │
│ QQuery 73 │ 107.73 / 111.81 ±2.33 / 114.78 ms │ 114.23 / 115.89 ±1.62 / 117.87 ms │ no change │
│ QQuery 74 │ 714.99 / 717.49 ±2.40 / 720.60 ms │ 691.37 / 717.49 ±14.42 / 734.04 ms │ no change │
│ QQuery 75 │ 301.58 / 306.47 ±2.88 / 309.97 ms │ 293.37 / 301.74 ±6.63 / 311.13 ms │ no change │
│ QQuery 76 │ 145.08 / 146.38 ±1.20 / 148.44 ms │ 139.10 / 140.21 ±1.12 / 141.83 ms │ no change │
│ QQuery 77 │ 213.04 / 213.88 ±0.76 / 214.82 ms │ 205.73 / 207.29 ±1.62 / 210.06 ms │ no change │
│ QQuery 78 │ 369.62 / 373.28 ±3.38 / 378.06 ms │ 362.95 / 369.26 ±3.68 / 374.31 ms │ no change │
│ QQuery 79 │ 263.06 / 266.24 ±2.12 / 269.61 ms │ 263.45 / 269.14 ±3.72 / 274.44 ms │ no change │
│ QQuery 80 │ 344.12 / 346.31 ±3.06 / 352.24 ms │ 342.39 / 347.23 ±4.67 / 354.93 ms │ no change │
│ QQuery 81 │ 31.19 / 32.41 ±1.10 / 34.29 ms │ 31.85 / 33.26 ±1.01 / 34.80 ms │ no change │
│ QQuery 82 │ 206.49 / 210.92 ±2.33 / 213.07 ms │ 208.41 / 210.69 ±2.08 / 214.52 ms │ no change │
│ QQuery 83 │ 47.32 / 48.43 ±0.96 / 50.14 ms │ 48.09 / 49.24 ±0.92 / 50.60 ms │ no change │
│ QQuery 84 │ 52.01 / 53.46 ±0.94 / 54.37 ms │ 52.48 / 53.50 ±0.64 / 54.36 ms │ no change │
│ QQuery 85 │ 155.16 / 157.49 ±1.35 / 159.22 ms │ 153.49 / 156.10 ±1.75 / 158.58 ms │ no change │
│ QQuery 86 │ 42.28 / 43.44 ±1.84 / 47.09 ms │ 42.52 / 42.84 ±0.34 / 43.44 ms │ no change │
│ QQuery 87 │ 92.62 / 96.16 ±2.52 / 100.49 ms │ 96.37 / 97.73 ±1.30 / 99.86 ms │ no change │
│ QQuery 88 │ 116.45 / 117.00 ±0.37 / 117.58 ms │ 115.48 / 116.73 ±1.22 / 118.89 ms │ no change │
│ QQuery 89 │ 128.72 / 130.90 ±1.09 / 131.57 ms │ 125.44 / 126.93 ±0.96 / 128.25 ms │ no change │
│ QQuery 90 │ 30.95 / 31.77 ±0.67 / 32.87 ms │ 28.90 / 29.51 ±0.44 / 30.28 ms │ +1.08x faster │
│ QQuery 91 │ 69.66 / 71.63 ±1.37 / 73.04 ms │ 66.45 / 67.78 ±1.13 / 69.19 ms │ +1.06x faster │
│ QQuery 92 │ 64.98 / 66.06 ±0.66 / 67.01 ms │ 63.15 / 64.67 ±0.97 / 66.05 ms │ no change │
│ QQuery 93 │ 209.63 / 212.22 ±2.77 / 217.45 ms │ 209.72 / 211.77 ±1.06 / 212.74 ms │ no change │
│ QQuery 94 │ 70.36 / 71.03 ±0.47 / 71.79 ms │ 70.17 / 70.94 ±0.55 / 71.57 ms │ no change │
│ QQuery 95 │ 148.95 / 151.45 ±1.80 / 153.80 ms │ 147.69 / 149.50 ±2.89 / 155.24 ms │ no change │
│ QQuery 96 │ 83.25 / 84.31 ±0.91 / 85.49 ms │ 83.93 / 84.59 ±0.51 / 85.35 ms │ no change │
│ QQuery 97 │ 146.97 / 148.79 ±1.72 / 151.71 ms │ 134.70 / 140.44 ±3.94 / 145.73 ms │ +1.06x faster │
│ QQuery 98 │ 155.52 / 160.73 ±3.92 / 165.94 ms │ 164.65 / 168.18 ±1.97 / 170.09 ms │ no change │
│ QQuery 99 │ 10877.73 / 10973.24 ±75.59 / 11052.16 ms │ 10920.94 / 11002.46 ±93.05 / 11178.79 ms │ no change │
└───────────┴──────────────────────────────────────────┴──────────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 35743.87ms │
│ Total Time (batched-accumulator-storage) │ 35821.50ms │
│ Average Time (HEAD) │ 361.05ms │
│ Average Time (batched-accumulator-storage) │ 361.83ms │
│ Queries Faster │ 8 │
│ Queries Slower │ 12 │
│ Queries with No Change │ 79 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴────────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpcds — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 179.1s |
| Peak memory | 5.1 GiB |
| Avg memory | 4.4 GiB |
| CPU user | 284.3s |
| CPU sys | 22.3s |
| Disk read | 0 B |
| Disk write | 636.1 MiB |
**tpcds — branch**
| Metric | Value |
|--------|-------|
| Wall time | 179.4s |
| Peak memory | 5.5 GiB |
| Avg memory | 4.4 GiB |
| CPU user | 285.3s |
| CPU sys | 21.8s |
| Disk read | 0 B |
| Disk write | 148.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4069051432
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068907576)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 1.71 / 4.99 ±6.46 / 17.91 ms │ 1.69 / 5.07 ±6.54 / 18.16 ms │ no change │
│ QQuery 1 │ 15.57 / 15.91 ±0.45 / 16.77 ms │ 15.59 / 16.11 ±0.31 / 16.54 ms │ no change │
│ QQuery 2 │ 56.52 / 56.91 ±0.26 / 57.25 ms │ 59.24 / 60.00 ±0.65 / 61.09 ms │ 1.05x slower │
│ QQuery 3 │ 48.24 / 50.54 ±1.47 / 52.64 ms │ 50.95 / 52.50 ±1.27 / 54.07 ms │ no change │
│ QQuery 4 │ 304.60 / 308.86 ±4.47 / 317.43 ms │ 331.17 / 338.19 ±4.91 / 346.43 ms │ 1.09x slower │
│ QQuery 5 │ 349.71 / 358.78 ±8.19 / 368.80 ms │ 350.88 / 364.79 ±10.17 / 382.33 ms │ no change │
│ QQuery 6 │ 5.75 / 6.05 ±0.39 / 6.77 ms │ 5.13 / 6.13 ±0.64 / 7.07 ms │ no change │
│ QQuery 7 │ 18.71 / 22.41 ±6.04 / 34.41 ms │ 17.73 / 19.68 ±3.51 / 26.71 ms │ +1.14x faster │
│ QQuery 8 │ 436.70 / 452.62 ±12.75 / 475.76 ms │ 448.53 / 455.90 ±6.73 / 468.14 ms │ no change │
│ QQuery 9 │ 681.78 / 689.28 ±6.40 / 699.47 ms │ 697.13 / 702.17 ±5.79 / 712.30 ms │ no change │
│ QQuery 10 │ 94.04 / 96.90 ±3.98 / 104.80 ms │ 93.44 / 96.04 ±2.22 / 99.78 ms │ no change │
│ QQuery 11 │ 109.79 / 111.99 ±1.14 / 112.88 ms │ 107.28 / 109.56 ±1.88 / 111.94 ms │ no change │
│ QQuery 12 │ 369.80 / 377.24 ±5.09 / 383.07 ms │ 359.38 / 371.78 ±10.29 / 388.47 ms │ no change │
│ QQuery 13 │ 461.05 / 496.73 ±19.06 / 516.63 ms │ 461.87 / 474.86 ±13.21 / 499.13 ms │ no change │
│ QQuery 14 │ 358.79 / 364.19 ±4.20 / 369.67 ms │ 363.36 / 369.27 ±6.27 / 379.94 ms │ no change │
│ QQuery 15 │ 371.60 / 387.11 ±18.29 / 421.57 ms │ 425.19 / 438.69 ±12.36 / 460.66 ms │ 1.13x slower │
│ QQuery 16 │ 757.60 / 785.74 ±31.76 / 833.20 ms │ 773.31 / 798.50 ±18.44 / 827.69 ms │ no change │
│ QQuery 17 │ 790.16 / 807.04 ±16.08 / 831.98 ms │ 764.25 / 771.11 ±8.05 / 786.65 ms │ no change │
│ QQuery 18 │ 1475.32 / 1512.83 ±26.93 / 1558.69 ms │ 1512.83 / 1566.69 ±41.35 / 1639.85 ms │ no change │
│ QQuery 19 │ 35.88 / 67.49 ±60.61 / 188.69 ms │ 37.97 / 39.29 ±1.20 / 41.29 ms │ +1.72x faster │
│ QQuery 20 │ 709.56 / 733.91 ±27.66 / 779.37 ms │ 703.02 / 714.33 ±8.36 / 728.71 ms │ no change │
│ QQuery 21 │ 756.81 / 765.27 ±6.61 / 771.77 ms │ 755.24 / 757.75 ±2.40 / 761.65 ms │ no change │
│ QQuery 22 │ 1119.24 / 1136.31 ±16.55 / 1162.62 ms │ 1126.96 / 1139.75 ±15.79 / 1170.28 ms │ no change │
│ QQuery 23 │ 3175.09 / 3226.41 ±55.18 / 3332.20 ms │ 3166.61 / 3233.29 ±52.18 / 3296.02 ms │ no change │
│ QQuery 24 │ 104.26 / 106.95 ±1.74 / 109.73 ms │ 103.43 / 105.63 ±1.86 / 109.02 ms │ no change │
│ QQuery 25 │ 141.76 / 143.15 ±0.88 / 144.25 ms │ 139.39 / 141.41 ±1.22 / 143.23 ms │ no change │
│ QQuery 26 │ 103.54 / 104.46 ±0.69 / 105.45 ms │ 96.77 / 101.02 ±2.88 / 104.04 ms │ no change │
│ QQuery 27 │ 846.60 / 850.65 ±4.01 / 857.76 ms │ 849.43 / 854.47 ±5.97 / 864.54 ms │ no change │
│ QQuery 28 │ 7730.17 / 7781.93 ±26.23 / 7801.76 ms │ 7769.96 / 7835.26 ±55.50 / 7901.44 ms │ no change │
│ QQuery 29 │ 331.04 / 336.30 ±5.72 / 345.83 ms │ 334.28 / 339.57 ±9.33 / 358.17 ms │ no change │
│ QQuery 30 │ 382.09 / 386.04 ±4.21 / 393.06 ms │ 384.54 / 396.94 ±10.48 / 413.39 ms │ no change │
│ QQuery 31 │ 392.74 / 404.86 ±9.04 / 419.64 ms │ 367.45 / 382.18 ±10.67 / 400.77 ms │ +1.06x faster │
│ QQuery 32 │ 1224.85 / 1277.88 ±49.06 / 1362.49 ms │ 1181.87 / 1221.04 ±40.01 / 1271.40 ms │ no change │
│ QQuery 33 │ 1607.70 / 1639.01 ±25.51 / 1681.35 ms │ 1549.21 / 1594.41 ±49.02 / 1686.52 ms │ no change │
│ QQuery 34 │ 1613.98 / 1659.48 ±34.21 / 1703.87 ms │ 1554.15 / 1595.55 ±33.95 / 1649.20 ms │ no change │
│ QQuery 35 │ 405.96 / 420.35 ±13.59 / 446.03 ms │ 477.31 / 490.93 ±6.94 / 496.32 ms │ 1.17x slower │
│ QQuery 36 │ 123.98 / 126.91 ±2.34 / 129.92 ms │ 124.19 / 130.17 ±4.33 / 136.76 ms │ no change │
│ QQuery 37 │ 50.33 / 52.72 ±1.52 / 54.37 ms │ 50.66 / 51.29 ±0.58 / 52.15 ms │ no change │
│ QQuery 38 │ 75.98 / 78.25 ±1.53 / 80.76 ms │ 76.96 / 78.08 ±1.06 / 79.76 ms │ no change │
│ QQuery 39 │ 226.98 / 230.58 ±3.15 / 235.09 ms │ 227.43 / 236.58 ±5.98 / 246.31 ms │ no change │
│ QQuery 40 │ 27.43 / 29.78 ±1.63 / 32.01 ms │ 26.88 / 28.15 ±1.87 / 31.88 ms │ +1.06x faster │
│ QQuery 41 │ 22.29 / 23.54 ±1.08 / 25.13 ms │ 21.36 / 22.05 ±0.65 / 23.27 ms │ +1.07x faster │
│ QQuery 42 │ 22.92 / 23.20 ±0.20 / 23.40 ms │ 20.90 / 21.80 ±0.60 / 22.69 ms │ +1.06x faster │
└───────────┴───────────────────────────────────────┴───────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 28511.53ms │
│ Total Time (batched-accumulator-storage) │ 28528.01ms │
│ Average Time (HEAD) │ 663.06ms │
│ Average Time (batched-accumulator-storage) │ 663.44ms │
│ Queries Faster │ 6 │
│ Queries Slower │ 4 │
│ Queries with No Change │ 33 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴────────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**clickbench_partitioned — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 143.7s |
| Peak memory | 39.1 GiB |
| Avg memory | 30.8 GiB |
| CPU user | 1332.1s |
| CPU sys | 107.4s |
| Disk read | 0 B |
| Disk write | 4.4 GiB |
**clickbench_partitioned — branch**
| Metric | Value |
|--------|-------|
| Wall time | 143.8s |
| Peak memory | 41.6 GiB |
| Avg memory | 32.9 GiB |
| CPU user | 1354.6s |
| CPU sys | 93.1s |
| Disk read | 0 B |
| Disk write | 116.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068546124
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068525672)
`Linux bench-c4068525672-323-cmwnm 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (495b6f20d5f5fd5b6851877f1c43f290f142d95e) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..495b6f20d5f5fd5b6851877f1c43f290f142d95e) using: tpch
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068659008
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068525672)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 1.66 / 4.98 ±6.49 / 17.96 ms │ 1.66 / 4.96 ±6.40 / 17.77 ms │ no change │
│ QQuery 1 │ 14.89 / 15.20 ±0.27 / 15.62 ms │ 14.93 / 15.22 ±0.17 / 15.45 ms │ no change │
│ QQuery 2 │ 56.39 / 56.73 ±0.24 / 57.04 ms │ 57.10 / 57.40 ±0.22 / 57.68 ms │ no change │
│ QQuery 3 │ 48.22 / 50.50 ±1.58 / 52.35 ms │ 49.01 / 50.62 ±0.94 / 51.43 ms │ no change │
│ QQuery 4 │ 313.98 / 318.57 ±3.56 / 323.95 ms │ 306.95 / 316.82 ±6.28 / 323.29 ms │ no change │
│ QQuery 5 │ 361.61 / 363.84 ±1.62 / 365.64 ms │ 355.81 / 361.80 ±5.53 / 371.47 ms │ no change │
│ QQuery 6 │ 5.44 / 5.76 ±0.21 / 6.00 ms │ 5.90 / 10.28 ±4.88 / 18.70 ms │ 1.78x slower │
│ QQuery 7 │ 17.34 / 18.08 ±0.65 / 19.17 ms │ 17.60 / 18.04 ±0.58 / 19.17 ms │ no change │
│ QQuery 8 │ 448.96 / 454.70 ±4.06 / 461.09 ms │ 449.71 / 461.16 ±6.89 / 467.84 ms │ no change │
│ QQuery 9 │ 715.54 / 729.85 ±16.02 / 758.66 ms │ 722.86 / 738.37 ±16.66 / 770.18 ms │ no change │
│ QQuery 10 │ 95.45 / 99.52 ±5.17 / 109.20 ms │ 94.36 / 97.45 ±4.02 / 105.36 ms │ no change │
│ QQuery 11 │ 108.57 / 111.43 ±2.26 / 114.24 ms │ 108.11 / 110.41 ±1.85 / 113.12 ms │ no change │
│ QQuery 12 │ 364.62 / 365.98 ±1.27 / 367.69 ms │ 360.61 / 381.81 ±29.99 / 441.20 ms │ no change │
│ QQuery 13 │ 484.27 / 500.88 ±8.83 / 507.72 ms │ 482.43 / 500.20 ±20.00 / 531.33 ms │ no change │
│ QQuery 14 │ 373.55 / 378.24 ±3.47 / 382.10 ms │ 365.05 / 373.25 ±4.76 / 379.97 ms │ no change │
│ QQuery 15 │ 391.99 / 410.80 ±18.31 / 436.21 ms │ 391.62 / 421.78 ±23.48 / 452.44 ms │ no change │
│ QQuery 16 │ 769.86 / 803.17 ±18.35 / 821.41 ms │ 767.67 / 776.83 ±6.50 / 787.37 ms │ no change │
│ QQuery 17 │ 773.28 / 782.03 ±6.09 / 791.38 ms │ 754.06 / 779.16 ±26.32 / 828.14 ms │ no change │
│ QQuery 18 │ 1513.30 / 1540.40 ±17.24 / 1559.33 ms │ 1524.35 / 1559.77 ±34.35 / 1608.12 ms │ no change │
│ QQuery 19 │ 35.26 / 38.41 ±4.65 / 47.65 ms │ 35.29 / 38.33 ±3.16 / 44.04 ms │ no change │
│ QQuery 20 │ 718.19 / 730.18 ±13.04 / 749.85 ms │ 712.73 / 726.85 ±14.99 / 753.94 ms │ no change │
│ QQuery 21 │ 765.67 / 768.87 ±2.27 / 772.63 ms │ 757.94 / 765.15 ±6.00 / 774.68 ms │ no change │
│ QQuery 22 │ 1129.33 / 1135.08 ±5.26 / 1144.15 ms │ 1130.39 / 1135.03 ±3.78 / 1139.66 ms │ no change │
│ QQuery 23 │ 3203.39 / 3238.47 ±27.09 / 3278.29 ms │ 3199.47 / 3217.23 ±20.00 / 3253.21 ms │ no change │
│ QQuery 24 │ 96.44 / 103.60 ±5.91 / 112.54 ms │ 98.30 / 106.48 ±5.26 / 113.69 ms │ no change │
│ QQuery 25 │ 141.66 / 142.62 ±0.94 / 144.09 ms │ 142.03 / 143.54 ±1.82 / 146.80 ms │ no change │
│ QQuery 26 │ 103.62 / 106.08 ±1.53 / 107.83 ms │ 100.28 / 105.38 ±2.69 / 107.87 ms │ no change │
│ QQuery 27 │ 848.19 / 854.24 ±4.65 / 859.97 ms │ 853.09 / 857.26 ±5.51 / 868.13 ms │ no change │
│ QQuery 28 │ 7715.81 / 7789.46 ±37.79 / 7821.16 ms │ 7761.15 / 7834.66 ±37.60 / 7862.89 ms │ no change │
│ QQuery 29 │ 330.64 / 335.33 ±6.71 / 348.56 ms │ 330.44 / 352.53 ±24.19 / 382.62 ms │ 1.05x slower │
│ QQuery 30 │ 370.78 / 378.33 ±4.79 / 385.38 ms │ 385.77 / 392.77 ±5.84 / 403.50 ms │ no change │
│ QQuery 31 │ 369.25 / 399.86 ±20.76 / 428.06 ms │ 388.82 / 398.78 ±8.66 / 414.69 ms │ no change │
│ QQuery 32 │ 1091.51 / 1242.01 ±138.89 / 1479.14 ms │ 1303.53 / 1371.88 ±67.42 / 1492.03 ms │ 1.10x slower │
│ QQuery 33 │ 1501.61 / 1524.21 ±14.20 / 1539.90 ms │ 1527.01 / 1565.32 ±51.65 / 1663.31 ms │ no change │
│ QQuery 34 │ 1511.54 / 1525.66 ±8.67 / 1535.27 ms │ 1519.02 / 1530.49 ±7.30 / 1540.23 ms │ no change │
│ QQuery 35 │ 418.90 / 420.86 ±2.44 / 425.29 ms │ 421.64 / 427.13 ±3.74 / 431.04 ms │ no change │
│ QQuery 36 │ 124.66 / 128.61 ±4.11 / 136.52 ms │ 117.73 / 126.79 ±5.07 / 131.79 ms │ no change │
│ QQuery 37 │ 50.14 / 52.58 ±1.84 / 55.43 ms │ 50.00 / 52.51 ±1.40 / 53.92 ms │ no change │
│ QQuery 38 │ 75.81 / 79.00 ±2.37 / 83.06 ms │ 76.49 / 78.69 ±1.37 / 80.55 ms │ no change │
│ QQuery 39 │ 218.51 / 231.79 ±9.38 / 241.10 ms │ 227.83 / 239.29 ±6.20 / 244.18 ms │ no change │
│ QQuery 40 │ 25.25 / 28.15 ±2.60 / 32.05 ms │ 23.65 / 25.74 ±1.19 / 26.78 ms │ +1.09x faster │
│ QQuery 41 │ 21.43 / 22.93 ±1.10 / 24.39 ms │ 21.50 / 23.86 ±1.67 / 26.50 ms │ no change │
│ QQuery 42 │ 20.55 / 21.33 ±0.51 / 22.11 ms │ 21.34 / 21.88 ±0.45 / 22.45 ms │ no change │
└───────────┴────────────────────────────────────────┴───────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 28308.31ms │
│ Total Time (batched-accumulator-storage) │ 28572.92ms │
│ Average Time (HEAD) │ 658.33ms │
│ Average Time (batched-accumulator-storage) │ 664.49ms │
│ Queries Faster │ 1 │
│ Queries Slower │ 3 │
│ Queries with No Change │ 39 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴────────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**clickbench_partitioned — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 142.8s |
| Peak memory | 40.4 GiB |
| Avg memory | 31.7 GiB |
| CPU user | 1333.9s |
| CPU sys | 96.6s |
| Disk read | 0 B |
| Disk write | 4.0 GiB |
**clickbench_partitioned — branch**
| Metric | Value |
|--------|-------|
| Wall time | 144.1s |
| Peak memory | 40.0 GiB |
| Avg memory | 29.5 GiB |
| CPU user | 1336.6s |
| CPU sys | 105.4s |
| Disk read | 0 B |
| Disk write | 116.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068747673
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068631415)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1 │ 48.11 / 49.05 ±0.85 / 50.42 ms │ 48.34 / 48.89 ±0.46 / 49.71 ms │ no change │
│ QQuery 2 │ 25.24 / 25.43 ±0.20 / 25.81 ms │ 25.51 / 25.70 ±0.13 / 25.83 ms │ no change │
│ QQuery 3 │ 33.54 / 34.28 ±0.73 / 35.48 ms │ 33.64 / 34.95 ±0.70 / 35.63 ms │ no change │
│ QQuery 4 │ 22.01 / 22.72 ±0.60 / 23.49 ms │ 21.75 / 22.78 ±0.70 / 23.73 ms │ no change │
│ QQuery 5 │ 51.27 / 52.53 ±1.12 / 54.28 ms │ 50.18 / 52.53 ±1.76 / 54.35 ms │ no change │
│ QQuery 6 │ 17.57 / 18.18 ±0.58 / 18.98 ms │ 17.50 / 17.94 ±0.54 / 18.97 ms │ no change │
│ QQuery 7 │ 62.22 / 63.67 ±1.26 / 65.63 ms │ 57.81 / 62.41 ±2.46 / 65.13 ms │ no change │
│ QQuery 8 │ 50.95 / 53.06 ±1.60 / 55.52 ms │ 52.33 / 54.02 ±0.94 / 55.20 ms │ no change │
│ QQuery 9 │ 56.01 / 57.07 ±0.77 / 57.97 ms │ 56.15 / 57.60 ±0.99 / 59.06 ms │ no change │
│ QQuery 10 │ 73.22 / 76.10 ±1.51 / 77.57 ms │ 73.53 / 76.67 ±2.29 / 79.31 ms │ no change │
│ QQuery 11 │ 17.59 / 17.77 ±0.16 / 17.99 ms │ 17.76 / 18.26 ±0.72 / 19.67 ms │ no change │
│ QQuery 12 │ 29.02 / 30.30 ±0.88 / 31.73 ms │ 29.71 / 30.37 ±0.59 / 31.46 ms │ no change │
│ QQuery 13 │ 39.41 / 41.90 ±3.66 / 49.13 ms │ 39.57 / 40.51 ±0.83 / 41.91 ms │ no change │
│ QQuery 14 │ 29.16 / 29.47 ±0.23 / 29.87 ms │ 29.12 / 29.33 ±0.15 / 29.58 ms │ no change │
│ QQuery 15 │ 35.81 / 37.15 ±1.47 / 39.96 ms │ 36.02 / 36.67 ±0.55 / 37.37 ms │ no change │
│ QQuery 16 │ 18.42 / 19.34 ±0.46 / 19.66 ms │ 18.57 / 18.75 ±0.17 / 19.04 ms │ no change │
│ QQuery 17 │ 75.99 / 83.39 ±3.79 / 86.43 ms │ 78.18 / 84.92 ±3.80 / 89.79 ms │ no change │
│ QQuery 18 │ 81.55 / 82.05 ±0.43 / 82.77 ms │ 86.66 / 87.85 ±0.91 / 88.75 ms │ 1.07x slower │
│ QQuery 19 │ 40.17 / 41.73 ±0.86 / 42.58 ms │ 39.21 / 40.06 ±0.71 / 41.23 ms │ no change │
│ QQuery 20 │ 45.65 / 46.37 ±0.49 / 47.20 ms │ 44.96 / 47.18 ±1.48 / 49.38 ms │ no change │
│ QQuery 21 │ 68.61 / 71.61 ±2.78 / 76.85 ms │ 75.94 / 77.57 ±1.61 / 80.11 ms │ 1.08x slower │
│ QQuery 22 │ 19.80 / 20.26 ±0.35 / 20.66 ms │ 20.75 / 21.43 ±0.53 / 22.22 ms │ 1.06x slower │
└───────────┴────────────────────────────────┴────────────────────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩
│ Total Time (HEAD) │ 973.43ms │
│ Total Time (batched-accumulator-storage) │ 986.40ms │
│ Average Time (HEAD) │ 44.25ms │
│ Average Time (batched-accumulator-storage) │ 44.84ms │
│ Queries Faster │ 0 │
│ Queries Slower │ 3 │
│ Queries with No Change │ 19 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴──────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpch — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 5.2s |
| Peak memory | 4.0 GiB |
| Avg memory | 3.5 GiB |
| CPU user | 34.8s |
| CPU sys | 3.3s |
| Disk read | 0 B |
| Disk write | 136.0 KiB |
**tpch — branch**
| Metric | Value |
|--------|-------|
| Wall time | 5.2s |
| Peak memory | 4.0 GiB |
| Avg memory | 3.5 GiB |
| CPU user | 35.5s |
| CPU sys | 3.3s |
| Disk read | 0 B |
| Disk write | 56.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068788427
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068631415)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 1.60 / 4.91 ±6.44 / 17.78 ms │ 1.95 / 5.34 ±6.62 / 18.59 ms │ 1.09x slower │
│ QQuery 1 │ 15.10 / 15.37 ±0.32 / 15.99 ms │ 16.33 / 16.56 ±0.21 / 16.87 ms │ 1.08x slower │
│ QQuery 2 │ 56.18 / 56.89 ±0.39 / 57.26 ms │ 58.78 / 59.02 ±0.27 / 59.53 ms │ no change │
│ QQuery 3 │ 50.03 / 51.40 ±1.02 / 52.51 ms │ 49.51 / 52.54 ±3.16 / 57.11 ms │ no change │
│ QQuery 4 │ 315.10 / 320.21 ±4.22 / 327.63 ms │ 340.55 / 357.55 ±15.20 / 379.63 ms │ 1.12x slower │
│ QQuery 5 │ 359.07 / 385.24 ±17.69 / 400.08 ms │ 368.57 / 374.31 ±3.24 / 378.64 ms │ no change │
│ QQuery 6 │ 5.57 / 8.42 ±2.33 / 12.63 ms │ 5.78 / 6.57 ±1.27 / 9.09 ms │ +1.28x faster │
│ QQuery 7 │ 17.96 / 18.51 ±0.54 / 19.54 ms │ 18.91 / 20.30 ±1.49 / 22.54 ms │ 1.10x slower │
│ QQuery 8 │ 498.87 / 507.47 ±6.59 / 515.52 ms │ 480.42 / 501.89 ±13.38 / 519.84 ms │ no change │
│ QQuery 9 │ 801.36 / 812.83 ±9.12 / 823.78 ms │ 790.49 / 813.81 ±17.21 / 841.56 ms │ no change │
│ QQuery 10 │ 95.68 / 99.79 ±4.66 / 108.58 ms │ 99.91 / 102.47 ±1.55 / 104.19 ms │ no change │
│ QQuery 11 │ 108.10 / 109.80 ±1.37 / 111.23 ms │ 113.41 / 115.57 ±1.72 / 118.49 ms │ 1.05x slower │
│ QQuery 12 │ 354.37 / 360.37 ±5.06 / 369.35 ms │ 383.06 / 394.97 ±6.47 / 401.95 ms │ 1.10x slower │
│ QQuery 13 │ 458.22 / 482.62 ±13.25 / 496.00 ms │ 511.94 / 521.15 ±9.20 / 538.22 ms │ 1.08x slower │
│ QQuery 14 │ 400.45 / 404.42 ±2.92 / 409.07 ms │ 405.73 / 412.45 ±4.34 / 419.38 ms │ no change │
│ QQuery 15 │ 426.80 / 440.84 ±20.83 / 481.76 ms │ 398.18 / 426.28 ±27.13 / 459.31 ms │ no change │
│ QQuery 16 │ 784.23 / 826.05 ±24.64 / 860.60 ms │ 785.43 / 807.95 ±18.96 / 838.48 ms │ no change │
│ QQuery 17 │ 784.79 / 795.87 ±10.73 / 814.11 ms │ 833.25 / 866.56 ±37.37 / 932.61 ms │ 1.09x slower │
│ QQuery 18 │ 1428.92 / 1471.64 ±28.41 / 1511.11 ms │ 1547.13 / 1584.91 ±36.99 / 1638.57 ms │ 1.08x slower │
│ QQuery 19 │ 37.63 / 39.18 ±1.84 / 42.77 ms │ 39.03 / 44.90 ±10.59 / 66.04 ms │ 1.15x slower │
│ QQuery 20 │ 723.39 / 738.91 ±18.24 / 762.13 ms │ 732.70 / 747.21 ±12.32 / 768.79 ms │ no change │
│ QQuery 21 │ 776.24 / 781.72 ±3.19 / 785.74 ms │ 783.17 / 789.34 ±3.96 / 793.99 ms │ no change │
│ QQuery 22 │ 1144.76 / 1176.24 ±19.45 / 1198.94 ms │ 1141.67 / 1144.70 ±4.53 / 1153.71 ms │ no change │
│ QQuery 23 │ 3258.67 / 3335.03 ±69.43 / 3427.19 ms │ 3285.85 / 3340.60 ±47.50 / 3410.40 ms │ no change │
│ QQuery 24 │ 100.98 / 107.98 ±3.62 / 111.08 ms │ 101.71 / 107.72 ±4.97 / 116.51 ms │ no change │
│ QQuery 25 │ 147.23 / 150.90 ±3.11 / 155.95 ms │ 142.49 / 143.76 ±0.72 / 144.58 ms │ no change │
│ QQuery 26 │ 109.80 / 111.42 ±1.04 / 113.03 ms │ 106.93 / 108.56 ±1.24 / 110.37 ms │ no change │
│ QQuery 27 │ 875.51 / 884.94 ±8.81 / 901.56 ms │ 875.31 / 881.14 ±5.57 / 891.25 ms │ no change │
│ QQuery 28 │ 7758.35 / 7848.94 ±48.85 / 7896.03 ms │ 7854.12 / 7885.06 ±26.92 / 7933.24 ms │ no change │
│ QQuery 29 │ 332.11 / 337.91 ±10.16 / 358.21 ms │ 335.34 / 343.55 ±12.09 / 367.56 ms │ no change │
│ QQuery 30 │ 402.39 / 408.19 ±7.56 / 423.11 ms │ 407.07 / 420.15 ±8.12 / 430.96 ms │ no change │
│ QQuery 31 │ 400.82 / 419.84 ±10.09 / 429.95 ms │ 381.95 / 406.96 ±18.71 / 425.84 ms │ no change │
│ QQuery 32 │ 1086.84 / 1123.39 ±58.03 / 1238.67 ms │ 1321.30 / 1394.38 ±95.67 / 1576.83 ms │ 1.24x slower │
│ QQuery 33 │ 1524.61 / 1652.37 ±66.24 / 1706.49 ms │ 1703.07 / 1737.00 ±26.95 / 1774.64 ms │ 1.05x slower │
│ QQuery 34 │ 1527.47 / 1585.43 ±70.11 / 1721.17 ms │ 1625.43 / 1742.45 ±64.67 / 1814.89 ms │ 1.10x slower │
│ QQuery 35 │ 507.14 / 510.40 ±3.29 / 514.51 ms │ 437.48 / 441.89 ±4.34 / 449.21 ms │ +1.16x faster │
│ QQuery 36 │ 130.69 / 135.64 ±4.91 / 142.13 ms │ 122.39 / 129.66 ±3.72 / 132.78 ms │ no change │
│ QQuery 37 │ 54.93 / 57.37 ±1.55 / 59.39 ms │ 51.54 / 53.49 ±1.13 / 54.79 ms │ +1.07x faster │
│ QQuery 38 │ 80.94 / 82.61 ±1.73 / 85.67 ms │ 77.22 / 79.32 ±1.73 / 81.39 ms │ no change │
│ QQuery 39 │ 252.17 / 264.88 ±7.06 / 272.65 ms │ 248.71 / 254.69 ±5.76 / 263.65 ms │ no change │
│ QQuery 40 │ 26.73 / 29.65 ±1.87 / 31.79 ms │ 28.11 / 29.83 ±1.22 / 31.40 ms │ no change │
│ QQuery 41 │ 21.86 / 23.16 ±1.16 / 25.14 ms │ 22.86 / 25.53 ±2.33 / 29.62 ms │ 1.10x slower │
│ QQuery 42 │ 21.94 / 23.05 ±1.09 / 25.13 ms │ 22.78 / 23.37 ±0.48 / 23.93 ms │ no change │
└───────────┴───────────────────────────────────────┴───────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 29001.80ms │
│ Total Time (batched-accumulator-storage) │ 29715.44ms │
│ Average Time (HEAD) │ 674.46ms │
│ Average Time (batched-accumulator-storage) │ 691.06ms │
│ Queries Faster │ 3 │
│ Queries Slower │ 14 │
│ Queries with No Change │ 26 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴────────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**clickbench_partitioned — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 146.3s |
| Peak memory | 41.3 GiB |
| Avg memory | 33.8 GiB |
| CPU user | 1372.9s |
| CPU sys | 93.7s |
| Disk read | 0 B |
| Disk write | 4.6 GiB |
**clickbench_partitioned — branch**
| Metric | Value |
|--------|-------|
| Wall time | 149.7s |
| Peak memory | 35.5 GiB |
| Avg memory | 26.2 GiB |
| CPU user | 1383.6s |
| CPU sys | 114.9s |
| Disk read | 0 B |
| Disk write | 560.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan closed pull request #20964: bench: Batched accumulator storage for hash aggregation
URL: https://github.com/apache/datafusion/pull/20964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068649488
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068631415)
`Linux bench-c4068631415-326-8bgm7 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (f4aa988e207794538fb48342f5b9b0ed8e23ac9a) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..f4aa988e207794538fb48342f5b9b0ed8e23ac9a) using: tpch
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068625504
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068451493)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 1.83 / 5.20 ±6.56 / 18.32 ms │ 1.76 / 5.11 ±6.52 / 18.15 ms │ no change │
│ QQuery 1 │ 16.25 / 16.52 ±0.17 / 16.75 ms │ 15.06 / 15.69 ±0.45 / 16.44 ms │ no change │
│ QQuery 2 │ 57.70 / 58.14 ±0.25 / 58.45 ms │ 58.10 / 58.47 ±0.27 / 58.74 ms │ no change │
│ QQuery 3 │ 50.83 / 52.39 ±1.41 / 54.69 ms │ 52.86 / 53.85 ±0.94 / 55.53 ms │ no change │
│ QQuery 4 │ 321.69 / 332.33 ±7.47 / 341.61 ms │ 316.96 / 340.25 ±17.64 / 359.02 ms │ no change │
│ QQuery 5 │ 367.10 / 371.81 ±6.45 / 384.55 ms │ 360.38 / 363.47 ±3.20 / 368.84 ms │ no change │
│ QQuery 6 │ 6.00 / 8.64 ±3.15 / 14.58 ms │ 5.38 / 5.68 ±0.28 / 6.15 ms │ +1.52x faster │
│ QQuery 7 │ 19.38 / 19.76 ±0.43 / 20.54 ms │ 17.18 / 17.41 ±0.14 / 17.57 ms │ +1.13x faster │
│ QQuery 8 │ 490.39 / 499.63 ±7.49 / 512.48 ms │ 451.24 / 459.92 ±7.10 / 468.09 ms │ +1.09x faster │
│ QQuery 9 │ 792.57 / 805.90 ±12.66 / 828.24 ms │ 791.24 / 823.03 ±17.29 / 838.54 ms │ no change │
│ QQuery 10 │ 99.27 / 101.94 ±2.64 / 106.46 ms │ 100.99 / 104.62 ±4.44 / 113.32 ms │ no change │
│ QQuery 11 │ 114.14 / 115.40 ±0.93 / 116.61 ms │ 115.22 / 116.47 ±0.84 / 117.51 ms │ no change │
│ QQuery 12 │ 392.38 / 401.17 ±7.89 / 413.77 ms │ 385.79 / 395.55 ±5.71 / 401.43 ms │ no change │
│ QQuery 13 │ 520.28 / 526.87 ±4.99 / 535.69 ms │ 472.00 / 501.98 ±25.30 / 530.85 ms │ no change │
│ QQuery 14 │ 373.95 / 384.62 ±9.60 / 399.88 ms │ 369.82 / 374.51 ±5.01 / 384.02 ms │ no change │
│ QQuery 15 │ 394.87 / 405.13 ±13.81 / 431.21 ms │ 402.01 / 422.70 ±15.12 / 445.64 ms │ no change │
│ QQuery 16 │ 764.82 / 807.57 ±53.42 / 910.88 ms │ 788.90 / 841.02 ±41.14 / 885.78 ms │ no change │
│ QQuery 17 │ 828.38 / 859.32 ±44.79 / 947.66 ms │ 803.14 / 837.80 ±22.10 / 872.30 ms │ no change │
│ QQuery 18 │ 1548.51 / 1615.46 ±59.44 / 1716.75 ms │ 1573.60 / 1601.94 ±24.20 / 1644.64 ms │ no change │
│ QQuery 19 │ 39.08 / 41.51 ±2.02 / 43.96 ms │ 36.72 / 52.85 ±18.19 / 75.45 ms │ 1.27x slower │
│ QQuery 20 │ 731.99 / 753.14 ±23.93 / 782.73 ms │ 732.74 / 744.08 ±15.70 / 775.01 ms │ no change │
│ QQuery 21 │ 758.03 / 773.31 ±10.67 / 785.74 ms │ 777.68 / 788.73 ±8.08 / 799.34 ms │ no change │
│ QQuery 22 │ 1140.22 / 1158.01 ±14.57 / 1182.18 ms │ 1171.40 / 1177.96 ±4.95 / 1183.32 ms │ no change │
│ QQuery 23 │ 3315.37 / 3360.75 ±42.69 / 3431.86 ms │ 3215.09 / 3327.56 ±82.92 / 3455.68 ms │ no change │
│ QQuery 24 │ 110.69 / 113.19 ±1.33 / 114.60 ms │ 103.03 / 107.60 ±4.81 / 116.84 ms │ no change │
│ QQuery 25 │ 146.82 / 148.36 ±1.65 / 151.35 ms │ 145.30 / 148.85 ±2.17 / 151.16 ms │ no change │
│ QQuery 26 │ 107.85 / 110.71 ±1.94 / 113.07 ms │ 110.34 / 111.54 ±0.80 / 112.80 ms │ no change │
│ QQuery 27 │ 866.17 / 877.20 ±8.77 / 888.10 ms │ 874.83 / 885.15 ±7.26 / 895.87 ms │ no change │
│ QQuery 28 │ 7821.26 / 7868.33 ±35.20 / 7925.14 ms │ 7772.35 / 7842.68 ±37.65 / 7873.23 ms │ no change │
│ QQuery 29 │ 335.36 / 342.21 ±11.29 / 364.59 ms │ 331.77 / 336.82 ±8.28 / 353.26 ms │ no change │
│ QQuery 30 │ 381.88 / 401.80 ±12.98 / 412.90 ms │ 380.79 / 388.94 ±8.09 / 403.28 ms │ no change │
│ QQuery 31 │ 393.74 / 405.24 ±10.67 / 425.37 ms │ 388.56 / 404.08 ±14.66 / 427.78 ms │ no change │
│ QQuery 32 │ 1102.89 / 1157.09 ±37.84 / 1190.63 ms │ 1211.61 / 1240.06 ±29.69 / 1296.38 ms │ 1.07x slower │
│ QQuery 33 │ 1554.30 / 1647.29 ±48.42 / 1696.19 ms │ 1521.92 / 1540.66 ±11.17 / 1552.84 ms │ +1.07x faster │
│ QQuery 34 │ 1638.11 / 1679.34 ±25.87 / 1712.07 ms │ 1618.33 / 1670.16 ±26.24 / 1690.13 ms │ no change │
│ QQuery 35 │ 428.08 / 434.97 ±6.62 / 445.96 ms │ 425.68 / 434.68 ±6.36 / 444.46 ms │ no change │
│ QQuery 36 │ 122.88 / 128.04 ±3.09 / 132.51 ms │ 123.75 / 127.50 ±1.92 / 128.86 ms │ no change │
│ QQuery 37 │ 50.33 / 51.51 ±1.01 / 53.12 ms │ 50.95 / 51.95 ±0.67 / 52.86 ms │ no change │
│ QQuery 38 │ 78.02 / 79.07 ±0.99 / 80.79 ms │ 76.38 / 78.08 ±0.96 / 79.22 ms │ no change │
│ QQuery 39 │ 237.69 / 253.14 ±7.93 / 260.31 ms │ 229.67 / 242.74 ±9.46 / 258.38 ms │ no change │
│ QQuery 40 │ 26.30 / 28.52 ±2.66 / 33.63 ms │ 27.91 / 29.69 ±1.86 / 32.85 ms │ no change │
│ QQuery 41 │ 22.84 / 23.75 ±0.51 / 24.31 ms │ 22.42 / 24.68 ±1.83 / 27.57 ms │ no change │
│ QQuery 42 │ 23.34 / 23.83 ±0.33 / 24.30 ms │ 22.46 / 23.24 ±0.58 / 24.07 ms │ no change │
└───────────┴───────────────────────────────────────┴───────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 29248.08ms │
│ Total Time (batched-accumulator-storage) │ 29119.76ms │
│ Average Time (HEAD) │ 680.19ms │
│ Average Time (batched-accumulator-storage) │ 677.20ms │
│ Queries Faster │ 4 │
│ Queries Slower │ 2 │
│ Queries with No Change │ 37 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴────────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**clickbench_partitioned — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 147.5s |
| Peak memory | 42.0 GiB |
| Avg memory | 31.7 GiB |
| CPU user | 1380.9s |
| CPU sys | 96.4s |
| Disk read | 0 B |
| Disk write | 3.3 GiB |
**clickbench_partitioned — branch**
| Metric | Value |
|--------|-------|
| Wall time | 146.8s |
| Peak memory | 43.2 GiB |
| Avg memory | 32.0 GiB |
| CPU user | 1377.8s |
| CPU sys | 96.2s |
| Disk read | 0 B |
| Disk write | 116.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068631415
run benchmarks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068823210
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068698039)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ QQuery 1 │ 46.68 / 47.66 ±0.98 / 49.53 ms │ 48.66 / 49.20 ±0.64 / 50.44 ms │ no change │
│ QQuery 2 │ 25.35 / 25.70 ±0.44 / 26.46 ms │ 26.19 / 26.56 ±0.30 / 26.95 ms │ no change │
│ QQuery 3 │ 34.05 / 34.17 ±0.11 / 34.30 ms │ 34.72 / 35.05 ±0.23 / 35.42 ms │ no change │
│ QQuery 4 │ 21.91 / 23.31 ±0.98 / 24.20 ms │ 22.62 / 22.83 ±0.28 / 23.38 ms │ no change │
│ QQuery 5 │ 51.13 / 53.51 ±1.75 / 55.52 ms │ 53.46 / 55.32 ±1.49 / 57.45 ms │ no change │
│ QQuery 6 │ 17.89 / 17.99 ±0.12 / 18.21 ms │ 18.12 / 18.45 ±0.17 / 18.58 ms │ no change │
│ QQuery 7 │ 57.44 / 59.20 ±1.76 / 61.77 ms │ 60.14 / 60.77 ±0.67 / 61.82 ms │ no change │
│ QQuery 8 │ 51.98 / 52.41 ±0.36 / 52.85 ms │ 53.10 / 54.50 ±1.40 / 57.17 ms │ no change │
│ QQuery 9 │ 56.94 / 58.39 ±1.06 / 59.93 ms │ 58.64 / 59.44 ±1.23 / 61.86 ms │ no change │
│ QQuery 10 │ 76.13 / 77.24 ±0.56 / 77.63 ms │ 76.29 / 77.71 ±1.23 / 79.85 ms │ no change │
│ QQuery 11 │ 17.64 / 17.90 ±0.18 / 18.18 ms │ 17.93 / 18.37 ±0.36 / 18.84 ms │ no change │
│ QQuery 12 │ 29.21 / 29.84 ±0.34 / 30.16 ms │ 29.50 / 30.01 ±0.39 / 30.58 ms │ no change │
│ QQuery 13 │ 41.11 / 41.55 ±0.46 / 42.31 ms │ 40.68 / 42.14 ±1.25 / 44.38 ms │ no change │
│ QQuery 14 │ 29.98 / 30.19 ±0.16 / 30.39 ms │ 30.35 / 30.84 ±0.68 / 32.17 ms │ no change │
│ QQuery 15 │ 37.10 / 38.24 ±1.05 / 40.12 ms │ 37.92 / 38.62 ±0.95 / 40.43 ms │ no change │
│ QQuery 16 │ 18.95 / 19.22 ±0.35 / 19.91 ms │ 18.84 / 19.61 ±0.70 / 20.80 ms │ no change │
│ QQuery 17 │ 78.48 / 80.40 ±1.64 / 82.80 ms │ 82.62 / 84.28 ±1.65 / 86.75 ms │ no change │
│ QQuery 18 │ 82.32 / 84.20 ±1.35 / 85.51 ms │ 85.46 / 86.02 ±0.54 / 86.81 ms │ no change │
│ QQuery 19 │ 40.73 / 41.36 ±0.49 / 41.98 ms │ 39.75 / 41.04 ±1.19 / 42.77 ms │ no change │
│ QQuery 20 │ 45.08 / 45.69 ±0.40 / 46.25 ms │ 45.23 / 46.20 ±0.70 / 47.31 ms │ no change │
│ QQuery 21 │ 72.72 / 74.59 ±1.75 / 77.29 ms │ 73.67 / 74.56 ±0.82 / 76.02 ms │ no change │
│ QQuery 22 │ 21.24 / 22.08 ±1.07 / 23.87 ms │ 21.05 / 21.53 ±0.49 / 22.35 ms │ no change │
└───────────┴────────────────────────────────┴────────────────────────────────┴───────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩
│ Total Time (HEAD) │ 974.88ms │
│ Total Time (batched-accumulator-storage) │ 993.05ms │
│ Average Time (HEAD) │ 44.31ms │
│ Average Time (batched-accumulator-storage) │ 45.14ms │
│ Queries Faster │ 0 │
│ Queries Slower │ 0 │
│ Queries with No Change │ 22 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴──────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpch — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 5.2s |
| Peak memory | 3.9 GiB |
| Avg memory | 3.5 GiB |
| CPU user | 34.6s |
| CPU sys | 3.3s |
| Disk read | 0 B |
| Disk write | 152.0 KiB |
**tpch — branch**
| Metric | Value |
|--------|-------|
| Wall time | 5.2s |
| Peak memory | 3.9 GiB |
| Avg memory | 3.5 GiB |
| CPU user | 35.4s |
| CPU sys | 3.2s |
| Disk read | 0 B |
| Disk write | 56.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068718187
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068698039)
`Linux bench-c4068698039-328-fxnxc 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (1ae75c7a5e0256d18053dc6f026d12b712ca8d56) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..1ae75c7a5e0256d18053dc6f026d12b712ca8d56) using: tpcds
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068544581
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068525672)
`Linux bench-c4068525672-322-tk55f 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (495b6f20d5f5fd5b6851877f1c43f290f142d95e) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..495b6f20d5f5fd5b6851877f1c43f290f142d95e) using: tpcds
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4069055822
run benchmark clickbench_extended
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Batched accumulator storage for hash aggregation [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068451493
run benchmarks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068474086
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068451493)
`Linux bench-c4068451493-316-gxhjh 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (771c89be60f89b801f332320553062971c8e58e9) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..771c89be60f89b801f332320553062971c8e58e9) using: tpcds
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068634586
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068631415)
`Linux bench-c4068631415-324-d5b7j 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (f10afbcee7201d90f9621ae6e56f36d001cdcb28) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..f10afbcee7201d90f9621ae6e56f36d001cdcb28) using: clickbench_partitioned
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068797591
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068631415)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark tpcds_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 51.15 / 52.29 ±0.64 / 53.00 ms │ 50.64 / 52.22 ±0.83 / 52.96 ms │ no change │
│ QQuery 2 │ 156.27 / 157.30 ±0.63 / 158.12 ms │ 154.32 / 155.53 ±0.86 / 156.71 ms │ no change │
│ QQuery 3 │ 120.23 / 120.85 ±0.62 / 121.96 ms │ 120.03 / 121.40 ±0.79 / 122.47 ms │ no change │
│ QQuery 4 │ 1338.36 / 1374.31 ±27.73 / 1423.98 ms │ 1364.49 / 1433.15 ±47.57 / 1493.67 ms │ no change │
│ QQuery 5 │ 188.61 / 190.34 ±1.44 / 192.75 ms │ 186.16 / 186.80 ±1.03 / 188.83 ms │ no change │
│ QQuery 6 │ 1008.47 / 1034.15 ±30.09 / 1088.22 ms │ 1000.89 / 1038.52 ±26.50 / 1071.67 ms │ no change │
│ QQuery 7 │ 361.82 / 365.21 ±3.35 / 371.41 ms │ 359.54 / 364.19 ±5.48 / 374.62 ms │ no change │
│ QQuery 8 │ 124.24 / 125.44 ±0.80 / 126.40 ms │ 122.52 / 124.37 ±1.85 / 127.01 ms │ no change │
│ QQuery 9 │ 113.63 / 118.85 ±2.68 / 121.25 ms │ 118.20 / 119.09 ±0.77 / 120.50 ms │ no change │
│ QQuery 10 │ 116.14 / 117.73 ±1.49 / 120.38 ms │ 115.05 / 117.28 ±1.80 / 119.70 ms │ no change │
│ QQuery 11 │ 976.31 / 988.74 ±7.90 / 997.08 ms │ 981.19 / 996.86 ±13.27 / 1013.29 ms │ no change │
│ QQuery 12 │ 48.42 / 50.59 ±2.45 / 54.61 ms │ 48.45 / 49.29 ±1.00 / 51.15 ms │ no change │
│ QQuery 13 │ 416.72 / 420.06 ±2.79 / 425.16 ms │ 407.09 / 411.13 ±3.93 / 417.88 ms │ no change │
│ QQuery 14 │ 1118.02 / 1126.85 ±9.14 / 1138.28 ms │ 1103.99 / 1116.10 ±10.76 / 1135.36 ms │ no change │
│ QQuery 15 │ 18.71 / 20.31 ±0.88 / 21.29 ms │ 18.31 / 19.62 ±1.25 / 21.82 ms │ no change │
│ QQuery 16 │ 47.61 / 48.04 ±0.31 / 48.52 ms │ 46.16 / 47.73 ±0.99 / 48.76 ms │ no change │
│ QQuery 17 │ 252.01 / 254.62 ±2.77 / 258.48 ms │ 257.17 / 258.88 ±1.22 / 260.89 ms │ no change │
│ QQuery 18 │ 133.74 / 135.55 ±1.69 / 138.28 ms │ 135.43 / 136.49 ±0.58 / 137.12 ms │ no change │
│ QQuery 19 │ 169.80 / 172.19 ±1.58 / 174.33 ms │ 169.15 / 170.27 ±1.19 / 172.44 ms │ no change │
│ QQuery 20 │ 17.05 / 17.43 ±0.26 / 17.75 ms │ 16.80 / 17.37 ±0.44 / 18.11 ms │ no change │
│ QQuery 21 │ 25.25 / 25.75 ±0.28 / 26.02 ms │ 25.14 / 25.74 ±0.37 / 26.24 ms │ no change │
│ QQuery 22 │ 519.40 / 525.60 ±4.23 / 531.77 ms │ 525.94 / 540.13 ±10.73 / 554.96 ms │ no change │
│ QQuery 23 │ 954.87 / 985.13 ±22.95 / 1022.12 ms │ 962.67 / 981.67 ±18.20 / 1012.95 ms │ no change │
│ QQuery 24 │ 434.94 / 442.94 ±4.23 / 446.39 ms │ 447.93 / 450.39 ±2.64 / 455.03 ms │ no change │
│ QQuery 25 │ 364.02 / 370.10 ±5.20 / 379.05 ms │ 364.69 / 370.98 ±4.49 / 377.51 ms │ no change │
│ QQuery 26 │ 86.87 / 88.42 ±1.18 / 90.15 ms │ 82.94 / 86.40 ±2.15 / 88.45 ms │ no change │
│ QQuery 27 │ 352.43 / 355.35 ±1.95 / 358.43 ms │ 353.78 / 358.90 ±3.71 / 362.69 ms │ no change │
│ QQuery 28 │ 153.33 / 155.27 ±1.93 / 158.95 ms │ 154.30 / 155.36 ±0.81 / 156.48 ms │ no change │
│ QQuery 29 │ 309.47 / 311.49 ±1.63 / 313.55 ms │ 308.57 / 312.29 ±2.40 / 314.89 ms │ no change │
│ QQuery 30 │ 49.39 / 50.53 ±1.00 / 52.16 ms │ 49.55 / 50.40 ±0.73 / 51.27 ms │ no change │
│ QQuery 31 │ 185.45 / 188.80 ±2.33 / 191.51 ms │ 184.72 / 187.35 ±2.89 / 192.08 ms │ no change │
│ QQuery 32 │ 63.21 / 64.71 ±1.06 / 66.07 ms │ 63.61 / 64.40 ±0.63 / 65.27 ms │ no change │
│ QQuery 33 │ 150.24 / 152.36 ±1.51 / 154.47 ms │ 150.91 / 152.85 ±1.01 / 153.78 ms │ no change │
│ QQuery 34 │ 115.37 / 116.90 ±1.83 / 120.39 ms │ 110.78 / 113.10 ±2.25 / 117.25 ms │ no change │
│ QQuery 35 │ 120.64 / 121.92 ±1.10 / 123.70 ms │ 117.45 / 120.04 ±1.69 / 122.42 ms │ no change │
│ QQuery 36 │ 223.83 / 229.52 ±4.32 / 233.81 ms │ 221.96 / 229.71 ±4.26 / 233.28 ms │ no change │
│ QQuery 37 │ 184.54 / 187.40 ±1.73 / 189.51 ms │ 182.39 / 185.15 ±2.55 / 189.84 ms │ no change │
│ QQuery 38 │ 93.48 / 95.73 ±2.17 / 99.59 ms │ 95.04 / 97.98 ±3.49 / 104.01 ms │ no change │
│ QQuery 39 │ 143.16 / 144.86 ±1.83 / 148.37 ms │ 139.40 / 142.62 ±2.79 / 147.06 ms │ no change │
│ QQuery 40 │ 117.17 / 124.56 ±7.03 / 137.67 ms │ 118.79 / 124.73 ±5.55 / 135.00 ms │ no change │
│ QQuery 41 │ 18.32 / 20.44 ±1.36 / 21.72 ms │ 17.01 / 18.18 ±1.16 / 20.11 ms │ +1.12x faster │
│ QQuery 42 │ 114.62 / 115.88 ±0.72 / 116.59 ms │ 110.11 / 111.60 ±0.93 / 112.47 ms │ no change │
│ QQuery 43 │ 88.32 / 89.11 ±0.63 / 89.92 ms │ 88.33 / 88.52 ±0.13 / 88.67 ms │ no change │
│ QQuery 44 │ 18.14 / 18.45 ±0.32 / 18.96 ms │ 17.21 / 18.12 ±0.73 / 19.26 ms │ no change │
│ QQuery 45 │ 58.66 / 59.79 ±1.16 / 61.79 ms │ 56.32 / 57.76 ±1.03 / 59.52 ms │ no change │
│ QQuery 46 │ 248.19 / 256.58 ±4.60 / 261.69 ms │ 234.52 / 237.91 ±1.82 / 239.65 ms │ +1.08x faster │
│ QQuery 47 │ 724.79 / 750.41 ±14.33 / 769.08 ms │ 747.96 / 809.96 ±31.55 / 833.94 ms │ 1.08x slower │
│ QQuery 48 │ 288.69 / 296.56 ±4.39 / 302.22 ms │ 294.88 / 301.17 ±5.60 / 308.14 ms │ no change │
│ QQuery 49 │ 263.08 / 267.75 ±3.60 / 273.09 ms │ 267.63 / 269.81 ±2.08 / 273.11 ms │ no change │
│ QQuery 50 │ 244.88 / 252.48 ±6.42 / 261.76 ms │ 247.17 / 257.23 ±6.12 / 263.93 ms │ no change │
│ QQuery 51 │ 196.74 / 198.45 ±1.31 / 199.99 ms │ 194.01 / 198.68 ±2.96 / 202.14 ms │ no change │
│ QQuery 52 │ 113.99 / 115.79 ±1.63 / 118.13 ms │ 111.59 / 113.90 ±1.49 / 115.69 ms │ no change │
│ QQuery 53 │ 108.12 / 110.40 ±2.28 / 113.24 ms │ 109.64 / 111.00 ±1.48 / 113.55 ms │ no change │
│ QQuery 54 │ 154.62 / 157.90 ±1.74 / 159.37 ms │ 160.28 / 161.22 ±0.84 / 162.65 ms │ no change │
│ QQuery 55 │ 110.97 / 112.30 ±0.90 / 113.29 ms │ 112.78 / 113.77 ±1.35 / 116.39 ms │ no change │
│ QQuery 56 │ 152.76 / 154.55 ±1.16 / 156.23 ms │ 152.06 / 155.42 ±2.20 / 158.56 ms │ no change │
│ QQuery 57 │ 192.80 / 193.55 ±0.56 / 194.25 ms │ 191.95 / 195.43 ±2.94 / 200.17 ms │ no change │
│ QQuery 58 │ 319.48 / 324.45 ±3.46 / 328.63 ms │ 306.99 / 324.69 ±12.06 / 344.66 ms │ no change │
│ QQuery 59 │ 212.07 / 213.61 ±2.12 / 217.75 ms │ 212.60 / 214.35 ±1.90 / 218.03 ms │ no change │
│ QQuery 60 │ 156.53 / 158.04 ±1.17 / 159.91 ms │ 153.30 / 155.72 ±1.61 / 158.19 ms │ no change │
│ QQuery 61 │ 179.51 / 183.22 ±2.94 / 188.44 ms │ 179.23 / 182.90 ±3.70 / 188.85 ms │ no change │
│ QQuery 62 │ 901.87 / 935.96 ±33.56 / 995.26 ms │ 906.23 / 937.23 ±25.88 / 968.38 ms │ no change │
│ QQuery 63 │ 111.73 / 113.80 ±2.31 / 117.57 ms │ 109.38 / 113.69 ±3.82 / 119.62 ms │ no change │
│ QQuery 64 │ 724.65 / 739.37 ±9.85 / 751.73 ms │ 727.77 / 737.31 ±6.73 / 747.59 ms │ no change │
│ QQuery 65 │ 279.31 / 282.78 ±3.29 / 288.69 ms │ 276.74 / 282.73 ±3.14 / 285.60 ms │ no change │
│ QQuery 66 │ 262.41 / 270.13 ±8.50 / 286.08 ms │ 253.01 / 271.76 ±13.67 / 288.74 ms │ no change │
│ QQuery 67 │ 349.46 / 361.13 ±13.09 / 381.94 ms │ 359.37 / 361.68 ±1.58 / 363.58 ms │ no change │
│ QQuery 68 │ 286.34 / 292.51 ±4.48 / 300.26 ms │ 288.36 / 295.30 ±7.24 / 307.27 ms │ no change │
│ QQuery 69 │ 116.61 / 117.74 ±1.22 / 119.60 ms │ 114.84 / 117.38 ±1.56 / 119.42 ms │ no change │
│ QQuery 70 │ 338.90 / 358.63 ±11.82 / 376.12 ms │ 359.89 / 369.85 ±11.74 / 389.73 ms │ no change │
│ QQuery 71 │ 142.06 / 144.52 ±1.72 / 146.43 ms │ 144.42 / 145.99 ±1.76 / 148.19 ms │ no change │
│ QQuery 72 │ 718.30 / 738.67 ±12.54 / 756.75 ms │ 733.91 / 747.88 ±14.02 / 768.09 ms │ no change │
│ QQuery 73 │ 107.69 / 111.84 ±2.68 / 115.29 ms │ 105.33 / 107.39 ±1.29 / 109.28 ms │ no change │
│ QQuery 74 │ 619.72 / 645.94 ±28.11 / 681.91 ms │ 618.49 / 658.03 ±31.23 / 697.79 ms │ no change │
│ QQuery 75 │ 292.21 / 296.10 ±3.25 / 300.40 ms │ 292.93 / 298.56 ±3.01 / 302.06 ms │ no change │
│ QQuery 76 │ 137.48 / 140.34 ±2.06 / 143.45 ms │ 141.14 / 142.64 ±1.35 / 144.37 ms │ no change │
│ QQuery 77 │ 204.19 / 205.97 ±1.90 / 209.65 ms │ 206.00 / 208.67 ±1.56 / 210.57 ms │ no change │
│ QQuery 78 │ 365.22 / 368.49 ±2.58 / 373.11 ms │ 367.48 / 376.72 ±6.38 / 387.08 ms │ no change │
│ QQuery 79 │ 238.68 / 245.57 ±6.28 / 257.26 ms │ 243.19 / 248.62 ±7.03 / 262.46 ms │ no change │
│ QQuery 80 │ 344.93 / 346.39 ±1.39 / 348.30 ms │ 352.95 / 353.36 ±0.35 / 353.96 ms │ no change │
│ QQuery 81 │ 31.23 / 32.17 ±0.64 / 33.22 ms │ 33.01 / 34.07 ±0.87 / 35.11 ms │ 1.06x slower │
│ QQuery 82 │ 205.46 / 208.81 ±3.44 / 214.39 ms │ 209.13 / 210.70 ±1.28 / 212.47 ms │ no change │
│ QQuery 83 │ 49.43 / 51.16 ±1.22 / 52.94 ms │ 49.93 / 51.31 ±0.84 / 52.22 ms │ no change │
│ QQuery 84 │ 52.65 / 55.47 ±2.29 / 58.89 ms │ 52.73 / 53.72 ±1.42 / 56.41 ms │ no change │
│ QQuery 85 │ 156.31 / 158.72 ±2.12 / 162.54 ms │ 153.26 / 157.25 ±2.40 / 159.65 ms │ no change │
│ QQuery 86 │ 42.10 / 43.19 ±0.83 / 44.19 ms │ 42.33 / 43.16 ±0.51 / 43.73 ms │ no change │
│ QQuery 87 │ 99.09 / 101.57 ±2.81 / 106.12 ms │ 95.07 / 98.01 ±3.10 / 102.43 ms │ no change │
│ QQuery 88 │ 118.38 / 119.49 ±1.20 / 121.48 ms │ 116.07 / 118.17 ±2.18 / 122.09 ms │ no change │
│ QQuery 89 │ 125.92 / 128.31 ±1.81 / 131.15 ms │ 126.00 / 128.59 ±1.72 / 131.29 ms │ no change │
│ QQuery 90 │ 28.84 / 29.45 ±0.39 / 30.05 ms │ 29.05 / 29.73 ±0.63 / 30.85 ms │ no change │
│ QQuery 91 │ 66.45 / 67.81 ±0.89 / 69.04 ms │ 67.49 / 68.64 ±0.71 / 69.40 ms │ no change │
│ QQuery 92 │ 64.29 / 65.11 ±1.08 / 67.12 ms │ 63.60 / 64.35 ±0.53 / 65.03 ms │ no change │
│ QQuery 93 │ 205.03 / 206.70 ±1.19 / 208.25 ms │ 204.44 / 206.73 ±1.79 / 209.88 ms │ no change │
│ QQuery 94 │ 68.49 / 69.76 ±0.97 / 71.35 ms │ 68.03 / 69.33 ±1.19 / 71.25 ms │ no change │
│ QQuery 95 │ 145.89 / 148.87 ±1.59 / 150.57 ms │ 147.26 / 148.42 ±1.14 / 150.44 ms │ no change │
│ QQuery 96 │ 81.62 / 82.23 ±0.52 / 82.98 ms │ 80.52 / 81.79 ±1.08 / 83.71 ms │ no change │
│ QQuery 97 │ 139.86 / 143.19 ±2.02 / 145.85 ms │ 135.13 / 138.83 ±2.98 / 143.55 ms │ no change │
│ QQuery 98 │ 157.11 / 161.42 ±3.21 / 165.89 ms │ 155.19 / 159.35 ±2.80 / 163.23 ms │ no change │
│ QQuery 99 │ 10799.96 / 10818.86 ±13.67 / 10840.12 ms │ 10734.37 / 10825.87 ±51.04 / 10881.37 ms │ no change │
└───────────┴──────────────────────────────────────────┴──────────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 35086.05ms │
│ Total Time (batched-accumulator-storage) │ 35246.61ms │
│ Average Time (HEAD) │ 354.40ms │
│ Average Time (batched-accumulator-storage) │ 356.03ms │
│ Queries Faster │ 2 │
│ Queries Slower │ 2 │
│ Queries with No Change │ 95 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴────────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpcds — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 175.8s |
| Peak memory | 5.6 GiB |
| Avg memory | 4.6 GiB |
| CPU user | 278.7s |
| CPU sys | 22.1s |
| Disk read | 0 B |
| Disk write | 636.1 MiB |
**tpcds — branch**
| Metric | Value |
|--------|-------|
| Wall time | 176.5s |
| Peak memory | 5.5 GiB |
| Avg memory | 4.4 GiB |
| CPU user | 280.1s |
| CPU sys | 21.8s |
| Disk read | 0 B |
| Disk write | 144.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068713031
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068698039)
`Linux bench-c4068698039-327-xgf8w 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (1ae75c7a5e0256d18053dc6f026d12b712ca8d56) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..1ae75c7a5e0256d18053dc6f026d12b712ca8d56) using: clickbench_partitioned
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068521534
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068495691)
`Linux bench-c4068495691-320-6clwj 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (495b6f20d5f5fd5b6851877f1c43f290f142d95e) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..495b6f20d5f5fd5b6851877f1c43f290f142d95e) using: tpch
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068611646
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068495691)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 47.26 / 48.23 ±0.81 / 49.44 ms │ 48.23 / 48.72 ±0.82 / 50.35 ms │ no change │
│ QQuery 2 │ 24.95 / 25.52 ±0.53 / 26.36 ms │ 26.75 / 26.99 ±0.29 / 27.54 ms │ 1.06x slower │
│ QQuery 3 │ 33.76 / 34.68 ±1.35 / 37.36 ms │ 35.60 / 35.79 ±0.18 / 36.00 ms │ no change │
│ QQuery 4 │ 22.09 / 24.15 ±1.06 / 24.94 ms │ 22.66 / 23.67 ±0.62 / 24.41 ms │ no change │
│ QQuery 5 │ 53.11 / 55.10 ±1.38 / 57.26 ms │ 54.41 / 56.16 ±1.60 / 58.75 ms │ no change │
│ QQuery 6 │ 18.29 / 18.49 ±0.19 / 18.74 ms │ 18.67 / 19.11 ±0.61 / 20.30 ms │ no change │
│ QQuery 7 │ 59.72 / 61.86 ±2.46 / 66.68 ms │ 61.32 / 62.80 ±1.11 / 64.28 ms │ no change │
│ QQuery 8 │ 52.97 / 53.77 ±0.77 / 55.09 ms │ 54.30 / 54.93 ±0.57 / 55.87 ms │ no change │
│ QQuery 9 │ 57.97 / 58.89 ±0.66 / 60.04 ms │ 59.84 / 61.79 ±1.37 / 63.60 ms │ no change │
│ QQuery 10 │ 75.57 / 76.57 ±0.63 / 77.50 ms │ 77.46 / 79.78 ±1.58 / 82.33 ms │ no change │
│ QQuery 11 │ 17.45 / 17.63 ±0.17 / 17.91 ms │ 18.61 / 19.23 ±0.71 / 20.59 ms │ 1.09x slower │
│ QQuery 12 │ 29.41 / 31.40 ±2.40 / 35.97 ms │ 29.25 / 29.72 ±0.28 / 30.08 ms │ +1.06x faster │
│ QQuery 13 │ 41.93 / 42.75 ±0.74 / 43.85 ms │ 42.16 / 43.61 ±0.99 / 45.08 ms │ no change │
│ QQuery 14 │ 30.26 / 30.71 ±0.31 / 31.11 ms │ 30.02 / 31.05 ±0.87 / 32.53 ms │ no change │
│ QQuery 15 │ 37.31 / 38.05 ±0.39 / 38.42 ms │ 37.47 / 38.50 ±0.94 / 40.17 ms │ no change │
│ QQuery 16 │ 18.66 / 19.05 ±0.22 / 19.33 ms │ 18.82 / 19.21 ±0.32 / 19.76 ms │ no change │
│ QQuery 17 │ 76.72 / 81.29 ±3.48 / 86.44 ms │ 77.14 / 78.28 ±0.58 / 78.71 ms │ no change │
│ QQuery 18 │ 83.31 / 83.85 ±0.66 / 85.14 ms │ 86.26 / 88.09 ±1.12 / 89.28 ms │ 1.05x slower │
│ QQuery 19 │ 39.65 / 40.06 ±0.33 / 40.59 ms │ 41.25 / 42.47 ±0.96 / 44.21 ms │ 1.06x slower │
│ QQuery 20 │ 43.25 / 44.98 ±1.29 / 47.07 ms │ 46.58 / 47.76 ±0.80 / 48.89 ms │ 1.06x slower │
│ QQuery 21 │ 69.85 / 71.34 ±1.08 / 72.92 ms │ 77.11 / 78.38 ±1.10 / 79.78 ms │ 1.10x slower │
│ QQuery 22 │ 20.15 / 20.41 ±0.26 / 20.90 ms │ 21.28 / 21.97 ±0.81 / 23.43 ms │ 1.08x slower │
└───────────┴────────────────────────────────┴────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD) │ 978.80ms │
│ Total Time (batched-accumulator-storage) │ 1008.02ms │
│ Average Time (HEAD) │ 44.49ms │
│ Average Time (batched-accumulator-storage) │ 45.82ms │
│ Queries Faster │ 1 │
│ Queries Slower │ 7 │
│ Queries with No Change │ 14 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴───────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpch — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 5.2s |
| Peak memory | 3.9 GiB |
| Avg memory | 3.5 GiB |
| CPU user | 34.9s |
| CPU sys | 3.3s |
| Disk read | 0 B |
| Disk write | 136.0 KiB |
**tpch — branch**
| Metric | Value |
|--------|-------|
| Wall time | 5.3s |
| Peak memory | 3.9 GiB |
| Avg memory | 3.5 GiB |
| CPU user | 35.7s |
| CPU sys | 3.4s |
| Disk read | 0 B |
| Disk write | 56.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068609724
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068525672)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 47.25 / 47.80 ±0.70 / 49.10 ms │ 46.92 / 48.05 ±0.85 / 49.20 ms │ no change │
│ QQuery 2 │ 25.20 / 25.54 ±0.44 / 26.39 ms │ 24.37 / 24.65 ±0.23 / 24.96 ms │ no change │
│ QQuery 3 │ 34.35 / 35.15 ±1.18 / 37.47 ms │ 33.24 / 33.77 ±0.45 / 34.59 ms │ no change │
│ QQuery 4 │ 22.28 / 23.20 ±0.61 / 23.74 ms │ 21.62 / 22.37 ±0.52 / 23.08 ms │ no change │
│ QQuery 5 │ 51.90 / 53.24 ±1.45 / 55.24 ms │ 49.92 / 52.51 ±1.59 / 53.89 ms │ no change │
│ QQuery 6 │ 18.01 / 18.18 ±0.17 / 18.48 ms │ 17.57 / 17.77 ±0.15 / 17.98 ms │ no change │
│ QQuery 7 │ 56.58 / 59.60 ±2.24 / 62.92 ms │ 56.44 / 57.47 ±0.75 / 58.32 ms │ no change │
│ QQuery 8 │ 52.17 / 52.77 ±0.61 / 53.90 ms │ 50.55 / 50.83 ±0.30 / 51.35 ms │ no change │
│ QQuery 9 │ 57.24 / 59.51 ±1.24 / 60.86 ms │ 56.15 / 56.81 ±0.38 / 57.20 ms │ no change │
│ QQuery 10 │ 72.84 / 74.93 ±1.17 / 76.03 ms │ 72.18 / 73.90 ±2.08 / 77.94 ms │ no change │
│ QQuery 11 │ 17.01 / 17.28 ±0.24 / 17.66 ms │ 16.12 / 16.38 ±0.30 / 16.96 ms │ +1.06x faster │
│ QQuery 12 │ 29.37 / 29.80 ±0.30 / 30.23 ms │ 28.47 / 28.79 ±0.27 / 29.20 ms │ no change │
│ QQuery 13 │ 40.14 / 41.03 ±0.50 / 41.65 ms │ 40.36 / 40.93 ±0.33 / 41.25 ms │ no change │
│ QQuery 14 │ 29.61 / 30.12 ±0.49 / 31.03 ms │ 29.04 / 29.52 ±0.66 / 30.83 ms │ no change │
│ QQuery 15 │ 36.38 / 37.47 ±0.84 / 38.90 ms │ 36.00 / 36.54 ±0.54 / 37.23 ms │ no change │
│ QQuery 16 │ 17.84 / 18.29 ±0.37 / 18.86 ms │ 17.49 / 18.08 ±0.56 / 18.97 ms │ no change │
│ QQuery 17 │ 74.57 / 75.27 ±0.65 / 76.06 ms │ 74.33 / 75.09 ±0.49 / 75.87 ms │ no change │
│ QQuery 18 │ 80.34 / 81.60 ±1.18 / 83.71 ms │ 81.19 / 83.06 ±1.06 / 84.38 ms │ no change │
│ QQuery 19 │ 38.63 / 39.26 ±0.48 / 39.89 ms │ 37.94 / 38.71 ±0.44 / 39.11 ms │ no change │
│ QQuery 20 │ 43.61 / 44.30 ±0.66 / 45.54 ms │ 42.76 / 43.56 ±0.50 / 44.14 ms │ no change │
│ QQuery 21 │ 68.55 / 71.77 ±2.62 / 74.86 ms │ 67.19 / 68.07 ±0.81 / 69.07 ms │ +1.05x faster │
│ QQuery 22 │ 20.20 / 20.45 ±0.14 / 20.61 ms │ 19.45 / 19.71 ±0.17 / 19.91 ms │ no change │
└───────────┴────────────────────────────────┴────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩
│ Total Time (HEAD) │ 956.55ms │
│ Total Time (batched-accumulator-storage) │ 936.57ms │
│ Average Time (HEAD) │ 43.48ms │
│ Average Time (batched-accumulator-storage) │ 42.57ms │
│ Queries Faster │ 2 │
│ Queries Slower │ 0 │
│ Queries with No Change │ 20 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴──────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpch — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 5.1s |
| Peak memory | 4.0 GiB |
| Avg memory | 3.5 GiB |
| CPU user | 34.3s |
| CPU sys | 3.0s |
| Disk read | 0 B |
| Disk write | 148.0 KiB |
**tpch — branch**
| Metric | Value |
|--------|-------|
| Wall time | 4.9s |
| Peak memory | 4.0 GiB |
| Avg memory | 3.5 GiB |
| CPU user | 34.0s |
| CPU sys | 2.9s |
| Disk read | 0 B |
| Disk write | 56.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068653850
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068631415)
`Linux bench-c4068631415-325-jbb9w 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (f4aa988e207794538fb48342f5b9b0ed8e23ac9a) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..f4aa988e207794538fb48342f5b9b0ed8e23ac9a) using: tpcds
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068875617
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068698039)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and batched-accumulator-storage
--------------------
Benchmark tpcds_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ batched-accumulator-storage ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1 │ 48.69 / 50.69 ±1.16 / 52.22 ms │ 51.51 / 52.36 ±0.62 / 53.30 ms │ no change │
│ QQuery 2 │ 156.31 / 158.05 ±1.63 / 160.84 ms │ 157.15 / 158.94 ±1.05 / 160.39 ms │ no change │
│ QQuery 3 │ 119.47 / 120.69 ±1.15 / 122.82 ms │ 121.44 / 122.80 ±1.00 / 123.97 ms │ no change │
│ QQuery 4 │ 1423.06 / 1458.80 ±27.82 / 1501.83 ms │ 1447.71 / 1480.37 ±33.32 / 1542.35 ms │ no change │
│ QQuery 5 │ 185.87 / 187.02 ±1.11 / 188.70 ms │ 185.33 / 188.42 ±2.07 / 191.46 ms │ no change │
│ QQuery 6 │ 1057.89 / 1079.64 ±27.83 / 1132.67 ms │ 1065.50 / 1077.77 ±11.06 / 1094.47 ms │ no change │
│ QQuery 7 │ 372.71 / 376.88 ±2.50 / 380.23 ms │ 366.19 / 369.22 ±3.04 / 373.13 ms │ no change │
│ QQuery 8 │ 124.78 / 126.33 ±0.99 / 127.69 ms │ 123.22 / 127.17 ±2.37 / 129.77 ms │ no change │
│ QQuery 9 │ 112.56 / 117.11 ±3.25 / 120.67 ms │ 113.78 / 117.42 ±3.30 / 122.07 ms │ no change │
│ QQuery 10 │ 117.10 / 119.10 ±1.57 / 121.80 ms │ 114.55 / 116.13 ±1.79 / 119.51 ms │ no change │
│ QQuery 11 │ 1042.64 / 1061.80 ±21.00 / 1101.50 ms │ 1035.30 / 1069.14 ±30.97 / 1119.07 ms │ no change │
│ QQuery 12 │ 49.50 / 51.67 ±1.61 / 54.30 ms │ 47.57 / 49.56 ±1.95 / 53.27 ms │ no change │
│ QQuery 13 │ 412.62 / 416.30 ±3.57 / 422.00 ms │ 411.54 / 421.75 ±8.79 / 433.85 ms │ no change │
│ QQuery 14 │ 1109.53 / 1128.07 ±13.86 / 1147.99 ms │ 1131.29 / 1145.20 ±11.04 / 1160.29 ms │ no change │
│ QQuery 15 │ 19.69 / 20.36 ±0.81 / 21.82 ms │ 19.16 / 20.49 ±1.01 / 21.52 ms │ no change │
│ QQuery 16 │ 48.06 / 48.52 ±0.33 / 48.94 ms │ 46.79 / 48.11 ±1.06 / 49.99 ms │ no change │
│ QQuery 17 │ 260.85 / 264.44 ±2.29 / 266.98 ms │ 263.06 / 265.34 ±1.28 / 266.58 ms │ no change │
│ QQuery 18 │ 140.59 / 141.77 ±0.89 / 143.24 ms │ 138.61 / 139.53 ±0.93 / 140.94 ms │ no change │
│ QQuery 19 │ 171.60 / 173.28 ±1.10 / 174.61 ms │ 172.47 / 174.37 ±1.78 / 177.23 ms │ no change │
│ QQuery 20 │ 17.36 / 17.72 ±0.29 / 18.18 ms │ 16.98 / 17.43 ±0.55 / 18.50 ms │ no change │
│ QQuery 21 │ 24.68 / 25.63 ±0.58 / 26.36 ms │ 25.81 / 26.74 ±0.81 / 28.19 ms │ no change │
│ QQuery 22 │ 556.88 / 571.69 ±13.98 / 597.62 ms │ 580.21 / 582.04 ±1.81 / 585.24 ms │ no change │
│ QQuery 23 │ 1038.95 / 1051.90 ±7.82 / 1058.86 ms │ 1004.13 / 1022.84 ±16.10 / 1046.45 ms │ no change │
│ QQuery 24 │ 443.94 / 449.55 ±6.11 / 461.20 ms │ 437.63 / 448.94 ±9.36 / 464.06 ms │ no change │
│ QQuery 25 │ 367.42 / 374.94 ±6.92 / 385.94 ms │ 368.69 / 380.01 ±7.27 / 389.97 ms │ no change │
│ QQuery 26 │ 88.99 / 91.31 ±2.46 / 95.79 ms │ 85.45 / 88.79 ±2.58 / 93.00 ms │ no change │
│ QQuery 27 │ 352.07 / 362.34 ±6.23 / 368.52 ms │ 361.36 / 365.65 ±4.89 / 374.13 ms │ no change │
│ QQuery 28 │ 154.27 / 156.40 ±3.01 / 162.24 ms │ 154.43 / 159.24 ±4.44 / 166.24 ms │ no change │
│ QQuery 29 │ 314.63 / 320.91 ±4.84 / 325.99 ms │ 315.99 / 324.18 ±4.96 / 330.87 ms │ no change │
│ QQuery 30 │ 51.36 / 53.18 ±1.55 / 55.72 ms │ 53.36 / 54.18 ±0.78 / 55.51 ms │ no change │
│ QQuery 31 │ 187.30 / 191.49 ±3.51 / 197.87 ms │ 185.19 / 190.27 ±3.99 / 195.15 ms │ no change │
│ QQuery 32 │ 62.33 / 63.64 ±0.78 / 64.40 ms │ 62.79 / 64.43 ±1.72 / 67.53 ms │ no change │
│ QQuery 33 │ 152.19 / 156.43 ±2.71 / 159.74 ms │ 151.31 / 157.19 ±4.34 / 163.32 ms │ no change │
│ QQuery 34 │ 111.31 / 112.72 ±1.86 / 116.31 ms │ 113.17 / 117.24 ±4.11 / 122.52 ms │ no change │
│ QQuery 35 │ 120.05 / 122.79 ±2.02 / 125.24 ms │ 119.26 / 122.37 ±3.06 / 126.99 ms │ no change │
│ QQuery 36 │ 224.37 / 230.43 ±5.20 / 238.30 ms │ 224.78 / 232.81 ±5.38 / 239.06 ms │ no change │
│ QQuery 37 │ 185.14 / 190.28 ±4.18 / 197.74 ms │ 190.75 / 194.88 ±3.34 / 200.60 ms │ no change │
│ QQuery 38 │ 96.77 / 102.33 ±3.14 / 106.13 ms │ 95.62 / 104.72 ±4.84 / 109.53 ms │ no change │
│ QQuery 39 │ 140.30 / 145.26 ±5.74 / 152.61 ms │ 143.49 / 150.80 ±8.54 / 164.29 ms │ no change │
│ QQuery 40 │ 117.16 / 126.06 ±6.77 / 138.05 ms │ 120.41 / 124.53 ±4.93 / 134.00 ms │ no change │
│ QQuery 41 │ 17.84 / 19.36 ±1.22 / 21.08 ms │ 17.67 / 18.68 ±1.23 / 21.01 ms │ no change │
│ QQuery 42 │ 112.31 / 115.22 ±2.58 / 119.63 ms │ 115.00 / 116.90 ±1.42 / 118.72 ms │ no change │
│ QQuery 43 │ 88.43 / 89.61 ±1.25 / 91.85 ms │ 89.26 / 90.03 ±0.69 / 91.14 ms │ no change │
│ QQuery 44 │ 17.70 / 18.28 ±0.63 / 19.47 ms │ 18.87 / 19.40 ±0.49 / 20.31 ms │ 1.06x slower │
│ QQuery 45 │ 58.46 / 59.91 ±1.15 / 61.61 ms │ 59.01 / 60.65 ±1.61 / 63.62 ms │ no change │
│ QQuery 46 │ 240.10 / 254.79 ±10.88 / 265.67 ms │ 243.01 / 253.20 ±10.35 / 269.50 ms │ no change │
│ QQuery 47 │ 801.00 / 819.57 ±18.24 / 848.62 ms │ 816.98 / 836.28 ±16.69 / 865.52 ms │ no change │
│ QQuery 48 │ 296.54 / 304.33 ±6.54 / 314.90 ms │ 300.02 / 305.21 ±4.14 / 312.32 ms │ no change │
│ QQuery 49 │ 266.66 / 268.49 ±2.22 / 272.76 ms │ 266.88 / 272.13 ±4.58 / 278.39 ms │ no change │
│ QQuery 50 │ 241.37 / 256.19 ±12.08 / 272.48 ms │ 240.54 / 249.51 ±6.66 / 260.30 ms │ no change │
│ QQuery 51 │ 191.09 / 196.31 ±4.09 / 200.85 ms │ 197.72 / 201.71 ±3.69 / 208.62 ms │ no change │
│ QQuery 52 │ 111.72 / 113.75 ±1.73 / 116.93 ms │ 114.53 / 115.61 ±1.00 / 117.44 ms │ no change │
│ QQuery 53 │ 112.12 / 113.98 ±1.55 / 116.07 ms │ 110.17 / 112.55 ±1.37 / 114.18 ms │ no change │
│ QQuery 54 │ 155.70 / 159.15 ±3.56 / 164.79 ms │ 157.83 / 163.22 ±4.42 / 168.07 ms │ no change │
│ QQuery 55 │ 111.74 / 113.64 ±1.50 / 115.19 ms │ 112.24 / 114.75 ±1.92 / 117.62 ms │ no change │
│ QQuery 56 │ 153.75 / 156.21 ±2.06 / 158.97 ms │ 152.00 / 155.37 ±3.07 / 160.81 ms │ no change │
│ QQuery 57 │ 190.36 / 194.20 ±3.94 / 201.22 ms │ 192.02 / 198.30 ±4.63 / 204.32 ms │ no change │
│ QQuery 58 │ 307.75 / 319.02 ±9.29 / 332.10 ms │ 320.16 / 325.12 ±5.61 / 335.74 ms │ no change │
│ QQuery 59 │ 213.22 / 220.50 ±4.70 / 226.71 ms │ 217.40 / 221.69 ±4.28 / 229.05 ms │ no change │
│ QQuery 60 │ 153.58 / 156.50 ±3.15 / 160.52 ms │ 155.23 / 158.95 ±2.74 / 161.45 ms │ no change │
│ QQuery 61 │ 181.10 / 186.48 ±4.66 / 192.81 ms │ 182.06 / 186.45 ±4.12 / 192.69 ms │ no change │
│ QQuery 62 │ 911.43 / 966.42 ±41.04 / 1021.39 ms │ 938.30 / 966.92 ±28.38 / 1016.22 ms │ no change │
│ QQuery 63 │ 113.35 / 113.81 ±0.33 / 114.23 ms │ 113.20 / 116.84 ±2.64 / 121.38 ms │ no change │
│ QQuery 64 │ 738.62 / 760.28 ±13.59 / 778.18 ms │ 750.71 / 767.79 ±12.59 / 780.22 ms │ no change │
│ QQuery 65 │ 290.75 / 294.70 ±2.53 / 296.81 ms │ 295.54 / 300.84 ±3.24 / 304.79 ms │ no change │
│ QQuery 66 │ 270.61 / 276.53 ±3.92 / 281.06 ms │ 266.36 / 276.26 ±11.96 / 298.94 ms │ no change │
│ QQuery 67 │ 368.92 / 371.88 ±3.71 / 378.40 ms │ 371.50 / 375.55 ±3.53 / 380.93 ms │ no change │
│ QQuery 68 │ 307.96 / 313.00 ±3.54 / 316.99 ms │ 309.64 / 315.36 ±3.90 / 321.44 ms │ no change │
│ QQuery 69 │ 118.78 / 120.88 ±1.95 / 124.51 ms │ 117.86 / 118.80 ±0.72 / 120.03 ms │ no change │
│ QQuery 70 │ 368.04 / 378.97 ±9.22 / 394.89 ms │ 370.42 / 382.83 ±11.02 / 401.62 ms │ no change │
│ QQuery 71 │ 145.18 / 147.59 ±1.31 / 148.78 ms │ 143.65 / 146.97 ±3.34 / 153.38 ms │ no change │
│ QQuery 72 │ 751.65 / 765.85 ±7.76 / 774.07 ms │ 755.93 / 781.33 ±18.03 / 809.95 ms │ no change │
│ QQuery 73 │ 108.93 / 114.91 ±3.27 / 118.35 ms │ 111.01 / 112.03 ±1.00 / 113.90 ms │ no change │
│ QQuery 74 │ 644.35 / 657.15 ±13.92 / 682.36 ms │ 631.36 / 677.43 ±23.47 / 696.06 ms │ no change │
│ QQuery 75 │ 295.62 / 300.57 ±4.37 / 306.37 ms │ 291.61 / 299.63 ±4.71 / 305.98 ms │ no change │
│ QQuery 76 │ 139.34 / 141.06 ±1.33 / 143.21 ms │ 138.90 / 144.33 ±3.57 / 148.64 ms │ no change │
│ QQuery 77 │ 202.13 / 205.63 ±2.04 / 208.16 ms │ 207.23 / 210.34 ±1.81 / 212.29 ms │ no change │
│ QQuery 78 │ 360.90 / 379.41 ±10.26 / 389.02 ms │ 379.01 / 387.58 ±7.83 / 402.32 ms │ no change │
│ QQuery 79 │ 243.29 / 255.30 ±10.90 / 271.42 ms │ 243.65 / 255.53 ±13.61 / 277.56 ms │ no change │
│ QQuery 80 │ 341.92 / 348.85 ±4.36 / 353.79 ms │ 343.93 / 350.70 ±6.92 / 362.46 ms │ no change │
│ QQuery 81 │ 31.91 / 32.93 ±0.79 / 34.32 ms │ 31.97 / 33.62 ±1.43 / 36.07 ms │ no change │
│ QQuery 82 │ 209.22 / 211.88 ±1.61 / 213.93 ms │ 215.06 / 217.87 ±2.63 / 221.86 ms │ no change │
│ QQuery 83 │ 48.83 / 49.52 ±0.60 / 50.21 ms │ 47.29 / 48.80 ±2.01 / 52.69 ms │ no change │
│ QQuery 84 │ 53.99 / 55.56 ±1.12 / 57.06 ms │ 52.12 / 54.29 ±1.53 / 56.75 ms │ no change │
│ QQuery 85 │ 155.40 / 158.03 ±2.01 / 161.58 ms │ 154.37 / 157.12 ±3.44 / 163.69 ms │ no change │
│ QQuery 86 │ 43.38 / 44.24 ±0.71 / 45.36 ms │ 43.64 / 44.86 ±1.61 / 48.04 ms │ no change │
│ QQuery 87 │ 94.10 / 97.02 ±4.03 / 104.64 ms │ 91.91 / 100.23 ±6.95 / 111.29 ms │ no change │
│ QQuery 88 │ 115.23 / 118.23 ±1.59 / 119.98 ms │ 116.32 / 118.77 ±1.90 / 121.72 ms │ no change │
│ QQuery 89 │ 127.10 / 128.18 ±0.98 / 129.95 ms │ 127.43 / 129.66 ±2.23 / 133.62 ms │ no change │
│ QQuery 90 │ 30.52 / 31.26 ±0.87 / 32.94 ms │ 29.69 / 30.82 ±0.84 / 32.06 ms │ no change │
│ QQuery 91 │ 67.63 / 70.58 ±2.29 / 73.44 ms │ 68.00 / 69.99 ±1.36 / 72.04 ms │ no change │
│ QQuery 92 │ 62.47 / 63.82 ±1.28 / 66.02 ms │ 62.88 / 63.93 ±1.59 / 67.08 ms │ no change │
│ QQuery 93 │ 195.30 / 204.40 ±6.85 / 213.49 ms │ 197.09 / 203.57 ±5.30 / 211.36 ms │ no change │
│ QQuery 94 │ 69.33 / 70.34 ±0.57 / 70.92 ms │ 68.38 / 69.13 ±0.89 / 70.77 ms │ no change │
│ QQuery 95 │ 142.69 / 146.35 ±2.80 / 151.20 ms │ 144.79 / 148.14 ±2.35 / 150.86 ms │ no change │
│ QQuery 96 │ 78.19 / 82.18 ±2.03 / 83.82 ms │ 80.13 / 82.69 ±1.64 / 84.82 ms │ no change │
│ QQuery 97 │ 133.59 / 137.80 ±4.41 / 146.05 ms │ 136.70 / 141.90 ±5.31 / 151.77 ms │ no change │
│ QQuery 98 │ 159.63 / 163.76 ±3.82 / 170.15 ms │ 155.17 / 164.67 ±7.62 / 174.91 ms │ no change │
│ QQuery 99 │ 10988.42 / 11009.46 ±11.96 / 11021.03 ms │ 10949.22 / 11042.04 ±119.09 / 11274.43 ms │ no change │
└───────────┴──────────────────────────────────────────┴───────────────────────────────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 35941.40ms │
│ Total Time (batched-accumulator-storage) │ 36158.24ms │
│ Average Time (HEAD) │ 363.04ms │
│ Average Time (batched-accumulator-storage) │ 365.23ms │
│ Queries Faster │ 0 │
│ Queries Slower │ 1 │
│ Queries with No Change │ 98 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────┴────────────┘
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpcds — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 180.1s |
| Peak memory | 5.5 GiB |
| Avg memory | 4.6 GiB |
| CPU user | 288.0s |
| CPU sys | 21.9s |
| Disk read | 0 B |
| Disk write | 636.1 MiB |
**tpcds — branch**
| Metric | Value |
|--------|-------|
| Wall time | 181.1s |
| Peak memory | 5.6 GiB |
| Avg memory | 4.5 GiB |
| CPU user | 289.5s |
| CPU sys | 21.9s |
| Disk read | 0 B |
| Disk write | 792.0 KiB |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068938441
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068907576)
`Linux bench-c4068907576-332-ffs4j 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (439ee1973b4d1c0863c9c10050ea744066a89b96) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..439ee1973b4d1c0863c9c10050ea744066a89b96) using: tpch
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068520115
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068495691)
`Linux bench-c4068495691-318-c6cjz 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (495b6f20d5f5fd5b6851877f1c43f290f142d95e) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..495b6f20d5f5fd5b6851877f1c43f290f142d95e) using: clickbench_partitioned
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068495691
run benchmarks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068927400
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068907576)
`Linux bench-c4068907576-331-hsmqs 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (439ee1973b4d1c0863c9c10050ea744066a89b96) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..439ee1973b4d1c0863c9c10050ea744066a89b96) using: tpcds
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068712892
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068698039)
`Linux bench-c4068698039-329-klqt8 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (1ae75c7a5e0256d18053dc6f026d12b712ca8d56) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..1ae75c7a5e0256d18053dc6f026d12b712ca8d56) using: tpch
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4068545555
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4068525672)
`Linux bench-c4068525672-321-jn54c 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (495b6f20d5f5fd5b6851877f1c43f290f142d95e) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..495b6f20d5f5fd5b6851877f1c43f290f142d95e) using: clickbench_partitioned
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4069058239
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4069055822)
`Linux bench-c4069055822-334-9fnd5 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing batched-accumulator-storage (13808a7f7401129e3dcdf27d8e738a8181a4a26c) to 9c3c01a (merge-base) [diff](https://github.com/apache/datafusion/compare/9c3c01aa54fbf24bb0779e04d47a1492983ed4d7..13808a7f7401129e3dcdf27d8e738a8181a4a26c) using: clickbench_extended
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org