You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/21 06:25:25 UTC

[GitHub] [spark] mridulm commented on pull request #31876: [SPARK-34942][API][CORE] Abstract Location in MapStatus to enable support for custom storage

mridulm commented on pull request #31876:
URL: https://github.com/apache/spark/pull/31876#issuecomment-823810533


   `HostLocation` looks fine to me; we should change all `asInstanceOf[BlockManagerId].host` to using `HostLocation`.
   Trying to understand why `ExecutorLocation` and not `BlockManagerId` itself ? When does it help to decouple both ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org