You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/22 18:59:57 UTC

[GitHub] [pinot] Jackie-Jiang commented on pull request #8382: builtin datetime functions to avoid throwing NullPointerException when input value is null

Jackie-Jiang commented on pull request #8382:
URL: https://github.com/apache/pinot/pull/8382#issuecomment-1075520071


   @nizarhejazi If a method can take null parameters, it should handle all the parameters properly. In the scenario you described, the method can return null when it cannot handle the passed in null value.
   The reason why we might not want to check nulls during `invoke` is that this will bring overhead to all invocations of the function, but in most places the arguments won't be null


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org