You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Brian Lillie (JIRA)" <ji...@apache.org> on 2012/05/01 19:54:49 UTC
[jira] [Created] (SHINDIG-1764) Missed request in SHINDIG-1756
Brian Lillie created SHINDIG-1764:
-------------------------------------
Summary: Missed request in SHINDIG-1756
Key: SHINDIG-1764
URL: https://issues.apache.org/jira/browse/SHINDIG-1764
Project: Shindig
Issue Type: Bug
Components: Java
Affects Versions: 2.5.0
Reporter: Brian Lillie
Fix For: 2.5.0
SHINDIG-1756 sets the origination information for a request, either marking internal or adding an AnonymousSecurityToken. One of the requests in the OAuthRequest class was missed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1764) Missed request in SHINDIG-1756
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266679#comment-13266679 ]
jiraposter@reviews.apache.org commented on SHINDIG-1764:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4949/#review7471
-----------------------------------------------------------
Ship it!
Committed revision 1333101.
Please mark this review as submitted. Thanks.
- Stanton
On 2012-05-02 16:19:28, BrianLillie wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4949/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-02 16:19:28)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add an AnonymousSecurityToken to the OAuthRequest exchange request. This was missed in SHINDIG-1756
bq.
bq.
bq. This addresses bug SHINDIG-1764.
bq. https://issues.apache.org/jira/browse/SHINDIG-1764
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java 1331477
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/testing/FakeOAuthServiceProvider.java 1331477
bq.
bq. Diff: https://reviews.apache.org/r/4949/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Existing tests passed. OAuthRequestTest updated.
bq.
bq.
bq. Thanks,
bq.
bq. BrianLillie
bq.
bq.
> Missed request in SHINDIG-1756
> ------------------------------
>
> Key: SHINDIG-1764
> URL: https://issues.apache.org/jira/browse/SHINDIG-1764
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0
> Reporter: Brian Lillie
> Fix For: 2.5.0
>
> Attachments: origination_fix.patch
>
>
> SHINDIG-1756 sets the origination information for a request, either marking internal or adding an AnonymousSecurityToken. The exchange token request in the OAuthRequest class was missed in these updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1764) Missed request in SHINDIG-1756
Posted by "Brian Lillie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Lillie updated SHINDIG-1764:
----------------------------------
Description: SHINDIG-1756 sets the origination information for a request, either marking internal or adding an AnonymousSecurityToken. The exchange token request in the OAuthRequest class was missed in these updates. (was: SHINDIG-1756 sets the origination information for a request, either marking internal or adding an AnonymousSecurityToken. One of the requests in the OAuthRequest class was missed.)
> Missed request in SHINDIG-1756
> ------------------------------
>
> Key: SHINDIG-1764
> URL: https://issues.apache.org/jira/browse/SHINDIG-1764
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0
> Reporter: Brian Lillie
> Fix For: 2.5.0
>
>
> SHINDIG-1756 sets the origination information for a request, either marking internal or adding an AnonymousSecurityToken. The exchange token request in the OAuthRequest class was missed in these updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1764) Missed request in SHINDIG-1756
Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter updated SHINDIG-1764:
---------------------------------
Fix Version/s: (was: 2.5.0)
2.5.0-beta2
> Missed request in SHINDIG-1756
> ------------------------------
>
> Key: SHINDIG-1764
> URL: https://issues.apache.org/jira/browse/SHINDIG-1764
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0
> Reporter: Brian Lillie
> Fix For: 2.5.0-beta2
>
> Attachments: origination_fix.patch
>
>
> SHINDIG-1756 sets the origination information for a request, either marking internal or adding an AnonymousSecurityToken. The exchange token request in the OAuthRequest class was missed in these updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1764) Missed request in SHINDIG-1756
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266672#comment-13266672 ]
jiraposter@reviews.apache.org commented on SHINDIG-1764:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4949/
-----------------------------------------------------------
(Updated 2012-05-02 16:19:28.366547)
Review request for shindig.
Summary
-------
Add an AnonymousSecurityToken to the OAuthRequest exchange request. This was missed in SHINDIG-1756
This addresses bug SHINDIG-1764.
https://issues.apache.org/jira/browse/SHINDIG-1764
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java 1331477
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/testing/FakeOAuthServiceProvider.java 1331477
Diff: https://reviews.apache.org/r/4949/diff
Testing
-------
Existing tests passed. OAuthRequestTest updated.
Thanks,
BrianLillie
> Missed request in SHINDIG-1756
> ------------------------------
>
> Key: SHINDIG-1764
> URL: https://issues.apache.org/jira/browse/SHINDIG-1764
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0
> Reporter: Brian Lillie
> Fix For: 2.5.0
>
> Attachments: origination_fix.patch
>
>
> SHINDIG-1756 sets the origination information for a request, either marking internal or adding an AnonymousSecurityToken. The exchange token request in the OAuthRequest class was missed in these updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1764) Missed request in SHINDIG-1756
Posted by "Stanton Sievers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stanton Sievers resolved SHINDIG-1764.
--------------------------------------
Resolution: Fixed
Committed revision 1333101.
> Missed request in SHINDIG-1756
> ------------------------------
>
> Key: SHINDIG-1764
> URL: https://issues.apache.org/jira/browse/SHINDIG-1764
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0
> Reporter: Brian Lillie
> Fix For: 2.5.0
>
> Attachments: origination_fix.patch
>
>
> SHINDIG-1756 sets the origination information for a request, either marking internal or adding an AnonymousSecurityToken. The exchange token request in the OAuthRequest class was missed in these updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1764) Missed request in SHINDIG-1756
Posted by "Brian Lillie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Lillie updated SHINDIG-1764:
----------------------------------
Attachment: origination_fix.patch
> Missed request in SHINDIG-1756
> ------------------------------
>
> Key: SHINDIG-1764
> URL: https://issues.apache.org/jira/browse/SHINDIG-1764
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0
> Reporter: Brian Lillie
> Fix For: 2.5.0
>
> Attachments: origination_fix.patch
>
>
> SHINDIG-1756 sets the origination information for a request, either marking internal or adding an AnonymousSecurityToken. The exchange token request in the OAuthRequest class was missed in these updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira