You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zzzxl1993 (via GitHub)" <gi...@apache.org> on 2023/04/20 09:31:31 UTC
[GitHub] [doris-thirdparty] zzzxl1993 opened a new pull request, #58: [Fix](clucene) fix data race and memory leak
zzzxl1993 opened a new pull request, #58:
URL: https://github.com/apache/doris-thirdparty/pull/58
1. fix data race and memory leak
2. simple tokenizer lut optimize
3. add clucene index and search test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris-thirdparty] airborne12 commented on a diff in pull request #58: [Fix](clucene) fix data race and memory leak
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on code in PR #58:
URL: https://github.com/apache/doris-thirdparty/pull/58#discussion_r1173423743
##########
src/core/CLucene/analysis/Analyzers.cpp:
##########
@@ -38,23 +38,20 @@ Token *CharTokenizer<char>::next(Token *token) {
return NULL;
} else
c = ioBuffer[bufferIndex++];
- if (isTokenChar(c)) {// if it's a token TCHAR
+ if (is_alnum(c)) {// if it's a token TCHAR
if (length == 0)// start of token
start = offset - 1;
- //buffer[length++] = normalize(c); // buffer it, normalized
- buffer[length++] = c;
+ buffer[length++] = to_lower(c); // buffer it, normalized
Review Comment:
same as isTokenchar's problem
##########
src/core/CLucene/analysis/Analyzers.cpp:
##########
@@ -38,23 +38,20 @@ Token *CharTokenizer<char>::next(Token *token) {
return NULL;
} else
c = ioBuffer[bufferIndex++];
- if (isTokenChar(c)) {// if it's a token TCHAR
Review Comment:
change isTokenChar to is_alnum will change other tokenizer's behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org
[GitHub] [doris-thirdparty] adonis0147 merged pull request #58: [Fix](clucene) fix data race and memory leak
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 merged PR #58:
URL: https://github.com/apache/doris-thirdparty/pull/58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org